> On April 24, 2013, 10 p.m., Thomas Baumgart wrote: > > kmymoney/plugins/csvexport/csvwriter.cpp, line 101 > > <http://git.reviewboard.kde.org/r/109803/diff/4/?file=140785#file140785line101> > > > > why not using "\n\n" instead? Your way needs one more byte of mem plus > > cpu time during each call. > > Allan Anderson wrote: > Why not, indeed? Just harking back to your comment about using > QLatin1String/Char, was that just instead of Qstring("blahblah"), or also for > "blah" + "blah1"? The article left me in doubt. > > Thomas Baumgart wrote: > Concatenation using either + or % uses runtime. Having a fixed string > does not. I agree, it is just a small portion of cpu time but things like > that add up and one should always have an eye on them. > > Allan Anderson wrote: > Yes, I'm OK so far as concatenation is concerned. Also, I'm OK so far as > QString("blahblah") being replaced by QLatin1String("blahblah"). What I was > unclear about was whether the string "blah" should be QLatin1String("blah")? > I get the impression that both are OK, but that QLatin1String is for the sake > of consistency.
AFAIU, the string "blah" will be auto casted to a QString in the background (code is emitted by the compiler to do so at runtime). One can turn this off by defining QT_NO_CAST_FROM_ASCII. See http://qt-project.org/doc/qt-4.8/qstring.html#QString-8 and also a bunch of forum entries on the net. - Thomas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review31509 ----------------------------------------------------------- On April 24, 2013, 6:16 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109803/ > ----------------------------------------------------------- > > (Updated April 24, 2013, 6:16 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > Add CSV export capability. Modify existing KMyMoney File menu in order to > make menu item positions more logical. > > > This addresses bug 317614. > http://bugs.kde.org/show_bug.cgi?id=317614 > > > Diffs > ----- > > kmymoney/kmymoneyui.rc f353641 > kmymoney/plugins/CMakeLists.txt 81ca458 > kmymoney/plugins/csvexport/CMakeLists.txt PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlg.h PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlg.cpp PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlg.ui PRE-CREATION > kmymoney/plugins/csvexport/csvexporterplugin.h PRE-CREATION > kmymoney/plugins/csvexport/csvexporterplugin.cpp PRE-CREATION > kmymoney/plugins/csvexport/csvwriter.h PRE-CREATION > kmymoney/plugins/csvexport/csvwriter.cpp PRE-CREATION > kmymoney/plugins/csvexport/kmm_csvexport.desktop PRE-CREATION > kmymoney/plugins/csvexport/kmm_csvexport.rc PRE-CREATION > kmymoney/plugins/csvimport/investprocessing.cpp 07d4d82 > kmymoney/plugins/csvimport/kmm_csvimport.rc d678169 > > Diff: http://git.reviewboard.kde.org/r/109803/diff/ > > > Testing > ------- > > Exported numerous checking and investment CSV files, and then imported into > KMyMoney via CSV import (discovering a few minor issues in the existing > KMyMoney accounts in the process.) > Ran astyle and Krazy2. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
