----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109803/#review31271 -----------------------------------------------------------
kmymoney/plugins/csvexport/csvexporterrc <http://git.reviewboard.kde.org/r/109803/#comment23267> I would not commit this section since it contains your last settings. kmymoney/plugins/csvexport/csvwriter.cpp <http://git.reviewboard.kde.org/r/109803/#comment23270> You should leave only your email if it's a new file. kmymoney/plugins/csvexport/kmm_csvexport.desktop <http://git.reviewboard.kde.org/r/109803/#comment23269> Please remove the translations (all [lang] entries) since they will be handled by the translation teams. kmymoney/plugins/csvexport/ui_csvexportdlgdecl.h <http://git.reviewboard.kde.org/r/109803/#comment23268> This is a generated file by the build system and should not be committed. - Cristian Oneț On March 30, 2013, 6:42 p.m., Allan Anderson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109803/ > ----------------------------------------------------------- > > (Updated March 30, 2013, 6:42 p.m.) > > > Review request for KMymoney. > > > Description > ------- > > Add CSV export capability. Modify existing KMyMoney File menu in order to > make menu item positions more logical. > > > This addresses bug 317614. > http://bugs.kde.org/show_bug.cgi?id=317614 > > > Diffs > ----- > > kmymoney/kmymoneyui.rc f353641 > kmymoney/plugins/CMakeLists.txt 81ca458 > kmymoney/plugins/csvexport/CMakeLists.txt PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlg.h PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlg.cpp PRE-CREATION > kmymoney/plugins/csvexport/csvexportdlgdecl.ui PRE-CREATION > kmymoney/plugins/csvexport/csvexporterplugin.h PRE-CREATION > kmymoney/plugins/csvexport/csvexporterplugin.cpp PRE-CREATION > kmymoney/plugins/csvexport/csvexporterrc PRE-CREATION > kmymoney/plugins/csvexport/csvwriter.h PRE-CREATION > kmymoney/plugins/csvexport/csvwriter.cpp PRE-CREATION > kmymoney/plugins/csvexport/kmm_csvexport.desktop PRE-CREATION > kmymoney/plugins/csvexport/kmm_csvexport.rc PRE-CREATION > kmymoney/plugins/csvexport/ui_csvexportdlgdecl.h PRE-CREATION > kmymoney/plugins/csvimport/investprocessing.cpp 07d4d82 > kmymoney/plugins/csvimport/kmm_csvimport.rc d678169 > > Diff: http://git.reviewboard.kde.org/r/109803/diff/ > > > Testing > ------- > > Exported numerous checking and investment CSV files, and then imported into > KMyMoney via CSV import (discovering a few minor issues in the existing > KMyMoney accounts in the process.) > Ran astyle and Krazy2. > > > Thanks, > > Allan Anderson > >
_______________________________________________ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-devel
