Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Allan Anderson
> On Jan. 24, 2016, 9:02 p.m., Christian David wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1458 > > > > > > Translated strings should not be combined, as it confuses the > > translators. It i

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Alvaro Soliverez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126875/#review92741 --- Fix it, then Ship it! Ship It! kmymoney/converter/mymone

Re: Review Request 126888: Fix locale conflict in kMyMoneyMoneyValidator

2016-02-24 Thread Alexey Chernov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126888/ --- (Updated Feb. 24, 2016, 8:26 p.m.) Status -- This change has been ma

[kmymoney] [Bug 358573] Unable to enter fraction part when decimal point of current locale differs from "."

2016-02-24 Thread Alexey Chernov via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=358573 Alexey Chernov <4er...@gmail.com> changed: What|Removed |Added Resolution|--- |FIXED Status|UNC

Re: Review Request 126888: Fix locale conflict in kMyMoneyMoneyValidator

2016-02-24 Thread Alexey Chernov
> On Фев. 24, 2016, 11:59 д.п., Christian David wrote: > > Okay, I got it – our validator is a bit more complicated than needed. The > > request looks fine to me. Do you have the right to push the changes? Thank you! Yes, I have KDE git write permissions, so I hope I can merge this change. -

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Artur Puzio
> On Sty 25, 2016, 11:55 rano, Alvaro Soliverez wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1451 > > > > > > In this case, html tags could be added outside the i18n. By adding them > > within

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Artur Puzio
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126875/ --- (Updated Lut 24, 2016, 7:49 po południu) Review request for KMymoney and

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Allan Anderson
> On Jan. 24, 2016, 9:02 p.m., Christian David wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1458 > > > > > > Translated strings should not be combined, as it confuses the > > translators. It i

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Christian David
> On Jan. 24, 2016, 10:02 p.m., Christian David wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1458 > > > > > > Translated strings should not be combined, as it confuses the > > translators. It

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Allan Anderson
> On Jan. 24, 2016, 9:02 p.m., Christian David wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1458 > > > > > > Translated strings should not be combined, as it confuses the > > translators. It i

[kmymoney4] [Bug 353372] OFX files are double encoded which messes up the £ sign

2016-02-24 Thread Christian David via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=353372 Christian David changed: What|Removed |Added Latest Commit|http://commits.kde.org/kmym |http://commits.kde.org/kmym

Re: [kmymoney4] [Bug 359739] New: Incorrect label for New Investment entry

2016-02-24 Thread aga
On 24/02/16 03:22, Jan via KDE Bugzilla wrote: https://bugs.kde.org/show_bug.cgi?id=359739 Bug ID: 359739 Summary: Incorrect label for New Investment entry Product: kmymoney4 Version: 4.6.6 Platform: Other OS: Linux

Re: Review Request 126888: Fix locale conflict in kMyMoneyMoneyValidator

2016-02-24 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126888/#review92723 --- Ship it! Okay, I got it – our validator is a bit more comp

Re: Review Request 126888: Fix locale conflict in kMyMoneyMoneyValidator

2016-02-24 Thread Alexey Chernov
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126888/ --- (Updated Фев. 24, 2016, 11:11 д.п.) Review request for KMymoney, Christia

Re: Review Request 126888: Fix locale conflict in kMyMoneyMoneyValidator

2016-02-24 Thread Alexey Chernov
> On Фев. 24, 2016, 8:25 д.п., Christian David wrote: > > Are you sure you used the branch "master"? Because that should not compile > > with Qt 5 and KF 5 at all. > > > > Also I am suprised that setting ```setLocale(QLocale::c());``` works here. Oh, sorry, no, it's "frameworks" branch, I'll c

Jenkins-kde-ci: kmymoney frameworks kf5-qt5 » Linux,gcc - Build # 44 - Fixed!

2016-02-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmymoney%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Feb 2016 10:28:14 + Build duration: 9 min 14 sec CHANGE SET Revision d9cf5550c478d95d4faf312c1149f30829

Jenkins-kde-ci: kmymoney frameworks kf5-qt5 » Linux,gcc - Build # 44 - Fixed!

2016-02-24 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/kmymoney%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/44/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Feb 2016 10:28:14 + Build duration: 9 min 14 sec CHANGE SET Revision d9cf5550c478d95d4faf312c1149f30829

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Christian David
> On Jan. 24, 2016, 10:02 p.m., Christian David wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1458 > > > > > > Translated strings should not be combined, as it confuses the > > translators. It

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Christian David
> On Jan. 25, 2016, 11:55 a.m., Alvaro Soliverez wrote: > > kmymoney/converter/mymoneystatementreader.cpp, line 1451 > > > > > > In this case, html tags could be added outside the i18n. By adding them > > withi

Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

2016-02-24 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126875/#review92712 --- Ship it! Ship It! - Christian David On Jan. 24, 2016, 1

Re: Review Request 126888: Fix locale conflict in kMyMoneyMoneyValidator

2016-02-24 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126888/#review92708 --- Are you sure you used the branch "master"? Because that shoul

Jenkins-kde-ci: kmymoney frameworks kf5-qt5 » Linux,gcc - Build # 43 - Failure!

2016-02-24 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kmymoney%20frameworks%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 24 Feb 2016 07:54:48 + Build duration: 1 min 29 sec CHANGE SET Revision 8a711722352fdedd623ddb2c3cfd7b9837