Re: Review Request 126875: Combined the questions from TransactionMatcher::match and MyMoneyStatementReader::askUserToEnterScheduleForMatching

[Artur Puzio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126875/
-----------------------------------------------------------

(Updated Lut 24, 2016, 7:49 po południu)


Review request for KMymoney and Christian David.


Changes
-------

Moved HTML tags outside i18n strings


Repository: kmymoney


Description
-------

Moved the question from `TransactionMatcher::match` to 
`MyMoneyStatementReader::askUserToEnterScheduleForMatching`.
Added `MyMoneyTransaction & importedTransaction` parmeter to 
`MyMoneyStatementReader::askUserToEnterScheduleForMatching`, as 
`importedTransation` is required to calculate if the question from 
`TransactionMatcher::match` should be shown.


Diffs (updated)
-----

  kmymoney/converter/mymoneystatementreader.h 
80da2023490a99963b5ff85c8d77cf1d8b58bf2b 
  kmymoney/converter/mymoneystatementreader.cpp 
1634bbb37ec86d0f065a73427cd353697812c79e 
  kmymoney/dialogs/transactionmatcher.cpp 
7d9740411b96940ac848009218dce65ffaac061e 

Diff: https://git.reviewboard.kde.org/r/126875/diff/


Testing
-------

Automated tests still pass, but they don't check the subject of work.
Screenshot: [link](https://imgur.com/3Veh70N)


Thanks,

Artur Puzio