[Kmymoney-devel] [Bug 311481] It is possible to create a schedule with empty name

2012-12-10 Thread Dimitrios Glentadakis
https://bugs.kde.org/show_bug.cgi?id=311481 Dimitrios Glentadakis changed: What|Removed |Added URL||http://glenbox.free.fr/vide

[Kmymoney-devel] [Bug 311481] It is possible to create a schedule with empty name

2012-12-10 Thread Thomas Baumgart
https://bugs.kde.org/show_bug.cgi?id=311481 --- Comment #1 from Thomas Baumgart --- The problem is with the two methods to control the enabled state of the OK button in this case. One is the kMandatoryFieldGroup created in the KEditScheduleDlg ctor and the other the line connect(editor, SIGNAL

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-10 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107137/#review23286 --- This review has been submitted with commit 5be704bafd01bcf34fd

[Kmymoney-devel] [Bug 311481] New: It is possible to create a schedule with empty name

2012-12-10 Thread Marko Käning
https://bugs.kde.org/show_bug.cgi?id=311481 Bug ID: 311481 Severity: normal Version: git master Priority: NOR Assignee: kmymoney-devel@kde.org Summary: It is possible to create a schedule with empty name Classification: Unclassifi

[Kmymoney-devel] [Bug 267589] Crash when assigning the transfer account of a freshly imported transaction

2012-12-10 Thread Marko Käning
https://bugs.kde.org/show_bug.cgi?id=267589 --- Comment #5 from Marko Käning --- Still around in Qt 4.8.4: ___ Program received signal SIGSEGV, Segmentation fault. 0x0001047f1737 in QWidget::effectiveWinId() const () from /opt/macports-test/Library/Frameworks/QtGui.framework/Versions/4/QtG

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction (not yet functioning as expected)

2012-12-10 Thread Marko Käning
> On Dec. 7, 2012, 6:50 p.m., Cristian Oneț wrote: > > kmymoney/views/khomeview.cpp, line 865 > > > > > > You are comparing the last reconciliation date with the last imported > > transaction date, it that what you

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-10 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107137/#review23277 --- Ship it! Nice (and fast) job :). - Cristian Oneț On Dec. 10

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-10 Thread Łukasz Maszczyński
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107137/ --- (Updated Dec. 10, 2012, 4:30 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-10 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107137/#review23276 --- CMakeLists.txt

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-10 Thread Łukasz Maszczyński
2012/12/10 Thomas Baumgart : > Hi all, > > On Sunday 09 December 2012 09:32:01 Alvaro Soliverez wrote: >> >> I don't have the final word on this, but my vote is against adding boost as >> a dependency. At least, until a real benefit for the application is shown. > > I second Alvaro's opinion on thi

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-10 Thread Łukasz Maszczyński
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107137/ --- (Updated Dec. 10, 2012, 4:11 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction (not yet functioning as expected)

2012-12-10 Thread Cristian Oneț
> On Dec. 7, 2012, 6:50 p.m., Cristian Oneț wrote: > > kmymoney/views/khomeview.cpp, line 865 > > > > > > You are comparing the last reconciliation date with the last imported > > transaction date, it that what you

Re: [Kmymoney-devel] Review Request: Some i18n improvements

2012-12-10 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/103622/#review23272 --- Ship it! Ship It! - Cristian Oneț On Dec. 9, 2012, 1:25 p.m

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-10 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107137/#review23271 --- kmymoney/dialogs/transactionmatchfinder.h

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

2012-12-10 Thread Thomas Baumgart
Hi all, On Sunday 09 December 2012 09:32:01 Alvaro Soliverez wrote: > Every dependency we bring into KMyMoney has a clear set of features and > benefits for the application (libGMP, libofx, aqbanking, etc.). In this > case, I only see a limited value for the developers. And it seems to me, > this

[Kmymoney-devel] [Bug 296883] OFX and QIF import of investment Buy / Sell transactions not assigned to brokerage account

2012-12-10 Thread George Baltz
https://bugs.kde.org/show_bug.cgi?id=296883 George Baltz changed: What|Removed |Added CC||geoba...@gmail.com --- Comment #3 from George Ba

[Kmymoney-devel] [Bug 296883] OFX and QIF import of investment Buy / Sell transactions not assigned to brokerage account

2012-12-10 Thread George Baltz
https://bugs.kde.org/show_bug.cgi?id=296883 --- Comment #2 from George Baltz --- Created attachment 75767 --> https://bugs.kde.org/attachment.cgi?id=75767&action=edit Patch to use brokerage account as default for buy/sell Patch checked out on QIF file imported from Moneydance. -- You are rec