Re: [Kmymoney-devel] Review Request: Some i18n improvements

> On April 28, 2012, 6:52 a.m., Marko Käning wrote: > > This looks all sensible to me. > > > > > > And yes, why wouldn't one want to use this approach: > > > > > -why are the month names as translatable strings in there, isn't it > > > enough to call QDate::longMonthName()? > > > > > >

Re: [Kmymoney-devel] Review Request: Some i18n improvements

> On April 28, 2012, 6:52 a.m., Marko Käning wrote: > > This looks all sensible to me. > > > > > > And yes, why wouldn't one want to use this approach: > > > > > -why are the month names as translatable strings in there, isn't it > > > enough to call QDate::longMonthName()? > > > > Pin

Re: [Kmymoney-devel] Review Request: show another icon on homepage accounts tables if there are transactions after the last online transaction (not yet functioning as expected)

> On Dec. 7, 2012, 6:50 p.m., Cristian Oneț wrote: > > kmymoney/views/khomeview.cpp, line 865 > > > > > > You are comparing the last reconciliation date with the last imported > > transaction date, it that what you

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

BTW, when the Transaction objects are created, they are initialized, so I really don't see why boost::optional should be used here. On Sat, Dec 8, 2012 at 2:08 PM, Alvaro Soliverez wrote: > I disagree. It's not about adding a non-Qt dependency, which KMyMoney > already has a few. It's about add

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

I disagree. It's not about adding a non-Qt dependency, which KMyMoney already has a few. It's about adding a new dependency without a sound rationale, just for a convenience class that one or another developer has grown used to. I still don't see boost bringing in enough of an improvement to add a

[Kmymoney-devel] [Bug 311357] New: kmm crashes when filtering categories

https://bugs.kde.org/show_bug.cgi?id=311357 Bug ID: 311357 Severity: crash Version: 4.6.1 Priority: NOR Assignee: kmymoney-devel@kde.org Summary: kmm crashes when filtering categories Classification: Unclassified O

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

> On Dec. 7, 2012, 6:35 p.m., Cristian Oneț wrote: > > > > Cristian Oneț wrote: > I don't have anything else to add other than these two issues and the > boost hard dependency. If the dependency get's the OK from the others and > these small issues are fixed then this review is OK to be sh

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107137/ --- (Updated Dec. 8, 2012, 4:49 p.m.) Review request for KMymoney. Changes -

Re: [Kmymoney-devel] Review Request: Refactoring of matching a transaction-under-import

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107137/ --- (Updated Dec. 8, 2012, 4:45 p.m.) Review request for KMymoney. Changes -

[Kmymoney-devel] [Bug 311347] New: Kmymoney crash

https://bugs.kde.org/show_bug.cgi?id=311347 Bug ID: 311347 Severity: crash Version: 4.6.1 Priority: NOR Assignee: kmymoney-devel@kde.org Summary: Kmymoney crash Classification: Unclassified OS: Linux Repo