Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/#review44847 --- Sorry, a couple more things... tier4/frameworkintegration/src

Re: Dialogs, QPT and Qt5

Hi! 2013/11/29 Albert Astals Cid > El Divendres, 29 de novembre de 2013, a les 12:22:48, Kevin Ottens va > escriure: > > On Friday 29 November 2013 12:00:38 Christoph Feck wrote: > > > On Friday 29 November 2013 08:53:06 Kevin Ottens wrote: > > > > KColorDialog and KFontDialog are out of the pic

Re: Dialogs, QPT and Qt5

El Divendres, 29 de novembre de 2013, a les 12:22:48, Kevin Ottens va escriure: > On Friday 29 November 2013 12:00:38 Christoph Feck wrote: > > On Friday 29 November 2013 08:53:06 Kevin Ottens wrote: > > > KColorDialog and KFontDialog are out of the picture. We contributed > > > to the upstream QC

Re: Review Request 114208: Rest of frameworks adapted to tier1 renamings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114208/ --- (Updated Nov. 29, 2013, 4:37 p.m.) Review request for KDE Frameworks. Ch

Review Request 114208: Rest of frameworks adapted to tier1 renamings

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114208/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 112880: Added KColorSchemeToken class.

> On Oct. 21, 2013, 11:22 a.m., Kevin Ottens wrote: > > To get in this patch would benefit from being based on the frameworks > > branch and go into kdeclarative. > > Kevin Ottens wrote: > Any chance for an update? > > Denis Kuplyakov wrote: > Yes I will finish it, when have time. Ther

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/#review44804 --- Looks good to me ! I'll try the patch some time this week-end,

Re: Review Request 114050: Add manual test app for enableBlurBehind.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/ --- (Updated Nov. 29, 2013, 2:42 p.m.) Status -- This change has been mar

Re: Review Request 114050: Add manual test app for enableBlurBehind.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/#review44803 --- This review has been submitted with commit b3d2f1812df15c4a1c4

Re: Dialogs, QPT and Qt5

On Friday 29 November 2013 12:45:42 Hugo Pereira Da Costa wrote: > On 11/29/2013 12:22 PM, Kevin Ottens wrote: > > On Friday 29 November 2013 12:00:38 Christoph Feck wrote: > >> - allows limiting to only change family, style, or size > > > > To upstream if that's used (IIRC almost no user again). >

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/ --- (Updated Nov. 29, 2013, 1:28 p.m.) Review request for KDE Frameworks. Re

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

> On Nov. 29, 2013, 8:52 a.m., Kevin Ottens wrote: > > tier4/frameworkintegration/src/kstyle/kstyle.h, line 1518 > > > > > > If you use Q_DECL_OVERRIDE, no need to repeat the virtual (applies to > > most of the

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/ --- (Updated Nov. 29, 2013, 1:04 p.m.) Review request for KDE Frameworks. Ch

Re: Dialogs, QPT and Qt5

On Fri, Nov 29, 2013 at 12:45 PM, Hugo Pereira Da Costa < hugo.pere...@free.fr> wrote: > On 11/29/2013 12:22 PM, Kevin Ottens wrote: > > On Friday 29 November 2013 12:00:38 Christoph Feck wrote: > > On Friday 29 November 2013 08:53:06 Kevin Ottens wrote: > > KColorDialog and KFontDialog are out

Re: Review Request 114200: Add include for klocalizedstring in klocale.h

> On Nov. 29, 2013, 1:28 p.m., Albert Astals Cid wrote: > > No, in KDE4 times, you got KLocalizedString though klocalizedstring.h, if > > people is including KLocale just for KLocalizedString that's "wrong" and i > > think adding this include is doing people a dis-service by maing think they >

Re: Review Request 114200: Add include for klocalizedstring in klocale.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114200/#review44796 --- No, in KDE4 times, you got KLocalizedString though klocalizedst

Review Request 114200: Add include for klocalizedstring in klocale.h

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114200/ --- Review request for KDE Frameworks. Repository: kdelibs Description -

Re: Review Request 114195: Add license in K4AboutData -> KAboutData conversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114195/#review44794 --- This review has been submitted with commit 0c1549dbd22e69ee9c4

Re: Review Request 114195: Add license in K4AboutData -> KAboutData conversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114195/ --- (Updated Nov. 29, 2013, 12:15 p.m.) Status -- This change has been ma

Re: Dialogs, QPT and Qt5

On 11/29/2013 12:22 PM, Kevin Ottens wrote: On Friday 29 November 2013 12:00:38 Christoph Feck wrote: On Friday 29 November 2013 08:53:06 Kevin Ottens wrote: KColorDialog and KFontDialog are out of the picture. We contributed to the upstream QColorDialog and QFontDialog so that they have the fe

Re: Jenkins build is back to normal : kdelibs_frameworks_qt5 #1801

On Fri, Nov 29, 2013 at 10:24 AM, KDE CI System wrote: > See > > ___ > Kde-frameworks-devel mailing list > Kde-frameworks-devel@kde.org > https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114182/ --- (Updated Nov. 29, 2013, 11:30 a.m.) Review request for KDE Frameworks. C

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Re: Dialogs, QPT and Qt5

On Friday 29 November 2013 12:00:38 Christoph Feck wrote: > On Friday 29 November 2013 08:53:06 Kevin Ottens wrote: > > KColorDialog and KFontDialog are out of the picture. We contributed > > to the upstream QColorDialog and QFontDialog so that they have the > > features we needed out of the box. W

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Re: Dialogs, QPT and Qt5

On Friday 29 November 2013 08:53:06 Kevin Ottens wrote: > KColorDialog and KFontDialog are out of the picture. We contributed > to the upstream QColorDialog and QFontDialog so that they have the > features we needed out of the box. We only need to do something > for the file dialog. Not sure if we

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Jenkins build is back to normal : kdelibs_frameworks_qt5 #1801

See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Build failed in Jenkins: kdelibs_frameworks_qt5 #1800

See -- [...truncated 7457 lines...] [ 42%] [ 47%] [ 52%] [ 57%] [ 61%] [ 66%] [ 71%] Building CXX object src/CMakeFiles/KJobWidgets.dir/kabstractwidgetjobtracker.cpp.o Building CXX object src/CMakeFile

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Re: Review Request 114195: Add license in K4AboutData -> KAboutData conversion

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114195/#review44771 --- Ship it! Ship It! - Kevin Ottens On Nov. 29, 2013, 6:20 a.m

Re: Review Request 114184: Remove everything in kstyle that is not about KDE integration

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/#review44770 --- Wow this patch is even more impressive than I expected regardin

Re: Review Request 114182: Add Kf5 prefix for libs, eg. libKf5Foo

> On Nov. 28, 2013, 3:43 p.m., Kevin Ottens wrote: > > Looks fine to me. Makes me wonder if we want to drop the K for the target > > name "KF5::ConfigCore"? Just like Qt5Widgets becomes Qt5::Widgets... > > Martin Klapetek wrote: > Can do. Imho it makes sense but I'll wait for some other opi

Build failed in Jenkins: kdelibs_frameworks_qt5 #1799

See Changes: [faure] Avoid an unequal number of '{' and '}' due to #ifdef, it confuses astyle. -- [...truncated 7459 lines...] [ 42%] [ 47%] [ 52%] [ 57%] [ 61%] [ 66%] Building CXX object sr

Re: Review Request 114187: KFormat - Add new KFormat class

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114187/#review44768 --- Some extra comments. I'm not exactly sure I get your concerns

Re: Review Request 114050: Add manual test app for enableBlurBehind.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114050/#review44767 --- Ship it! Ship It! - Kevin Ottens On Nov. 28, 2013, 7:17 p.m

Re: Review Request 114185: Provide our own KFontDialog

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114185/#review44766 --- We need something similar (without linking to kde4support thoug

Build failed in Jenkins: kdelibs_frameworks_qt5 #1798

See Changes: [agateau] Fix standalone build of ktextwidgets -- [...truncated 7459 lines...] [ 42%] [ 47%] [ 52%] [ 57%] [ 61%] [ 66%] [ 71%] Building CXX object src/CMakeFiles/KJobWidgets.dir/