----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114184/#review44770 -----------------------------------------------------------
Wow this patch is even more impressive than I expected regarding the amount of stuff it removes. :-D tier4/frameworkintegration/src/kstyle/kstyle.h <http://git.reviewboard.kde.org/r/114184/#comment32009> If you use Q_DECL_OVERRIDE, no need to repeat the virtual (applies to most of the methods in here). tier4/frameworkintegration/src/kstyle/kstyle.h <http://git.reviewboard.kde.org/r/114184/#comment32010> Hmmm, I don't get that one... Which warning did you get? Because of the QApplication and QPalette overloads? tier4/frameworkintegration/src/kstyle/kstyle.cpp <http://git.reviewboard.kde.org/r/114184/#comment32011> Is it me or it's not needed anymore since the eventFilter method is gone? (not that it was doing anything meaningful previously). Even more so as you removed the removeEventFilter line from unpolish(). - Kevin Ottens On Nov. 28, 2013, 6:20 p.m., Àlex Fiestas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114184/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2013, 6:20 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > Removed everything from KStyle that is NOT about integrating with KDE. > > > Diffs > ----- > > tier4/frameworkintegration/src/kstyle/kstyle.h 4c83509 > tier4/frameworkintegration/src/kstyle/kstyle.cpp 626d2a9 > > Diff: http://git.reviewboard.kde.org/r/114184/diff/ > > > Testing > ------- > > > Thanks, > > Àlex Fiestas > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
