----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/114200/#review44796 -----------------------------------------------------------
No, in KDE4 times, you got KLocalizedString though klocalizedstring.h, if people is including KLocale just for KLocalizedString that's "wrong" and i think adding this include is doing people a dis-service by maing think they depend on a tier4 framework when maybe they don't. - Albert Astals Cid On Nov. 29, 2013, 12:22 p.m., Martin Gräßlin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/114200/ > ----------------------------------------------------------- > > (Updated Nov. 29, 2013, 12:22 p.m.) > > > Review request for KDE Frameworks. > > > Repository: kdelibs > > > Description > ------- > > One of the most often porting error I get is the lack of the KLocalizedString > include. In KDE4 times this was through klocale. So most files have an > include to klocale, but it is not used at all. > > By adding this include to klocale.h we can significantly decrease the initial > "get-it-compile-pain". > > > Diffs > ----- > > tier4/kde4support/src/kdecore/klocale.h 1c446fe > > Diff: http://git.reviewboard.kde.org/r/114200/diff/ > > > Testing > ------- > > > Thanks, > > Martin Gräßlin > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
