Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-22 Thread Albert Astals Cid
> On June 22, 2013, 8:43 p.m., Chusslove Illich wrote: > > Regarding the part in ki18n. > > > > On the technical side: > > > > Rather than doing configuration reading from new initializeLanguages > > function, it should be done inside existing > > KLocalizedStringPrivateStatics::initLocaleLangu

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-22 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/78/#review34888 --- Regarding the part in ki18n. On the technical side: Rather th

Re: Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/78/#review34886 --- On the way home i realized the loop on QLocale::Language alone

Jenkins build is back to stable : kdelibs_frameworks_qt5 #756

2013-06-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111178: KSwitchLanguageDialog: Reconsider how KLocalizedString is initialized

2013-06-22 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/78/ --- Review request for KDE Frameworks. Description --- While looking at t

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- (Updated June 22, 2013, 3:04 p.m.) Review request for KDE Frameworks and O

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Thomas Lübking
> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Aleix Pol Gonzalez
> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Review Request 111175: Move KIconButton and KIconDialog to KIconThemes

2013-06-22 Thread Miquel Canes Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/75/ --- Review request for KDE Frameworks. Description --- Move KIconButton a

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Thomas Lübking
> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Martin Gräßlin
> On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Thomas Lübking
> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-22 Thread Oswald Buddenhagen
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review34870 --- i didn't check whether every virtual override is correct, but g

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Martin Gräßlin
> On June 22, 2013, 12:58 p.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Thomas Lübking
> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Aleix Pol Gonzalez
> On June 22, 2013, 10:58 a.m., Thomas Lübking wrote: > > kdeui/util/kglobalsettings.cpp, line 308 > > > > > > These are the colors for the window titlbar (with ambiguous function > > names, though), the default

Re: Why is KConfig tier2?

2013-06-22 Thread Aleix Pol
On Sat, Jun 22, 2013 at 1:17 PM, David Faure wrote: > Le samedi 22 juin 2013 13:03:22 Aleix Pol a écrit : > > Hi, > > We've been looking through some code scratching our heads on how we can > do > > it to workaround uses of KConfig because of it being tier2. > > > > Then we decided to look at it

Re: Why is KConfig tier2?

2013-06-22 Thread David Faure
Le samedi 22 juin 2013 13:03:22 Aleix Pol a écrit : > Hi, > We've been looking through some code scratching our heads on how we can do > it to workaround uses of KConfig because of it being tier2. > > Then we decided to look at it and we saw that KConfigCore and KConfigGui > only seems to depend o

Why is KConfig tier2?

2013-06-22 Thread Aleix Pol
Hi, We've been looking through some code scratching our heads on how we can do it to workaround uses of KConfig because of it being tier2. Then we decided to look at it and we saw that KConfigCore and KConfigGui only seems to depend on Qt. So, maybe it could be moved to tier1? Aleix PS: we is Al

Re: Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Thomas Lübking
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/#review34861 --- kdeui/util/kglobalsettings.cpp

Review Request 111171: Deprecate (in)active(Title/Text)Color in favor of KColorScheme

2013-06-22 Thread Àlex Fiestas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/71/ --- Review request for KDE Frameworks and kdelibs. Description --- Deprec

Jenkins build became unstable: kdelibs_frameworks_qt5 #754

2013-06-22 Thread KDE CI System
See ___ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

Review Request 111170: Move KTip to KWidgets

2013-06-22 Thread Miquel Canes Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/70/ --- Review request for KDE Frameworks. Description --- Move KTip to KWidg

Re: Review Request 109667: Make some KConfig classes return a bool when saving

2013-06-22 Thread Albert Astals Cid
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/ --- (Updated June 22, 2013, 9:31 a.m.) Review request for KDE Frameworks and O