----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/109667/#review34870 -----------------------------------------------------------
i didn't check whether every virtual override is correct, but generally the patch looks correct. tier2/kconfig/autotests/kconfigguitest.cpp <http://git.reviewboard.kde.org/r/109667/#comment25551> you should wrap the line as you change the code. - Oswald Buddenhagen On June 22, 2013, 9:31 a.m., Albert Astals Cid wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/109667/ > ----------------------------------------------------------- > > (Updated June 22, 2013, 9:31 a.m.) > > > Review request for KDE Frameworks and Oswald Buddenhagen. > > > Description > ------- > > If it can fail, i want to know it so i can tell my users > > > Diffs > ----- > > KDE5PORTING.html ba67bdc > tier2/kconfig/autotests/kconfig_compiler/test_signal.cpp.ref fc04701 > tier2/kconfig/autotests/kconfig_compiler/test_signal.h.ref f43f7dd > tier2/kconfig/autotests/kconfigguitest.cpp e6b4c17 > tier2/kconfig/autotests/kconfigtest.h 17a5294 > tier2/kconfig/autotests/kconfigtest.cpp 00ffc2a > tier2/kconfig/autotests/ksharedconfigtest.cpp 2bb612f > tier2/kconfig/src/core/kconfig.h 597330f > tier2/kconfig/src/core/kconfig.cpp d26f941 > tier2/kconfig/src/core/kconfigbase.h ce190f3 > tier2/kconfig/src/core/kconfiggroup.h ff63afa > tier2/kconfig/src/core/kconfiggroup.cpp 53cac13 > tier2/kconfig/src/core/kcoreconfigskeleton.h 3e4971b > tier2/kconfig/src/core/kcoreconfigskeleton.cpp c0ad044 > tier2/kconfig/src/kconfig_compiler/kconfig_compiler.cpp 47963a5 > > Diff: http://git.reviewboard.kde.org/r/109667/diff/ > > > Testing > ------- > > New Unitttest passes > > > Thanks, > > Albert Astals Cid > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
