Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

> On Jan. 13, 2013, 6:45 p.m., Oswald Buddenhagen wrote: > > and why exactly do you sleep instead of looping with waitforreadyread? > > Jon Severinsson wrote: > Because that would be an (almost) busy-loop (there are already *some* > data, so waitForReadyRead could return before the timeout)

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

> On Jan. 13, 2013, 6:45 p.m., Oswald Buddenhagen wrote: > > and why exactly do you sleep instead of looping with waitforreadyread? Because that would be an (almost) busy-loop (there are already *some* data, so waitForReadyRead could return before the timeout). - Jon ---

Re: Review Request 108389: Respect the HOME environment variable

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- (Updated Jan. 13, 2013, 6:59 p.m.) Review request for KDE Frameworks. Ch

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/#review25394 --- and why exactly do you sleep instead of looping with waitforrea

Re: [kdelibs/KDE/4.10] kjs/tests: ECMA test: blacklist a new failing test

On Sunday 13 January 2013 16:46:22 Rolf Eike Beer wrote: > Git commit 84b2ace3a05090362b00d6464542552b94eb5b83 by Rolf Eike Beer. > Committed on 13/01/2013 at 16:43. > Pushed by dakon into branch 'KDE/4.10'. > > ECMA test: blacklist a new failing test > > CCMAIL:fa...@kde.org > > M +1-0

Re: Review Request 108389: Respect the HOME environment variable

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/#review25386 --- Hmm, can't this code be called for other users than the current

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/#review25385 --- Ship it! With Qt5 there's a much shorter way to write it: QTR

Test status on Qt5

Hi everyone When running qt5.git stable branch + manual merges from the release branches + Qt Change I5370bae2 [1] and the latest frameworks git + the fixes I've subbmitted to reviewboard [2], I'm now only seeing two intermittent errors in the test suite. The first is kptyprocesstest, which fa

Review Request 108389: Respect the HOME environment variable

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108389/ --- Review request for KDE Frameworks. Description --- This turns KUser::

Re: [kdelibs/frameworks] kdeui/tests: Remove QEXPECT_FAIL for MR 43915

On Sunday 13 January 2013 13:27:23 Jon Severinsson wrote: > Upstream seems to be ignoring "dev" and "stable" atm. The qt release > team have done some stable -> release merges in preparation for Qt > 5.0.1, but the automatic forward merges (release -> stable and stable > -> dev) prommised in the or

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/ --- (Updated Jan. 13, 2013, 1:03 p.m.) Review request for KDE Frameworks. Ch

Re: [kdelibs/frameworks] kdeui/tests: Remove QEXPECT_FAIL for MR 43915

On Sunday 13 January 2013 13:48:55 David Faure wrote: > > Upstream seems to be ignoring "dev" and "stable" atm. The qt release team > > have done some stable -> release merges in preparation for Qt 5.0.1, but > > the automatic forward merges (release -> stable and stable -> dev) > > prommised in th

Re: [kdelibs/frameworks] kdeui/tests: Remove QEXPECT_FAIL for MR 43915

On Sunday 13 January 2013 13:27:23 Jon Severinsson wrote: > söndagen den 13 januari 2013 13:12:09 skrev du: > > On Sunday 13 January 2013 13:01:32 Jon Severinsson wrote: > > > Git commit 02fe875f9f9eb09fcf7da2c2223f733b497ed2ba by Jon Severinsson. > > > Committed on 13/01/2013 at 11:22. > > > Pushe

Re: [kdelibs/frameworks] kdeui/tests: Remove QEXPECT_FAIL for MR 43915

söndagen den 13 januari 2013 13:12:09 skrev du: > On Sunday 13 January 2013 13:01:32 Jon Severinsson wrote: > > Git commit 02fe875f9f9eb09fcf7da2c2223f733b497ed2ba by Jon Severinsson. > > Committed on 13/01/2013 at 11:22. > > Pushed by jonseverinsson into branch 'frameworks'. > > > > Remove QEXPEC

Re: Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/#review25362 --- Too bad it slows down all test runs, though. Could we peek for

Re: Review Request 108380: Fix race condition in KTcpSocketTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/#review25360 --- kdecore/tests/ktcpsockettest.cpp

Review Request 108385: Reduce risk of timeout and race condition in KPtyProcessTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/ --- Review request for KDE Frameworks. Description --- Increase timeout,

Re: Review Request 108380: Fix race condition in KTcpSocketTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/ --- (Updated Jan. 13, 2013, 11:54 a.m.) Review request for KDE Frameworks and

Re: Review Request 108380: Fix race condition in KTcpSocketTest

> On Jan. 13, 2013, 10:58 a.m., David Faure wrote: > > kdecore/tests/ktcpsockettest.cpp, line 237 > > > > > > The relies on the current content of the page being fetched? :-) > > > > If hardcoding th

Re: Review Request 107688: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

> On Jan. 13, 2013, 11:03 a.m., David Faure wrote: > > kdecore/date/kcalendarsystem.h, line 631 > > > > > > If this method is always equal to QDate::dayOfWeek(), shouldn't it be > > deprecated? Or is the idea tha

Re: Review Request 107690: [PATCH 3/4] kcalendarsystem: Simplify week() and weeksInYear() implementations

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107690/#review25349 --- Ship it! Looks OK to me. - David Faure On Jan. 8, 2013, 3:4

Re: Review Request 107688: [PATCH 2/4] kcalendarsystem: Simplify the dayOfWeek() implementation.

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107688/#review25348 --- kdecore/date/kcalendarsystem.h

Re: Review Request 107687: [PATCH 1/4] kcalendarsystem: Fix lengthOfWeek to 7

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107687/#review25347 --- Ship it! Seems fine, please commit. As you write in a comment

Re: Review Request 108380: Fix race condition in KTcpSocketTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/#review25346 --- Woohoo, it's Christmas again :) This flaky test was bothering m

Review Request 108380: Fix race condition in KTcpSocketTest

--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108380/ --- Review request for KDE Frameworks and kdelibs. Description --- In som