----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/ -----------------------------------------------------------
(Updated Jan. 13, 2013, 1:03 p.m.) Review request for KDE Frameworks. Changes ------- Thanks, I had missed that method. Did a more thorough check (sleep in a limited for-loop after a conditional break), giving a slightly smaller performance penalty than last patch (though not much, the checking takes some time too), and a further failure rate reduction to 2% (4 out of 200 test runs). Description (updated) ------- Increase timeout, and sleep a while after waitForReadyRead() returns, as it only guarantees that *some* data is available to read, while the test assumes that a full line of data is available to read... This reduces failure rate from 10% to 2% on my setup. Diffs (updated) ----- kpty/tests/kptyprocesstest.cpp b95ae26 Diff: http://git.reviewboard.kde.org/r/108385/diff/ Testing ------- Thanks, Jon Severinsson
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
