----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108385/#review25362 -----------------------------------------------------------
Too bad it slows down all test runs, though. Could we peek for a '\n' maybe, to check if we have all the data and skip the waiting in that case? Oh, actually there's API for that: bool QProcess::canReadLine(). - David Faure On Jan. 13, 2013, 11:57 a.m., Jon Severinsson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108385/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2013, 11:57 a.m.) > > > Review request for KDE Frameworks. > > > Description > ------- > > Increase timeout, and sleep a while after waitForReadyRead() returns, > as it only guarantees that *some* data is available to read, while > the test assumes that *all* data is available to read... > > This reduces failure rate from 10% to 3.5% on my setup. > > > Diffs > ----- > > kpty/tests/kptyprocesstest.cpp b95ae26 > > Diff: http://git.reviewboard.kde.org/r/108385/diff/ > > > Testing > ------- > > > Thanks, > > Jon Severinsson > >
_______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
