Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- (Updated May 8, 2015, 5:20 a.m.) Status -- This change has been mark

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80057 --- Ship it! Ship It! - Milian Wolff On May 7, 2015, 11:43 a.m

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- (Updated May 7, 2015, 11:43 a.m.) Review request for Baloo and Vishesh Ha

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80027 --- src/engine/postingdb.cpp (line 285)

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80026 --- src/engine/postingdb.cpp (line 296)

Re: Review Request 123662: Remove code duplication in postingDB

> On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 380 > > > > > > auto, tyke comVal and com by value > > Pinak Ahuja wrote: > Same as above. > > Pinak Ahuja wrote: > ok

Re: Review Request 123662: Remove code duplication in postingDB

> On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 380 > > > > > > auto, tyke comVal and com by value > > Pinak Ahuja wrote: > Same as above. ok got passing integers by valu

Re: Review Request 123662: Remove code duplication in postingDB

> On May 7, 2015, 7:06 a.m., Milian Wolff wrote: > > src/engine/postingdb.cpp, line 324 > > > > > > use auto instead of Validator, otherwise you'll pay for the type erasure oh, now I get it, std::function uses t

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80012 --- yep, better and pretty close but not yet there :) thanks! s

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 7:59 p.m., Milian Wolff wrote: > > src/engine/postingdb.h, line 55 > > > > > > could this be made private? and then a template function and take the > > Validator as a template arg? this would s

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- (Updated May 7, 2015, 4:53 a.m.) Review request for Baloo and Vishesh Han

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.h, line 55 > > > > > > Could you please rename this to 'iter' instead of 'getIter' and make it > > private? > > > > We like to a

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review79986 --- src/engine/postingdb.h (line 55)

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.h, line 55 > > > > > > Could you please rename this to 'iter' instead of 'getIter' and make it > > private? > > > > We like to a

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.cpp, line 381 > > > > > > Maybe in a seperarate patch we want to use QByteArray::fromRawData or > > something and avoid the copy. Though

Re: Review Request 123662: Remove code duplication in postingDB

> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.h, line 55 > > > > > > Could you please rename this to 'iter' instead of 'getIter' and make it > > private? > > > > We like to a

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review79979 --- Ship it! Good job. If the tests are also passing, then ship i

Re: Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- (Updated May 6, 2015, 6:28 p.m.) Review request for Baloo and Vishesh Han

Review Request 123662: Remove code duplication in postingDB

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/ --- Review request for Baloo and Vishesh Handa. Repository: baloo Descripti