----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review80012 -----------------------------------------------------------
yep, better and pretty close but not yet there :) thanks! src/engine/postingdb.h (line 29) <https://git.reviewboard.kde.org/r/123662/#comment54897> can be removed now src/engine/postingdb.h (line 67) <https://git.reviewboard.kde.org/r/123662/#comment54893> this can be removed now src/engine/postingdb.h (line 69) <https://git.reviewboard.kde.org/r/123662/#comment54898> I'd rename "t" to "Validator" src/engine/postingdb.h (line 70) <https://git.reviewboard.kde.org/r/123662/#comment54899> take Validator validate by value src/engine/postingdb.cpp (line 274) <https://git.reviewboard.kde.org/r/123662/#comment54894> use auto instead of Validator, otherwise you'll pay for the type erasure src/engine/postingdb.cpp (line 284) <https://git.reviewboard.kde.org/r/123662/#comment54895> again, auto. also: take the prefixLen by value src/engine/postingdb.cpp (line 296) <https://git.reviewboard.kde.org/r/123662/#comment54896> auto, tyke comVal and com by value - Milian Wolff On May 7, 2015, 4:53 a.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123662/ > ----------------------------------------------------------- > > (Updated May 7, 2015, 4:53 a.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This removes code dupication within different kinds of iterators namely: > prefix,regex, comparator iterators. > > > Diffs > ----- > > src/engine/postingdb.h fd48602 > src/engine/postingdb.cpp 8c76a72 > > Diff: https://git.reviewboard.kde.org/r/123662/diff/ > > > Testing > ------- > > Compiles and tests pass. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
