> On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.h, line 55 > > <https://git.reviewboard.kde.org/r/123662/diff/2/?file=366917#file366917line55> > > > > Could you please rename this to 'iter' instead of 'getIter' and make it > > private? > > > > We like to avoid 'get' in the name of getters.
we already have a method named iter, hence I chose getIter > On May 6, 2015, 6:52 p.m., Vishesh Handa wrote: > > src/engine/postingdb.cpp, line 380 > > <https://git.reviewboard.kde.org/r/123662/diff/2/?file=366918#file366918line380> > > > > Please move this assert outside the lambda. oh yeah, that would be better. - Pinak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123662/#review79979 ----------------------------------------------------------- On May 6, 2015, 6:28 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/123662/ > ----------------------------------------------------------- > > (Updated May 6, 2015, 6:28 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > This removes code dupication within different kinds of iterators namely: > prefix,regex, comparator iterators. > > > Diffs > ----- > > src/engine/postingdb.h fd48602 > src/engine/postingdb.cpp 8c76a72 > > Diff: https://git.reviewboard.kde.org/r/123662/diff/ > > > Testing > ------- > > Compiles and tests pass. > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
