Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57330 --- This review has been submitted with commit ce183ae409aa9104ca

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/ --- (Updated May 5, 2014, 4:35 p.m.) Status -- This change has been mark

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57329 --- Ship it! from my pov, +1 I hope noone will miss the word-cou

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/ --- (Updated May 5, 2014, 4:14 p.m.) Review request for Baloo and Milian Wolf

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

> On May 5, 2014, 2:05 p.m., Milian Wolff wrote: > > What is the speed difference compared to the old QString API, but without > > the word-count there? Afaik, the word-count is the major bottleneck and > > removing it alone should greatly speed up the test. > > > > Having a QByteArray in the

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

> On May 5, 2014, 2:05 p.m., Milian Wolff wrote: > > What is the speed difference compared to the old QString API, but without > > the word-count there? Afaik, the word-count is the major bottleneck and > > removing it alone should greatly speed up the test. > > > > Having a QByteArray in the

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

> On May 5, 2014, 2:05 p.m., Milian Wolff wrote: > > What is the speed difference compared to the old QString API, but without > > the word-count there? Afaik, the word-count is the major bottleneck and > > removing it alone should greatly speed up the test. > > > > Having a QByteArray in the

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57322 --- src/extractionresult.cpp

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

> On May 5, 2014, 2:05 p.m., Milian Wolff wrote: > > What is the speed difference compared to the old QString API, but without > > the word-count there? Afaik, the word-count is the major bottleneck and > > removing it alone should greatly speed up the test. > > > > Having a QByteArray in the

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

> On May 5, 2014, 2:08 p.m., Milian Wolff wrote: > > src/extractionresult.cpp, line 59 > > > > > > this is pure virtual in the header, no? Yeah. I had originally kept it as virtual instead of pure virtual, but cl

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57315 --- src/extractionresult.cpp

Re: Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/#review57314 --- What is the speed difference compared to the old QString API,

Review Request 117996: Add an append(QByteArray) method to the ExtractionResult

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117996/ --- Review request for Baloo and Milian Wolff. Repository: kfilemetadata De