-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117996/
-----------------------------------------------------------
(Updated May 5, 2014, 4:14 p.m.)
Review request for Baloo and Milian Wolff.
Changes
-------
PlainTextExtractor: Use fstream instead of QFile
Also discard the word count. This optimizes the plain text extractor
benchmark from 60 msecs to about 9 msecs.
Repository: kfilemetadata
Description
-------
Add an append(QByteArray) method to the ExtractionResult
This way plugins can choose to return the data in utf8 or as a QString,
and the clients can either just let the standard QString::fromUtf8
function do its magic, or implement some special handling if they wish.
This speeds up the PlainTextExtractor quite a bit (60msec vs 8.3msec)
Unfortunately, this meant discarding the extraction of WordCount from
the Plain Text extractor. Though considering the speed difference, I
think it is worth it.
Diffs (updated)
-----
autotests/indexerextractortests.cpp 6b7c605
src/extractors/plaintextextractor.cpp 5a38857
Diff: https://git.reviewboard.kde.org/r/117996/diff/
Testing
-------
Thanks,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
