.
An analogy could be that we get commit emails, but we get to choose
which projects we are interested in. We don't make everyone subscribe
to kde-commits, and then put their own complex filters on top.
--
Vishesh Handa
eview requests.
It was just too much noise for me, and I found the noise/signal ratio
way lower in kde-devel. Baloo-devel was specifically not chosen as it
would just an another silo in kde. Nepomuk used to suffer from that.
--
Vishesh Handa
On Fri, Oct 7, 2016 at 5:57 PM, Kevin Funk wrote:
> On Friday, 7 October 2016 17:24:26 CEST Vishesh Handa wrote:
>> Hey guys
>>
>> I was told there is a thread about scrapping Baloo. All Baloo
>> discussion used to happen on kde-devel and that's where the revi
ly taken.
How about requirements such as resource consumption, ease of
integration, search speed are taken into consideration? Come on guys.
We're engineers over here.
(If the discussion continues on kde-frameworks-devel, I probably won't see it)
--
Vishesh Handa
On Oct 7, 2016 12:07, "Martin Bednar" wrote:
>
> Hi,
>
> thanks for answering.
>
> On Friday, 7 October 2016 10:44:02 CEST Vishesh Handa wrote:
> > Hey Martin
> >
> > Baloo is only designed for searching for files. It is not a meta-data
> > st
additional context. Therefore, adding actor information, is not
something I would want to ship.
--
Vishesh Handa
On Fri, Sep 30, 2016 at 9:47 PM, Martin Bednar wrote:
> Hi,
>
> having very fond memories of the potential I saw in the tvshows://
> experimental kioslave (from the days of n
On Mon, Sep 19, 2016 at 1:11 PM, Boudhayan Gupta wrote:
> Hi,
>
> On 19 Sep 2016 4:34 p.m., "Vishesh Handa" wrote:
>> >> If someone else wants to maintain it, I can help with the transition.
>
> I have a ton of questions; I'll send you a list sometime
On Mon, Sep 19, 2016 at 11:43 AM, Bhushan Shah wrote:
> Hey Vishesh,
>
> On Mon, Sep 19, 2016 at 3:06 PM, Vishesh Handa wrote:
>> I've been steadily loosing motivation to work on Baloo.
>>
>> I've removed myself from all the bugs, as it doesn't seem like
If someone else wants to maintain it, I can help with the transition.
--
Vishesh Handa
> On Aug. 19, 2016, 8:52 a.m., Vishesh Handa wrote:
> > Could you please attach some screenshots of the before and after?
>
> James Smith wrote:
> I don't think it's really necessary, the existing indexed tag was erased
> if a tag higher up was selected, or
t;
So if we only have tag in the form -
"Fire/Water"
at that point unless one also has the tag "Fire", it will just never show
up.
- Vishesh Handa
On Aug. 20, 2016, 10:58 p.m., James Smith wrote:
>
>
hard to reason what
is going on.
Eg - `baloosearch 'tag:Death Fire'` and `baloosearch tag:Death Fire` now yield
different results since "Fire" is considered part of the tag in the first query.
I would rather not ship this.
- Vishesh Handa
On Aug. 24, 2016, 3:26 p.m
time post Wednesday to
actually try all your patches out.
- Vishesh Handa
On Aug. 24, 2016, 3:26 p.m., James Smith wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
after?
- Vishesh Handa
On Aug. 19, 2016, 12:05 a.m., James Smith wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
don't understand it.
From a cursory glance it seems that this code will assert. `q` is of type
`EngineQuery::Phrase` and is a leaf query so `Transaction::PostingIterator`
will assert it `Q_ASSERT(0)`
- Vishesh Handa
On Aug. 18, 2016, 11:56 p.m., James Smith wrote:
>
>
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128554/#review97999
---
Ship it!
Ship It!
- Vishesh Handa
On July 29, 2016, 5
e completion of each run. As such a broken blog can
> cause some problems.
What kind of problems?
I'm guessing it would just be ignored and eventually over time we can
remove ones which have been broken for a very long time.
--
Vishesh Handa
still keep getting corrupted data.
If possible, it would be nice if you could save cola's baloo db and try to
diagnose exactly what got corrupted. Or if it is small enough we can save it
(after removing personal data) and use it as a test case.
- Vishesh Handa
On June 14, 2016, 8:32 p.m., P
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127728/#review95908
---
Ship it!
Ship It!
- Vishesh Handa
On April 23, 2016, 4
#x27;t. Please point me to where it does.
> The projects included above
> can expect to hear from Sysadmin and will be requested to provide an
> explanation of their activities there to both us and
> kde-commun...@kde.org.
>
Please provide more info about why this would be required.
--
Vishesh Handa
Hey Matthieu
There is a dbus signal you can monitor, but no proper API. Have a look
at 'baloo/src/kioslaves/kded/baloosearchmodule.cpp'.
On Thu, Mar 17, 2016 at 5:46 PM, Matthieu Gallien
wrote:
> Hello Vishesh and kde-devel,
>
> I am working on a music player fetching its track through Baloo (i
;=' are treated the same way.
- Vishesh Handa
On Ene. 5, 2016, 7:26 p.m., Jesse Pullinen wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126227/#review89508
---
Ship it!
- Vishesh Handa
On Dec. 6, 2015, 6:03 p.m
> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote:
> > runners/baloo/baloosearchrunner.cpp, line 165
> > <https://git.reviewboard.kde.org/r/125369/diff/1/?file=405159#file405159line165>
> >
> > Have a look at basicindexingjob.txt. We define that all Prese
stuck, and
all other plugins will suffer. Perhaps the list of mimetypes supported could be
in a desktop file?
- Vishesh Handa
On Oct. 24, 2015, 12:19 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automatically generated e-mail.
> On Sept. 24, 2015, 11:50 p.m., Vishesh Handa wrote:
> > runners/baloo/baloosearchrunner.cpp, line 165
> > <https://git.reviewboard.kde.org/r/125369/diff/1/?file=405159#file405159line165>
> >
> > Have a look at basicindexingjob.txt. We define that all Prese
> On Nov. 24, 2015, 11:05 a.m., Vishesh Handa wrote:
> > Ping?
I'm closing this review request for now. The changes in the diff are handled by
release scripts. Please reopen this if you feel otherwise.
- Vishesh
lease sort these values as well? This is possible why we are
getting duplicates. The WriteTransaction assumes the data is sorted when it
gets it.
src/engine/mtimedb.cpp (line 142)
<https://git.reviewboard.kde.org/r/126227/#comment61014>
This can be removed once `get` is sorted.
- Vis
ith this knowledge would be required.
>
> I think we should plan it very carefully, to have a battle plan, and then
> go.
>
> What do you think?
> Would people be interested to give a hand?
> How and when do we begin?
I would definitely be interested.
However, I doubt I have the t
tps://git.reviewboard.kde.org/r/126223/#comment61008>
I'm guessing I was trying to implement the case when you only specify the
year + day and not the month, though that doesn't seem to make much sense to me.
- Vishesh Handa
On Dec. 2, 2015, 6:42 p.m., Xu
tps://git.reviewboard.kde.org/r/126227/#comment61007>
Do you think you could sort the values in the mtime posting iterator before
sending it forward, instead of sorting it over here?
The VectorPostingIteartor just doesn't seem like the correct place.
- Vishesh Handa
On Dec. 3,
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126006/#review88753
---
Ping?
- Vishesh Handa
On Nov. 9, 2015, 3:51 p.m., Jan
tps://git.reviewboard.kde.org/r/126132/#comment60856>
Perhaps use QStringLiteral instead?
- Vishesh Handa
On Nov. 22, 2015, 2:26 a.m., Xuetian Weng wrote:
>
> ---
> This is an automatically generated e-mail. To reply,
tps://git.reviewboard.kde.org/r/126110/#comment60854>
Please remove the comment. It's not longer valid.
src/engine/database.cpp (line 192)
<https://git.reviewboard.kde.org/r/126110/#comment60855>
Perhaps you want to close the env here as well? The assert can fail in
production.
marked as submitted.
Review request for Baloo.
Changes
---
Submitted with commit 3d9c33ced6368dc9278ecfe00c92645282d2d5d6 by Vishesh Handa
to branch master.
Repository: baloo
Description
---
We do not need the extra overhead. Specially since LMDB internally uses
a COW mechanism
t the main use case
that I focussed on was searching. Over there the db is only opened once per
application.
- Vishesh Handa
On Nov. 18, 2015, 7:40 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automatically generated e-ma
/fsutils.cpp PRE-CREATION
Diff: https://git.reviewboard.kde.org/r/125868/diff/
Testing
---
Thanks,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125777/#review87608
---
Ship it!
Ship It!
- Vishesh Handa
On Oct. 28, 2015, 10:25
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125818/#review87546
---
Ship it!
Ship It!
- Vishesh Handa
On Oct. 27, 2015, 6:53
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125776/#review87541
---
Ship it!
:)
- Vishesh Handa
On Oct. 27, 2015, 6:35 p.m
g/r/125776/#comment60096>
I'm a little confused. Isn't the metadatamover using this method?
$ ack renameFilePath
src/file/metadatamover.cpp
116:tr->renameFilePath(id, job.document());
- Vishesh Handa
On Oct. 26, 2015, 8:16 a.m.
this go ahead.
- Vishesh Handa
On Oct. 26, 2015, 8:36 p.m., Heiko Becker wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
tps://git.reviewboard.kde.org/r/125776/#comment59983>
This is a silly thing, but do you think perhaps we should move this
'renameFilePath' call inside `replaceDocument`, and just add an extra operation?
- Vishesh Handa
On Oct. 24, 2015, 6:17 p.m., P
age in this case.
- Vishesh Handa
On Oct. 24, 2015, 12:19 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.
filePath changing.
- Vishesh Handa
On Oct. 21, 2015, 6:28 a.m., Pinak Ahuja wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125729/#review87165
---
Ship it!
- Vishesh Handa
On Oct. 20, 2015, 6:28 p.m
marked as submitted.
Review request for Baloo and Igor Poboiko.
Changes
---
Submitted with commit c67546c4fc8c77d502895cdd240126542e105946 by Vishesh Handa
to branch master.
Repository: baloo
Description
---
All 3 codecs seem to always copy the data on decoding. We can avoid the
from that it seems good.
Nicely done.
Do you have git access or should I commit it for you?
- Vishesh Handa
On Oct. 16, 2015, 8:13 a.m., Varun Joshi wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit
://git.reviewboard.kde.org/r/125643/diff/
Testing
---
Thanks,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Diff: https://git.reviewboard.kde.org/r/125585/diff/
Testing
---
Thanks,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
---
Breeze ships a far better icon, and this icon was supposed to be
temporary. (Committed on 2014-02-13)
Diffs
-
CMakeLists.txt 90277fd
icons/128-apps-baloo.png 2ca1fa8
icons/CMakeLists.txt 59e4260
Diff: https://git.reviewboard.kde.org/r/125585/diff/
Testing
---
Thanks,
Vishesh
Hey Pinak
Could you please take a quick look at these patches.
I should use reviewboard but it's a pain to upload all these patches.
Specially since most of these are so trivial.
--
Vishesh Handa
From 8637cf5d3555039970e473fe1aa259e0fcc69e70 Mon Sep 17 00:00:00 2001
From: Vishesh Handa
-
>
> (Updated Oct. 9, 2015, 6:57 p.m.)
>
>
> Review request for Baloo, Release Team and Vishesh Handa.
>
>
> Repository: baloo
>
>
> Description
> ---
>
> The bug is obvious, old code uses limit instead of (limit >
.
- Vishesh Handa
On Oct. 9, 2015, 5:54 p.m., Xuetian Weng wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
The entire code in this else case is absolutely rubbish. The person
implementing it should feel bad (me).
We seem to be completly ignoring the offset over here.
- Vishesh Handa
On Oct. 7, 2015, 10:27 a.m., Xuetian Weng wrote:
>
> ---
uessing they are trying to use an equivalent system
on linux and have settled on Tracker? The link you mentioned seems to
indicate that they are using Tracker on OSX. Maybe I'm just confused.
--
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
time
we have to hack on Baloo.
Also, should we put this list on todo.kde.org or start using Phabricator?
--
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125496/#review86265
---
Ship it!
- Vishesh Handa
On Oct. 2, 2015, 9:29 p.m., Luigi
, but it will be much easier
to understand.
- Vishesh Handa
On Oct. 2, 2015, 2 p.m., Pinak Ahuja wrote:
>
> ---
> This is an automatically generated e-mail. To repl
kes more sense to
optimize for the common ones.
- Vishesh Handa
On Oct. 2, 2015, 2:57 p.m., Pinak Ahuja wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git
> On Oct. 2, 2015, 1:28 p.m., Vishesh Handa wrote:
> > src/file/unindexedfileindexer.cpp, line 59
> > <https://git.reviewboard.kde.org/r/125481/diff/1/?file=409378#file409378line59>
> >
> > Are you sure this is the right thing to be doing? I'm imagini
tps://git.reviewboard.kde.org/r/125481/#comment59433>
Are you sure this is the right thing to be doing? I'm imagining the case
when the filename has changed when `baloo_file` was not running.
- Vishesh Handa
On Oct. 2, 2015, 10:44 a.m., Pinak
'contentIndexing' or
'indexFileContents'. Basic Indexing is not quite descriptive.
- Vishesh Handa
On Oct. 2, 2015, 11:28 a.m., Pinak Ahuja wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> h
https://git.reviewboard.kde.org/r/125429/#review86113
-------
On Sept. 30, 2015, 4:41 p.m., Vishesh Handa wrote:
>
> ---
> This is an automatically generated e-ma
discarded.
Review request for Baloo.
Repository: baloo
Description
---
See diff
Diffs
-
src/file/filecontentindexer.h 6ecd41c
src/file/filecontentindexer.cpp 4323c3f
Diff: https://git.reviewboard.kde.org/r/125430/diff/
Testing
---
Thanks,
Vishesh Handa
>>
marked as submitted.
Review request for Baloo and Pinak Ahuja.
Changes
---
Submitted with commit 3905929f5f8be6dbe23c1e02ebd093e1608245a3 by Vishesh Handa
to branch master.
Repository: baloo
Description
---
Fix dbus warnings
We cannot emit dbus signals from a different thread
marked as submitted.
Review request for Baloo, Pinak Ahuja and Igor Poboiko.
Changes
---
Submitted with commit 9da558f643eaac1e6c37aba5a2ff1dfe2c84bf98 by Vishesh Handa
to branch master.
Repository: baloo
Description
---
Balooctl: Add checkDb command
This command can be used
-
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125430/#review86118
-------
On Sept. 27, 2015, 9:48 p.m., Vishesh Handa wrote:
>
>
not fix all our issues. We still have problems.
Diffs
-
src/engine/writetransaction.cpp 1391ba9
Diff: https://git.reviewboard.kde.org/r/125431/diff/
Testing
---
Thanks,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
r job at fixing all the
issues.
- Vishesh Handa
On Sept. 27, 2015, 9:50 p.m., Vishesh Handa wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard
have any small string optimizations.
Ship it!
- Vishesh Handa
On Sept. 23, 2015, 2:42 p.m., Igor Poboiko wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
to diagnose the bug revealed by review 125362. Still not entirely
sure.
Diffs (updated)
-
src/engine/transaction.h 845d9f0
src/engine/transaction.cpp 8e9700c
src/tools/balooctl/main.cpp 0e74761
Diff: https://git.reviewboard.kde.org/r/125424/diff/
Testing
---
Thanks,
/writetransaction.cpp 1391ba9
Diff: https://git.reviewboard.kde.org/r/125431/diff/
Testing
---
Thanks,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
.
Repository: baloo
Description
---
See diff
Diffs (updated)
-
src/file/filecontentindexer.h 6ecd41c
src/file/filecontentindexer.cpp 4323c3f
Diff: https://git.reviewboard.kde.org/r/125430/diff/
Testing
---
Thanks,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listin
diff
Diffs
-
src/file/filecontentindexer.cpp 4323c3f
Diff: https://git.reviewboard.kde.org/r/125430/diff/
Testing
---
Thanks,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
Description
---
Fix dbus warnings
We cannot emit dbus signals from a different thread than the thread the
object has an affinity to.
Diffs
-
src/file/filecontentindexer.cpp 4323c3f
Diff: https://git.reviewboard.kde.org/r/125429/diff/
Testing
---
Thanks,
Vishesh Handa
,
Vishesh Handa
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
> On Sept. 26, 2015, 10:52 a.m., Vishesh Handa wrote:
> > I cannot really comment on the windows parts. But the ideas seems good.
> > Ship it?
>
> Patrick Spendrin wrote:
> Since I moved code around for *nix as well, could you check that it
> compiles at lea
/configcommand.cpp (line 201)
<https://git.reviewboard.kde.org/r/125414/#comment59348>
QStringLiteral
src/tools/balooctl/configcommand.cpp (line 326)
<https://git.reviewboard.kde.org/r/125414/#comment59349>
Maybe add a `return 1` after this?
- Vishesh Handa
On Sept. 26, 2015, 7:34 p.m.,
seems good. Ship it?
- Vishesh Handa
On Sept. 25, 2015, 10:43 p.m., Patrick Spendrin wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
eld "Source Code" or
something. I'm not sure, but just combining the two doesn't seem correct.
Maybe others can chime in?
- Vishesh Handa
On Sept. 24, 2015, 7:18 a.m., Igor Poboiko wrote:
>
> ---
> This
marked as submitted.
Review request for Baloo, Pinak Ahuja and Igor Poboiko.
Changes
---
Submitted with commit 810820f8ac6a7a025b083f3e88d96851938958d5 by Vishesh Handa
to branch master.
Repository: baloo
Description
---
When composing different PostingIterators in an AND / OR
> On Sept. 23, 2015, 2:59 p.m., Vishesh Handa wrote:
> > Hmm. This is actually an optimization I care about.
> > Do you think you could share your `~/.local/share/baloo/index` file. That
> > way I will be able to reproduce it and see exactly where/why the data is
>
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125374/#review85903
---
Ship it!
- Vishesh Handa
On Sept. 24, 2015, 2:32 p.m
tps://git.reviewboard.kde.org/r/125359/#comment59295>
Please handle the return value. We seem to be having a lot of problems with
this.
- Vishesh Handa
On Sept. 24, 2015, 4:52 p.m., Pinak Ahuja wrote:
>
> ---
> This is a
> On Sept. 22, 2015, 5:26 p.m., Vishesh Handa wrote:
> > Oh wow. This is bad. Thanks for diagnosing it.
> >
> > I'm wondering if this is the best way of solving it. The assumption always
> > is that if a DB does not have any values then it can just return 0. I
/orpostingiterator.cpp 9d16349
src/engine/phraseanditerator.h 1f5573e
src/engine/phraseanditerator.cpp d00cdcf
src/engine/transaction.cpp ad43d69
src/lib/searchstore.cpp 806ea5f
Diff: https://git.reviewboard.kde.org/r/125365/diff/
Testing
---
Thanks,
Vishesh Handa
>> Visi
> On Sept. 23, 2015, 2:59 p.m., Vishesh Handa wrote:
> > Hmm. This is actually an optimization I care about.
> > Do you think you could share your `~/.local/share/baloo/index` file. That
> > way I will be able to reproduce it and see exactly where/why the data is
>
think you could share your `~/.local/share/baloo/index` file. That way I
will be able to reproduce it and see exactly where/why the data is changing?
Btw, awesome work at diagnosing this! :)
- Vishesh Handa
On Sept. 23, 2015, 2:42 p.m., Igor Poboiko wrote
tps://git.reviewboard.kde.org/r/125361/#comment59275>
Extra whitespace at the end of the line
src/tools/balooctl/main.cpp (line 116)
<https://git.reviewboard.kde.org/r/125361/#comment59274>
Please fix the coding style.
`if (condition)` not `if(condition)`
- Vishesh Han
in another
patch?
- Vishesh Handa
On Sept. 23, 2015, 1:11 p.m., Pinak Ahuja wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://gi
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125358/#review85823
---
Ship it!
- Vishesh Handa
On Sept. 23, 2015, 1:11 p.m
tps://git.reviewboard.kde.org/r/125361/#comment59269>
Please use the `IndexerConfig` class instead of KConfig.
- Vishesh Handa
On Sept. 23, 2015, 1:31 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automatically generated e-mail.
issue. Nicely
done!
- Vishesh Handa
On Sept. 22, 2015, 6:58 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.
not too aware of the whole
i18n thing, so maybe it can be.
Could you please check?
- Vishesh Handa
On Sept. 23, 2015, 12:38 p.m., Boudhayan Gupta wrote:
>
> ---
> This is an automatically generated e-
used to exist because there was
no explicit "Disable Baloo button". Now that there is the button, do we want to
magically disable Baloo if nothing is going to be indexed? I think so, though
I'm not sure.
Anyway, ship it. Nice work, and sorry for the delay.
- Vishesh Handa
On Sept.
> On Sept. 22, 2015, 5:26 p.m., Vishesh Handa wrote:
> > Oh wow. This is bad. Thanks for diagnosing it.
> >
> > I'm wondering if this is the best way of solving it. The assumption always
> > is that if a DB does not have any values then it can just return 0. I
> On Sept. 22, 2015, 8:32 p.m., Albert Astals Cid wrote:
> > Can this checked by an autotest?
Definitely. Thanks for the reminder :)
- Vishesh
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.o
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125355/#review85810
---
Ship it!
Nice work!
- Vishesh Handa
On Sept. 23, 2015, 9
> On Sept. 22, 2015, 5:26 p.m., Vishesh Handa wrote:
> > Oh wow. This is bad. Thanks for diagnosing it.
> >
> > I'm wondering if this is the best way of solving it. The assumption always
> > is that if a DB does not have any values then it can just return 0. I
1 - 100 of 468 matches
Mail list logo
