----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125414/#review85992 -----------------------------------------------------------
Ship it! Awesome work. src/tools/balooctl/configcommand.cpp (line 201) <https://git.reviewboard.kde.org/r/125414/#comment59348> QStringLiteral src/tools/balooctl/configcommand.cpp (line 326) <https://git.reviewboard.kde.org/r/125414/#comment59349> Maybe add a `return 1` after this? - Vishesh Handa On Sept. 26, 2015, 7:34 p.m., Pinak Ahuja wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/125414/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2015, 7:34 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > Syntax: balooctl config [ls|rm|add] excludeFilters <filter> > > > Diffs > ----- > > src/lib/indexerconfig.h b3d265c > src/lib/indexerconfig.cpp 143b6c0 > src/tools/balooctl/configcommand.cpp 66eb798 > > Diff: https://git.reviewboard.kde.org/r/125414/diff/ > > > Testing > ------- > > > Thanks, > > Pinak Ahuja > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
