----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126223/#review89142 -----------------------------------------------------------
Ship it! src/lib/searchstore.cpp (line 221) <https://git.reviewboard.kde.org/r/126223/#comment61008> I'm guessing I was trying to implement the case when you only specify the year + day and not the month, though that doesn't seem to make much sense to me. - Vishesh Handa On Dec. 2, 2015, 6:42 p.m., Xuetian Weng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/126223/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2015, 6:42 p.m.) > > > Review request for Baloo and Vishesh Handa. > > > Repository: baloo > > > Description > ------- > > timeline:/ doesn't return correct result for month 1 or day 1, this is > because date filter always takes 1 as whole month or whole year. 0 should be > used in such case. > > > Diffs > ----- > > src/lib/searchstore.cpp 11fbd3f > > Diff: https://git.reviewboard.kde.org/r/126223/diff/ > > > Testing > ------- > > timeline://2015-12/2015-12-01 now returns correct result. > > > Thanks, > > Xuetian Weng > >
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
