[GitHub] [maven-assembly-plugin] michael-o commented on pull request #102: [MASSEMBLY-973] Support zstd format

2023-03-10 Thread via GitHub
michael-o commented on PR #102: URL: https://github.com/apache/maven-assembly-plugin/pull/102#issuecomment-1464067768 Let me run the tests again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [maven-help-plugin] slawekjaranowski commented on a diff in pull request #89: [MPH-197] Upgrade plexus-utils to 3.5.1

2023-03-10 Thread via GitHub
slawekjaranowski commented on code in PR #89: URL: https://github.com/apache/maven-help-plugin/pull/89#discussion_r1132613802 ## src/main/java/org/apache/maven/plugins/help/SystemMojo.java: ## @@ -67,14 +67,10 @@ public void execute() throws MojoExecutionException { mes

[GitHub] [maven-help-plugin] slachiewicz commented on a diff in pull request #89: [MPH-197] Upgrade plexus-utils to 3.5.1

2023-03-10 Thread via GitHub
slachiewicz commented on code in PR #89: URL: https://github.com/apache/maven-help-plugin/pull/89#discussion_r1132618413 ## src/main/java/org/apache/maven/plugins/help/SystemMojo.java: ## @@ -67,14 +67,10 @@ public void execute() throws MojoExecutionException { message.

[GitHub] [maven-mvnd] gnodet commented on issue #793: java.lang.UnsatisfiedLinkError: Can't load library: jansi.dll

2023-03-10 Thread via GitHub
gnodet commented on issue #793: URL: https://github.com/apache/maven-mvnd/issues/793#issuecomment-1464088629 I've merged some enhancements which will enable more logging. Could someone download a build from https://github.com/apache/maven-mvnd/actions/runs/4386402864 and run the followi

[GitHub] [maven-help-plugin] slawekjaranowski commented on a diff in pull request #89: [MPH-197] Upgrade plexus-utils to 3.5.1

2023-03-10 Thread via GitHub
slawekjaranowski commented on code in PR #89: URL: https://github.com/apache/maven-help-plugin/pull/89#discussion_r1132628389 ## src/main/java/org/apache/maven/plugins/help/SystemMojo.java: ## @@ -67,14 +67,10 @@ public void execute() throws MojoExecutionException { mes

[GitHub] [maven-help-plugin] slawekjaranowski commented on a diff in pull request #89: [MPH-197] Upgrade plexus-utils to 3.5.1

2023-03-10 Thread via GitHub
slawekjaranowski commented on code in PR #89: URL: https://github.com/apache/maven-help-plugin/pull/89#discussion_r1132629379 ## src/main/java/org/apache/maven/plugins/help/SystemMojo.java: ## @@ -67,14 +67,10 @@ public void execute() throws MojoExecutionException { mes

[GitHub] [maven-shared-io] elharo merged pull request #19: [MSHARED-893] prefer Apache Commons IO FileUtils to maven-shared-utils

2023-03-10 Thread via GitHub
elharo merged PR #19: URL: https://github.com/apache/maven-shared-io/pull/19 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[GitHub] [maven-mvnd] psiroky commented on issue #793: java.lang.UnsatisfiedLinkError: Can't load library: jansi.dll

2023-03-10 Thread via GitHub
psiroky commented on issue #793: URL: https://github.com/apache/maven-mvnd/issues/793#issuecomment-1464134319 I think we should move the discussion to the other issue #786, since that specifically reports the warning about dumb terminal. -- This is an automated message from the Apache Git

[GitHub] [maven-mvnd] psiroky commented on issue #786: Regression "WARNING: Unable to create a system terminal, creating a dumb terminal"

2023-03-10 Thread via GitHub
psiroky commented on issue #786: URL: https://github.com/apache/maven-mvnd/issues/786#issuecomment-1464141388 From #793 by @gnodet >I've merged some enhancements which will enable more logging. Could someone download a build from https://github.com/apache/maven-mvnd/actions/runs/438640

[GitHub] [maven] elharo opened a new pull request, #1050: [MNG-7729] remove unused code

2023-03-10 Thread via GitHub
elharo opened a new pull request, #1050: URL: https://github.com/apache/maven/pull/1050 Now that I look at it, this class probably doesn't belong in this repo at all. It should be repackaged or removed. -- This is an automated message from the Apache Git Service. To respond to the messag

[GitHub] [maven-help-plugin] slawekjaranowski opened a new pull request, #90: [MPH-198] Get rid of maven-reporting-exec

2023-03-10 Thread via GitHub
slawekjaranowski opened a new pull request, #90: URL: https://github.com/apache/maven-help-plugin/pull/90 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPH) filed

[GitHub] [maven-help-plugin] slachiewicz merged pull request #89: [MPH-197] Upgrade plexus-utils to 3.5.1

2023-03-10 Thread via GitHub
slachiewicz merged PR #89: URL: https://github.com/apache/maven-help-plugin/pull/89 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@m

[GitHub] [maven-help-plugin] slachiewicz closed pull request #86: Bump plexus-utils from 3.4.2 to 3.5.1

2023-03-10 Thread via GitHub
slachiewicz closed pull request #86: Bump plexus-utils from 3.4.2 to 3.5.1 URL: https://github.com/apache/maven-help-plugin/pull/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #86: Bump plexus-utils from 3.4.2 to 3.5.1

2023-03-10 Thread via GitHub
dependabot[bot] commented on PR #86: URL: https://github.com/apache/maven-help-plugin/pull/86#issuecomment-1464235269 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versio

[GitHub] [maven-mvnd] psiroky commented on issue #807: NPE in daemon prompter when using iteractive mode with no project (using archetype)

2023-03-10 Thread via GitHub
psiroky commented on issue #807: URL: https://github.com/apache/maven-mvnd/issues/807#issuecomment-1464237494 Which version of `mvnd` are you seeing this with? I tried with `0.9.0` and the latest master (ca4bdd03b3fdec7ee7f67b787a764b2ddb8d8043), but could not reproduce. That being s

[GitHub] [maven-mvnd] gnodet commented on issue #807: NPE in daemon prompter when using iteractive mode with no project (using archetype)

2023-03-10 Thread via GitHub
gnodet commented on issue #807: URL: https://github.com/apache/maven-mvnd/issues/807#issuecomment-1464245537 > Which version of `mvnd` are you seeing this with? I tried with `0.9.0` and the latest master ([ca4bdd0](https://github.com/apache/maven-mvnd/commit/ca4bdd03b3fdec7ee7f67b787a764b2d

[GitHub] [maven-mvnd] rmannibucau commented on issue #807: NPE in daemon prompter when using iteractive mode with no project (using archetype)

2023-03-10 Thread via GitHub
rmannibucau commented on issue #807: URL: https://github.com/apache/maven-mvnd/issues/807#issuecomment-1464252925 Think the option to have a mvn.m2.conf and a mvnd.m2.conf is very tempting. -- This is an automated message from the Apache Git Service. To respond to the message, please log o

[GitHub] [maven-mvnd] gnodet commented on issue #807: NPE in daemon prompter when using iteractive mode with no project (using archetype)

2023-03-10 Thread via GitHub
gnodet commented on issue #807: URL: https://github.com/apache/maven-mvnd/issues/807#issuecomment-1464255073 > Think the option to have a mvn.m2.conf and a mvnd.m2.conf is very tempting. We already have 3 configs in the master: one for `maven`, one for the _mvnd client_ and one for th

[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #91: Bump commons-lang3 from 3.8.1 to 3.12.0

2023-03-10 Thread via GitHub
dependabot[bot] opened a new pull request, #91: URL: https://github.com/apache/maven-help-plugin/pull/91 Bumps commons-lang3 from 3.8.1 to 3.12.0. [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.apache.commo

[GitHub] [maven-help-plugin] dependabot[bot] opened a new pull request, #92: Bump mockito-core from 2.28.2 to 5.2.0

2023-03-10 Thread via GitHub
dependabot[bot] opened a new pull request, #92: URL: https://github.com/apache/maven-help-plugin/pull/92 Bumps [mockito-core](https://github.com/mockito/mockito) from 2.28.2 to 5.2.0. Release notes Sourced from https://github.com/mockito/mockito/releases";>mockito-core's releases.

[GitHub] [maven-help-plugin] slachiewicz closed pull request #74: Bump asm-commons from 9.3 to 9.4

2023-03-10 Thread via GitHub
slachiewicz closed pull request #74: Bump asm-commons from 9.3 to 9.4 URL: https://github.com/apache/maven-help-plugin/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. T

[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #74: Bump asm-commons from 9.3 to 9.4

2023-03-10 Thread via GitHub
dependabot[bot] commented on PR #74: URL: https://github.com/apache/maven-help-plugin/pull/74#issuecomment-1464261832 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versio

[GitHub] [maven-help-plugin] slachiewicz closed pull request #73: Bump asm from 9.3 to 9.4

2023-03-10 Thread via GitHub
slachiewicz closed pull request #73: Bump asm from 9.3 to 9.4 URL: https://github.com/apache/maven-help-plugin/pull/73 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubs

[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #73: Bump asm from 9.3 to 9.4

2023-03-10 Thread via GitHub
dependabot[bot] commented on PR #73: URL: https://github.com/apache/maven-help-plugin/pull/73#issuecomment-1464261958 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor versio

[GitHub] [maven-help-plugin] slachiewicz commented on pull request #92: Bump mockito-core from 2.28.2 to 5.2.0

2023-03-10 Thread via GitHub
slachiewicz commented on PR #92: URL: https://github.com/apache/maven-help-plugin/pull/92#issuecomment-1464262820 @dependabot ignore this major version -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to g

[GitHub] [maven-help-plugin] dependabot[bot] closed pull request #92: Bump mockito-core from 2.28.2 to 5.2.0

2023-03-10 Thread via GitHub
dependabot[bot] closed pull request #92: Bump mockito-core from 2.28.2 to 5.2.0 URL: https://github.com/apache/maven-help-plugin/pull/92 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

[GitHub] [maven-help-plugin] dependabot[bot] commented on pull request #92: Bump mockito-core from 2.28.2 to 5.2.0

2023-03-10 Thread via GitHub
dependabot[bot] commented on PR #92: URL: https://github.com/apache/maven-help-plugin/pull/92#issuecomment-1464262897 OK, I won't notify you about version 5.x.x again, unless you re-open this PR. 😢 -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [maven-site] slachiewicz commented on pull request #398: Document everything before Maven 3.2.5 as end of life

2023-03-10 Thread via GitHub
slachiewicz commented on PR #398: URL: https://github.com/apache/maven-site/pull/398#issuecomment-1464281707 worth to add about https://issues.apache.org/jira/browse/MPH-185 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [maven-help-plugin] slawekjaranowski merged pull request #90: [MPH-198] Get rid of maven-reporting-exec

2023-03-10 Thread via GitHub
slawekjaranowski merged PR #90: URL: https://github.com/apache/maven-help-plugin/pull/90 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [maven-help-plugin] slawekjaranowski opened a new pull request, #93: [MPH-199] Bump mockito-core from 2.28.2 to 4.11.0

2023-03-10 Thread via GitHub
slawekjaranowski opened a new pull request, #93: URL: https://github.com/apache/maven-help-plugin/pull/93 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPH) filed

[GitHub] [maven-assembly-plugin] asfgit closed pull request #102: [MASSEMBLY-973] Support zstd format

2023-03-10 Thread via GitHub
asfgit closed pull request #102: [MASSEMBLY-973] Support zstd format URL: https://github.com/apache/maven-assembly-plugin/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment

[GitHub] [maven-plugin-tools] lppedd opened a new pull request, #199: br element should be closed to properly be validated as XDoc

2023-03-10 Thread via GitHub
lppedd opened a new pull request, #199: URL: https://github.com/apache/maven-plugin-tools/pull/199 This allows correctly generating plugin reports. Otherwise, when configuring `maven-plugin-report-plugin` ```xml org.apache.maven.plugins maven-pl

[GitHub] [maven-mvnd] psiroky opened a new pull request, #809: Random minor fixes / clean-upin OsUtils

2023-03-10 Thread via GitHub
psiroky opened a new pull request, #809: URL: https://github.com/apache/maven-mvnd/pull/809 When browsing through the code I encountered some small things which I think makes sense to fix, so I figured I would create a PR. I may possibly create more of these if I encounter similar th

[GitHub] [maven-scm-publish-plugin] lppedd opened a new pull request, #18: Support using an SSH private key as auth mechanism

2023-03-10 Thread via GitHub
lppedd opened a new pull request, #18: URL: https://github.com/apache/maven-scm-publish-plugin/pull/18 This enhancements brings support for using an SSH key (+ optional passphrase) as an authentication mechanism. Extremely useful in case the work is done over GitHub Enterprise instances

[GitHub] [maven-apache-resources] dependabot[bot] opened a new pull request, #1: Bump plexus-archiver from 1.2 to 3.6.0 in /apache-source-release-assembly-descriptor

2023-03-10 Thread via GitHub
dependabot[bot] opened a new pull request, #1: URL: https://github.com/apache/maven-apache-resources/pull/1 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 1.2 to 3.6.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/r

[GitHub] [maven-apache-resources] dependabot[bot] opened a new pull request, #2: Bump plexus-utils from 1.5.8 to 3.0.16 in /apache-source-release-assembly-descriptor

2023-03-10 Thread via GitHub
dependabot[bot] opened a new pull request, #2: URL: https://github.com/apache/maven-apache-resources/pull/2 Bumps [plexus-utils](https://github.com/sonatype/plexus-utils) from 1.5.8 to 3.0.16. Commits https://github.com/sonatype/plexus-utils/commit/cf317f9b4070c3c619e9ee75a3e38

[GitHub] [maven-help-plugin] slawekjaranowski merged pull request #93: [MPH-199] Bump mockito-core from 2.28.2 to 4.11.0

2023-03-10 Thread via GitHub
slawekjaranowski merged PR #93: URL: https://github.com/apache/maven-help-plugin/pull/93 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [maven-help-plugin] slawekjaranowski opened a new pull request, #94: [MPH-185] Restore location format for effective-pom

2023-03-11 Thread via GitHub
slawekjaranowski opened a new pull request, #94: URL: https://github.com/apache/maven-help-plugin/pull/94 Was changed by accident in 4f9e3af9fa8fd632c19453cc994da4981e3a5e2b Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sur

[GitHub] [maven-scm-publish-plugin] bmarwell commented on pull request #18: Support using an SSH private key as auth mechanism

2023-03-11 Thread via GitHub
bmarwell commented on PR #18: URL: https://github.com/apache/maven-scm-publish-plugin/pull/18#issuecomment-1464875968 Thanks! Do you think you could add a junit test? There are sshd mock servers you could use. -- This is an automated message from the Apache Git Service. To respond to the

[GitHub] [maven-scm-publish-plugin] lppedd commented on pull request #18: Support using an SSH private key as auth mechanism

2023-03-11 Thread via GitHub
lppedd commented on PR #18: URL: https://github.com/apache/maven-scm-publish-plugin/pull/18#issuecomment-1464884121 Hey there @bmarwell! I've noticed all the currently present integration tests revolve around SVN. Not sure how to mock a git server with SSH support. Probably JGit of

[GitHub] [maven-help-plugin] slawekjaranowski opened a new pull request, #95: [MPH-201] Use only what we need from maven-plugin-tools-generators

2023-03-11 Thread via GitHub
slawekjaranowski opened a new pull request, #95: URL: https://github.com/apache/maven-help-plugin/pull/95 Replace deprecated method GeneratorUtils.toText by HtmlToPlainTextConverter So we only need one class HtmlToPlainTextConverter from maven-plugin-tools-generators, not needed depen

[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #104: [MRELEASE-1078] Support version policy to read and use SCM tags and commits

2023-03-11 Thread via GitHub
nielsbasjes commented on code in PR #104: URL: https://github.com/apache/maven-release/pull/104#discussion_r1133069713 ## maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java: ## @@ -426,6 +426,13 @@ */ String getProjectVersion

[GitHub] [maven-release] michael-o commented on a diff in pull request #104: [MRELEASE-1078] Support version policy to read and use SCM tags and commits

2023-03-11 Thread via GitHub
michael-o commented on code in PR #104: URL: https://github.com/apache/maven-release/pull/104#discussion_r1133070826 ## maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java: ## @@ -426,6 +426,13 @@ */ String getProjectVersionPo

[GitHub] [maven-artifact-plugin] bmarwell commented on pull request #16: [MARTIFACT-44] Integration test Handle maven-shade-plugin useDependencyReducedPomInJar

2023-03-11 Thread via GitHub
bmarwell commented on PR #16: URL: https://github.com/apache/maven-artifact-plugin/pull/16#issuecomment-1464890277 Thanks for your contribution! I will put this PR in the slack channel -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[GitHub] [maven-jlink-plugin] bmarwell commented on pull request #138: fix ci issues - switch from openj9 to hotspot java

2023-03-11 Thread via GitHub
bmarwell commented on PR #138: URL: https://github.com/apache/maven-jlink-plugin/pull/138#issuecomment-1464890715 @slachiewicz what were the issues? I'd be happy to report them to IBM and eclipse. -- This is an automated message from the Apache Git Service. To respond to the message, ple

[GitHub] [maven-shared-utils] elharo merged pull request #131: Deprecate newXmlWriter

2023-03-11 Thread via GitHub
elharo merged PR #131: URL: https://github.com/apache/maven-shared-utils/pull/131 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mav

[GitHub] [maven-shared-utils] elharo commented on pull request #133: suggest java.nio.Files.walkFileTree as replacement for DirectoryScanner

2023-03-11 Thread via GitHub
elharo commented on PR #133: URL: https://github.com/apache/maven-shared-utils/pull/133#issuecomment-1464893311 That is correct. It's not a 1:1 replacement, but it does serve the same purpose. Starting from a green field it's no more work to write new code on top of Files.walkFileTree or D

[GitHub] [maven-shared-utils] elharo commented on pull request #133: suggest java.nio.Files.walkFileTree as replacement for DirectoryScanner

2023-03-11 Thread via GitHub
elharo commented on PR #133: URL: https://github.com/apache/maven-shared-utils/pull/133#issuecomment-1464899770 Are there missing bits you're especially concerned about like the default exclusions? Nothing is really missing from the alternatives. It's just that you have to write different

[GitHub] [maven-shared-utils] elharo commented on pull request #134: [MSHARED-1196] Bump maven-shared-components from 37 to 39

2023-03-11 Thread via GitHub
elharo commented on PR #134: URL: https://github.com/apache/maven-shared-utils/pull/134#issuecomment-1464902171 Looks like a few broken Javadoc cross-ref links trip only one of our CIs. Fixing... ``` ^ /home/runner/work/maven-shared-utils/maven-shared

[GitHub] [maven] elharo commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

2023-03-11 Thread via GitHub
elharo commented on code in PR #1015: URL: https://github.com/apache/maven/pull/1015#discussion_r1133081884 ## maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java: ## @@ -60,7 +59,7 @@ public void validate(Settings settings, S

[GitHub] [maven-jlink-plugin] slachiewicz commented on pull request #138: fix ci issues - switch from openj9 to hotspot java

2023-03-11 Thread via GitHub
slachiewicz commented on PR #138: URL: https://github.com/apache/maven-jlink-plugin/pull/138#issuecomment-1464910936 I don't remember what was exactly issue. Our master branch was failing only with this build. Then later i synced it with i think jmod setup. Feel free to try adding one m

[GitHub] [maven] elharo opened a new pull request, #1051: [MNG-7724] don't warn about unsupported SLF4J configs; no one cares

2023-03-11 Thread via GitHub
elharo opened a new pull request, #1051: URL: https://github.com/apache/maven/pull/1051 This is a more direct approach to avoiding the warnings. Just take them out. They're not actionable and no one cares about this. -- This is an automated message from the Apache Git Service. To respond

[GitHub] [maven-shared-io] elharo opened a new pull request, #22: MSHARED-1202 update to parent POM 39

2023-03-11 Thread via GitHub
elharo opened a new pull request, #22: URL: https://github.com/apache/maven-shared-io/pull/22 contains the usual automated spotless churn that this update requires. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[GitHub] [maven-scm-publish-plugin] lppedd commented on pull request #18: Support using an SSH private key as auth mechanism

2023-03-11 Thread via GitHub
lppedd commented on PR #18: URL: https://github.com/apache/maven-scm-publish-plugin/pull/18#issuecomment-1464920727 Also on another note: do you think I should add the `privateKey` and `passphrase` parameters to the mojo? They might be useful in case a user wants to override them at

[GitHub] [maven-scm-publish-plugin] bmarwell commented on pull request #18: Support using an SSH private key as auth mechanism

2023-03-11 Thread via GitHub
bmarwell commented on PR #18: URL: https://github.com/apache/maven-scm-publish-plugin/pull/18#issuecomment-1464923107 The correct place would be the user's settings.xml file. But I'm not sure of there's a place for it yet. -- This is an automated message from the Apache Git Service. To r

[GitHub] [maven-scm-publish-plugin] lppedd commented on pull request #18: Support using an SSH private key as auth mechanism

2023-03-11 Thread via GitHub
lppedd commented on PR #18: URL: https://github.com/apache/maven-scm-publish-plugin/pull/18#issuecomment-1464923685 > The correct place would be the user's settings.xml file In terms of security it's definitely better, I agree. But can't we say the same about `username` and `pass

[GitHub] [maven-dependency-analyzer] elharo merged pull request #79: Bump plexus-utils from 3.4.2 to 3.5.1

2023-03-11 Thread via GitHub
elharo merged PR #79: URL: https://github.com/apache/maven-dependency-analyzer/pull/79 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [maven-dependency-analyzer] elharo merged pull request #78: Bump assertj-core from 3.23.1 to 3.24.2

2023-03-11 Thread via GitHub
elharo merged PR #78: URL: https://github.com/apache/maven-dependency-analyzer/pull/78 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[GitHub] [maven-dependency-analyzer] elharo closed pull request #75: Bump maven-shared-components from 37 to 39

2023-03-11 Thread via GitHub
elharo closed pull request #75: Bump maven-shared-components from 37 to 39 URL: https://github.com/apache/maven-dependency-analyzer/pull/75 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-dependency-analyzer] dependabot[bot] commented on pull request #75: Bump maven-shared-components from 37 to 39

2023-03-11 Thread via GitHub
dependabot[bot] commented on PR #75: URL: https://github.com/apache/maven-dependency-analyzer/pull/75#issuecomment-1464929106 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or min

[GitHub] [maven] gnodet commented on a diff in pull request #1015: Prefer Java standard library to Plexus util

2023-03-11 Thread via GitHub
gnodet commented on code in PR #1015: URL: https://github.com/apache/maven/pull/1015#discussion_r1133104328 ## maven-settings-builder/src/main/java/org/apache/maven/settings/validation/DefaultSettingsValidator.java: ## @@ -58,9 +57,9 @@ public void validate(Settings settings, S

[GitHub] [maven] gnodet merged pull request #1044: [MNG-7727] Remove DefaultMavenProfilesBuilder

2023-03-11 Thread via GitHub
gnodet merged PR #1044: URL: https://github.com/apache/maven/pull/1044 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven-dependency-analyzer] elharo opened a new pull request, #81: Prefer JDK classes to Plexus utils

2023-03-11 Thread via GitHub
elharo opened a new pull request, #81: URL: https://github.com/apache/maven-dependency-analyzer/pull/81 This completely removes Plexus utils from this package. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL a

[GitHub] [maven-shared-utils] elharo commented on pull request #133: suggest java.nio.Files.walkFileTree as replacement for DirectoryScanner

2023-03-11 Thread via GitHub
elharo commented on PR #133: URL: https://github.com/apache/maven-shared-utils/pull/133#issuecomment-1464938845 https://github.com/apache/maven-dependency-analyzer/pull/81 is an example of the sort of change needed to replace these methods, though in that case it's moving from the plexus-u

[GitHub] [maven-help-plugin] slawekjaranowski opened a new pull request, #96: [MPH-200] Refresh download page

2023-03-11 Thread via GitHub
slawekjaranowski opened a new pull request, #96: URL: https://github.com/apache/maven-help-plugin/pull/96 Following this checklist to help us incorporate your contribution quickly and easily: - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MPH) filed

[GitHub] [maven-help-plugin] slawekjaranowski merged pull request #82: [MPH-202] Bump mrm-maven-plugin from 1.4.1 to 1.5.0

2023-03-11 Thread via GitHub
slawekjaranowski merged PR #82: URL: https://github.com/apache/maven-help-plugin/pull/82 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [maven-plugin-tools] lppedd commented on pull request #199: Close br elements to properly be validated as XDoc

2023-03-11 Thread via GitHub
lppedd commented on PR #199: URL: https://github.com/apache/maven-plugin-tools/pull/199#issuecomment-1464944814 Seems there is a bit of a problem here. The Javadoc plugin is complaining about the self-closing elements, which are indeed invalid in that context. Now, I'm not sure

[GitHub] [maven-apache-resources] dependabot[bot] opened a new pull request, #3: Bump plexus-archiver from 1.2 to 3.6.0 in /source-release

2023-03-11 Thread via GitHub
dependabot[bot] opened a new pull request, #3: URL: https://github.com/apache/maven-apache-resources/pull/3 Bumps [plexus-archiver](https://github.com/codehaus-plexus/plexus-archiver) from 1.2 to 3.6.0. Release notes Sourced from https://github.com/codehaus-plexus/plexus-archiver/r

[GitHub] [maven-apache-resources] dependabot[bot] opened a new pull request, #4: Bump plexus-utils from 1.5.8 to 3.0.16 in /source-release

2023-03-11 Thread via GitHub
dependabot[bot] opened a new pull request, #4: URL: https://github.com/apache/maven-apache-resources/pull/4 Bumps [plexus-utils](https://github.com/sonatype/plexus-utils) from 1.5.8 to 3.0.16. Commits https://github.com/sonatype/plexus-utils/commit/cf317f9b4070c3c619e9ee75a3e38

[GitHub] [maven-apache-resources] dependabot[bot] commented on pull request #1: Bump plexus-archiver from 1.2 to 3.6.0 in /apache-source-release-assembly-descriptor

2023-03-11 Thread via GitHub
dependabot[bot] commented on PR #1: URL: https://github.com/apache/maven-apache-resources/pull/1#issuecomment-1464963378 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot re

[GitHub] [maven-apache-resources] dependabot[bot] commented on pull request #2: Bump plexus-utils from 1.5.8 to 3.0.16 in /apache-source-release-assembly-descriptor

2023-03-11 Thread via GitHub
dependabot[bot] commented on PR #2: URL: https://github.com/apache/maven-apache-resources/pull/2#issuecomment-1464963391 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot re

[GitHub] [maven-apache-resources] dependabot[bot] commented on pull request #2: Bump plexus-utils from 1.5.8 to 3.0.16 in /apache-source-release-assembly-descriptor

2023-03-11 Thread via GitHub
dependabot[bot] commented on PR #2: URL: https://github.com/apache/maven-apache-resources/pull/2#issuecomment-1464969155 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot re

[GitHub] [maven-apache-resources] dependabot[bot] commented on pull request #1: Bump plexus-archiver from 1.2 to 3.6.0 in /apache-source-release-assembly-descriptor

2023-03-11 Thread via GitHub
dependabot[bot] commented on PR #1: URL: https://github.com/apache/maven-apache-resources/pull/1#issuecomment-1464969192 Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting `@dependabot re

[GitHub] [maven-plugin-tools] lppedd commented on pull request #199: Close br elements to properly be validated as XDoc

2023-03-11 Thread via GitHub
lppedd commented on PR #199: URL: https://github.com/apache/maven-plugin-tools/pull/199#issuecomment-1464976218 Turns out the problem is on my side and I was trying to fix _the nothing_. So, my old configuration was ```xml org.apache.maven.plugins maven-plugin-plugi

[GitHub] [maven-plugin-tools] lppedd closed pull request #199: Close br elements to properly be validated as XDoc

2023-03-11 Thread via GitHub
lppedd closed pull request #199: Close br elements to properly be validated as XDoc URL: https://github.com/apache/maven-plugin-tools/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [maven-plugin-tools] slawekjaranowski commented on pull request #199: Close br elements to properly be validated as XDoc

2023-03-11 Thread via GitHub
slawekjaranowski commented on PR #199: URL: https://github.com/apache/maven-plugin-tools/pull/199#issuecomment-1464986785 @lppedd you should use the same version of `maven-plugin-plugin` and `maven-plugin-report-plugin` -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-help-plugin] slawekjaranowski merged pull request #91: [MPH-203] Bump commons-lang3 from 3.8.1 to 3.12.0

2023-03-11 Thread via GitHub
slawekjaranowski merged PR #91: URL: https://github.com/apache/maven-help-plugin/pull/91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr

[GitHub] [maven] elharo merged pull request #1051: [MNG-7724] don't warn about unsupported SLF4J configs; no one cares

2023-03-11 Thread via GitHub
elharo merged PR #1051: URL: https://github.com/apache/maven/pull/1051 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[GitHub] [maven] cstamas merged pull request #1037: [MNG-7723] Upgrade to Maven Resolver 1.9.7

2023-03-11 Thread via GitHub
cstamas merged PR #1037: URL: https://github.com/apache/maven/pull/1037 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven] cstamas merged pull request #1046: [MNG-7723] Upgrade to Maven Resolver 1.9.7

2023-03-11 Thread via GitHub
cstamas merged PR #1046: URL: https://github.com/apache/maven/pull/1046 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven-plugin-tools] lppedd commented on pull request #199: Close br elements to properly be validated as XDoc

2023-03-11 Thread via GitHub
lppedd commented on PR #199: URL: https://github.com/apache/maven-plugin-tools/pull/199#issuecomment-1464991435 @slawekjaranowski yup exactly! I've discovered it at last and highlighted it in my last comment. Is it written somewhere in the docs and I've missed it? -- This is an auto

[GitHub] [maven-shared-io] slawekjaranowski commented on pull request #22: MSHARED-1202 update to parent POM 39

2023-03-11 Thread via GitHub
slawekjaranowski commented on PR #22: URL: https://github.com/apache/maven-shared-io/pull/22#issuecomment-1464992253 check for duplicate license header: ``` git grep -c "Licensed to the Apache Software Foundation (ASF) under one" | grep -v ":1" ``` Good will be to have 2

[GitHub] [maven-enforcer] slawekjaranowski opened a new pull request, #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…

2023-03-11 Thread via GitHub
slawekjaranowski opened a new pull request, #253: URL: https://github.com/apache/maven-enforcer/pull/253 …cies with another version than the resolved one --- - rename ResolveUtil to ResolverUtil - introduce methods: - resolveTransitiveDependenciesVerbose resolve with

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #246: [MENFORCER-470] AdvancedDependencyConvergence rule

2023-03-11 Thread via GitHub
slawekjaranowski commented on code in PR #246: URL: https://github.com/apache/maven-enforcer/pull/246#discussion_r1133143363 ## enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/DependencyConvergence.java: ## @@ -50,6 +53,8 @@ public final class DependencyC

[GitHub] [maven-dependency-tree] elharo closed pull request #34: Bump maven-shared-components from 37 to 39

2023-03-11 Thread via GitHub
elharo closed pull request #34: Bump maven-shared-components from 37 to 39 URL: https://github.com/apache/maven-dependency-tree/pull/34 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

[GitHub] [maven] cstamas opened a new pull request, #1053: [MNG-7726] Maven 3.9.0 resolves properties incorrectly

2023-03-11 Thread via GitHub
cstamas opened a new pull request, #1053: URL: https://github.com/apache/maven/pull/1053 There was a typo: the stream contains entries, so e.getKey and e.getValue is needed. --- https://issues.apache.org/jira/browse/MNG-7726 -- This is an automated message from the Apache Gi

[GitHub] [maven] cstamas commented on pull request #1053: [MNG-7726] Maven 3.9.0 resolves properties incorrectly

2023-03-11 Thread via GitHub
cstamas commented on PR #1053: URL: https://github.com/apache/maven/pull/1053#issuecomment-1465026149 Tested the issue provided reproducer, all works now as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[GitHub] [maven-wrapper] elharo opened a new pull request, #96: cleanup a couple more dependency glitches

2023-03-11 Thread via GitHub
elharo opened a new pull request, #96: URL: https://github.com/apache/maven-wrapper/pull/96 Before this PR: ``` [WARNING] Used undeclared dependencies found: [WARNING]org.hamcrest:hamcrest:jar:2.2:test [WARNING]org.junit.jupiter:junit-jupiter-api:jar:5.9.2:test [WAR

[GitHub] [maven] cstamas merged pull request #1053: [MNG-7726] Maven 3.9.0 resolves properties incorrectly

2023-03-11 Thread via GitHub
cstamas merged PR #1053: URL: https://github.com/apache/maven/pull/1053 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[GitHub] [maven-surefire] slachiewicz closed pull request #593: Bump junit-jupiter-engine from 5.3.2 to 5.9.2

2023-03-11 Thread via GitHub
slachiewicz closed pull request #593: Bump junit-jupiter-engine from 5.3.2 to 5.9.2 URL: https://github.com/apache/maven-surefire/pull/593 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-surefire] dependabot[bot] commented on pull request #593: Bump junit-jupiter-engine from 5.3.2 to 5.9.2

2023-03-11 Thread via GitHub
dependabot[bot] commented on PR #593: URL: https://github.com/apache/maven-surefire/pull/593#issuecomment-1465033699 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version

[GitHub] [maven-surefire] slachiewicz closed pull request #592: Bump junit-jupiter-params from 5.3.2 to 5.9.2

2023-03-11 Thread via GitHub
slachiewicz closed pull request #592: Bump junit-jupiter-params from 5.3.2 to 5.9.2 URL: https://github.com/apache/maven-surefire/pull/592 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specifi

[GitHub] [maven-surefire] dependabot[bot] commented on pull request #592: Bump junit-jupiter-params from 5.3.2 to 5.9.2

2023-03-11 Thread via GitHub
dependabot[bot] commented on PR #592: URL: https://github.com/apache/maven-surefire/pull/592#issuecomment-1465033776 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version

[GitHub] [maven-enforcer] slawekjaranowski merged pull request #252: [MENFORCER-471] Bump plexus-utils from 3.5.0 to 3.5.1

2023-03-11 Thread via GitHub
slawekjaranowski merged PR #252: URL: https://github.com/apache/maven-enforcer/pull/252 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr.

[GitHub] [maven] gnodet opened a new pull request, #1054: Update DefaultSettingsValidator.java

2023-03-11 Thread via GitHub
gnodet opened a new pull request, #1054: URL: https://github.com/apache/maven/pull/1054 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/MNG) filed for the

[GitHub] [maven-mvnd] gnodet commented on pull request #808: Make the default (non-native) build work again

2023-03-12 Thread via GitHub
gnodet commented on PR #808: URL: https://github.com/apache/maven-mvnd/pull/808#issuecomment-1465125530 > Would it make sense to include a non-native build as part of the CI checks? Or that more like nice to have, and if it gets occasionally broken it is not really a big deal and can be fix

[GitHub] [maven-release] michael-o commented on a diff in pull request #104: [MRELEASE-1078] Support version policy to read and use SCM tags and commits

2023-03-12 Thread via GitHub
michael-o commented on code in PR #104: URL: https://github.com/apache/maven-release/pull/104#discussion_r1133224343 ## maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java: ## @@ -426,6 +426,13 @@ */ String getProjectVersionPo

[GitHub] [maven-site] asfgit closed pull request #398: Document everything before Maven 3.2.5 as end of life

2023-03-12 Thread via GitHub
asfgit closed pull request #398: Document everything before Maven 3.2.5 as end of life URL: https://github.com/apache/maven-site/pull/398 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [maven-mvnd] psiroky commented on pull request #808: Make the default (non-native) build work again

2023-03-12 Thread via GitHub
psiroky commented on PR #808: URL: https://github.com/apache/maven-mvnd/pull/808#issuecomment-1465149279 > > Would it make sense to include a non-native build as part of the CI checks? Or that more like nice to have, and if it gets occasionally broken it is not really a big deal and can be

[GitHub] [maven-release] nielsbasjes commented on a diff in pull request #104: [MRELEASE-1078] Support version policy to read and use SCM tags and commits

2023-03-12 Thread via GitHub
nielsbasjes commented on code in PR #104: URL: https://github.com/apache/maven-release/pull/104#discussion_r1133225545 ## maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java: ## @@ -426,6 +426,13 @@ */ String getProjectVersion

<    4   5   6   7   8   9   10   11   12   13   >