slawekjaranowski commented on code in PR #246:
URL: https://github.com/apache/maven-enforcer/pull/246#discussion_r1133143363


##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/DependencyConvergence.java:
##########
@@ -50,6 +53,8 @@ public final class DependencyConvergence extends 
AbstractStandardEnforcerRule {
 
     private List<String> excludes;
 
+    private List<String> scopes = Arrays.asList(SCOPE_COMPILE, SCOPE_RUNTIME, 
SCOPE_IMPORT, SCOPE_SYSTEM);

Review Comment:
   SCOPE_IMPORT - is special one used in dependencyManagement - we don't 
dependencies in this scope.
   Please remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to