nielsbasjes commented on code in PR #104:
URL: https://github.com/apache/maven-release/pull/104#discussion_r1133225545
##########
maven-release-api/src/main/java/org/apache/maven/shared/release/config/ReleaseDescriptor.java:
##########
@@ -426,6 +426,13 @@
*/
String getProjectVersionPolicyId();
+ /**
+ * Get the (optional) config for the VersionPolicy implementation used to
calculate the project versions.
+ *
+ * @return The parsed XML of the provided config (an instance of
XmlPlexusConfiguration) or null.
+ */
+ Object getProjectVersionPolicyConfig();
+
Review Comment:
In the `mdo` file you can specify a bunch of types and you can specify (xml)
nesting.
If you cannot specify the entire thing in there (like in this case because
all custom Version Policies will have currently unknown config options) you
either end up with
- it being a `string` which means you have to CDATA the config which results
in a very bad developer experience, but it does allow you to have any kind of
config format you like (xml, json, yaml, ...) .
- it being a `dom` which makes it an XML without schema. The effect is that
an IDE can only assist you in making sure it is an XML (which is not validated
other than having the open and close tags in sync). And the effect is that the
generate Modello code says it is an `Object` which causes what I tried to
describe above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
