Pankraz76 commented on PR #2300:
URL: https://github.com/apache/maven/pull/2300#issuecomment-2870029984
> run
https://github.com/user-attachments/assets/8f70fc2a-3806-44a6-aa73-a3ded2b7bdc4";
/>
Would be nice to have it in place running like rewrite, via github actions:
Pankraz76 commented on PR #2302:
URL: https://github.com/apache/maven/pull/2302#issuecomment-2869920081
Files changed 135
before:
ide fix:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
Pankraz76 commented on code in PR #2307:
URL: https://github.com/apache/maven/pull/2307#discussion_r2083549961
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelVersionParserTest.java:
##
@@ -22,15 +22,14 @@
import org.eclipse.aether.util.version.GenericVersion
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083618501
##
pom.xml:
##
@@ -799,6 +799,44 @@ under the License.
+
+org.openrewrite.maven
+rewrite-maven-plugin
+6.8.0
+
dependabot[bot] opened a new pull request, #251:
URL: https://github.com/apache/maven-clean-plugin/pull/251
Bumps
[org.apache.maven.resolver:maven-resolver-api](https://github.com/apache/maven-resolver)
from 1.9.22 to 1.9.23.
Release notes
Sourced from https://github.com/apache/ma
Bukama commented on PR #92:
URL: https://github.com/apache/maven-archiver/pull/92#issuecomment-2870887670
> We need two milestones for master and 3.x
Ah yeah stupid me. Milestone added. Other changes (on the 3.x branches) I
will do tonight and then merge.
--
This is an automated me
Pankraz76 commented on PR #2300:
URL: https://github.com/apache/maven/pull/2300#issuecomment-2871071473
actually done:
- https://github.com/apache/maven/pull/2322
`failOnDryRunResults` is what we need. Thanks
--
This is an automated message from the Apache Git Service.
To re
Pankraz76 commented on PR #2236:
URL: https://github.com/apache/maven/pull/2236#issuecomment-2871075282
leveraging PMD will prevent flaws from being merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Pankraz76 commented on code in PR #2312:
URL: https://github.com/apache/maven/pull/2312#discussion_r2083939820
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -35,93 +27,18 @@
import org.apache.maven.api.services.xml.XmlReaderRequest;
Pankraz76 commented on PR #2300:
URL: https://github.com/apache/maven/pull/2300#issuecomment-2871083896
successor: https://github.com/apache/maven/pull/2322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
Pankraz76 closed pull request #2300: [POC] Modernize codebase - Automatically
fix `Checkstyle violations`
URL: https://github.com/apache/maven/pull/2300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
slawekjaranowski commented on code in PR #2300:
URL: https://github.com/apache/maven/pull/2300#discussion_r2083939894
##
pom.xml:
##
@@ -799,6 +799,31 @@ under the License.
+
+org.openrewrite.maven
+rewrite-maven-plugin
+6.7.0
+
slawekjaranowski commented on code in PR #2321:
URL: https://github.com/apache/maven/pull/2321#discussion_r2083943275
##
.editorconfig:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE fi
Pankraz76 commented on code in PR #2321:
URL: https://github.com/apache/maven/pull/2321#discussion_r2083949514
##
.editorconfig:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
Pankraz76 commented on code in PR #2321:
URL: https://github.com/apache/maven/pull/2321#discussion_r2083952651
##
.editorconfig:
##
@@ -0,0 +1,33 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# d
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083620544
##
pom.xml:
##
@@ -1159,5 +1159,53 @@ under the License.
+
+ rewrite
+
+true
+
+
+
+
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083621036
##
src/mdo/java/WrapperList.java:
##
@@ -105,7 +105,7 @@ public T remove(int index) {
}
}
-private Object writeReplace() throws ObjectStreamExceptio
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083621036
##
src/mdo/java/WrapperList.java:
##
@@ -105,7 +105,7 @@ public T remove(int index) {
}
}
-private Object writeReplace() throws ObjectStreamExceptio
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083621988
##
pom.xml:
##
@@ -1159,5 +1159,53 @@ under the License.
+
+ rewrite
+
+true
+
+
+
+
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083621988
##
pom.xml:
##
@@ -1159,5 +1159,53 @@ under the License.
+
+ rewrite
+
+true
+
+
+
+
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083620544
##
pom.xml:
##
@@ -1159,5 +1159,53 @@ under the License.
+
+ rewrite
+
+true
+
+
+
+
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083621988
##
pom.xml:
##
@@ -1159,5 +1159,53 @@ under the License.
+
+ rewrite
+
+true
+
+
+
+
+
gnodet commented on PR #2300:
URL: https://github.com/apache/maven/pull/2300#issuecomment-2870713739
The OpenRewrite maven plugin seems a much better way to fix the problems
imho:
https://docs.openrewrite.org/reference/rewrite-maven-plugin
The `rewrite:dryRun` goal with
`true` dir
Pankraz76 commented on code in PR #2307:
URL: https://github.com/apache/maven/pull/2307#discussion_r2083552318
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelVersionParserTest.java:
##
@@ -22,15 +22,14 @@
import org.eclipse.aether.util.version.GenericVersion
Pankraz76 commented on code in PR #2307:
URL: https://github.com/apache/maven/pull/2307#discussion_r2083552318
##
impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultModelVersionParserTest.java:
##
@@ -22,15 +22,14 @@
import org.eclipse.aether.util.version.GenericVersion
Bukama merged PR #246:
URL: https://github.com/apache/maven-site/pull/246
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apach
[
https://issues.apache.org/jira/browse/MNGSITE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Bünger reassigned MNGSITE-246:
---
Assignee: Matthias Bünger
> Documentation of mavenrc_pre / .mavenrc
> -
gnodet commented on PR #2307:
URL: https://github.com/apache/maven/pull/2307#issuecomment-2869970640
> JUnit 5 is equal, therefore superior to AssertJ.
>
>
>
> only need to apply: JUnit Jupiter best practices
>
>
>
> - https://github.com/apache/maven/pull/2320
Bukama opened a new pull request, #154:
URL: https://github.com/apache/maven-filtering/pull/154
* Release and milestone were already set up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
gnodet commented on PR #2300:
URL: https://github.com/apache/maven/pull/2300#issuecomment-2870041976
> > run
>
>
>
> https://github.com/user-attachments/assets/8f70fc2a-3806-44a6-aa73-a3ded2b7bdc4";
/>
>
>
>
> Would be nice to have it in place running like rewri
Pankraz76 commented on PR #2321:
URL: https://github.com/apache/maven/pull/2321#issuecomment-2870042962
assuming our project dont require spiked line endings like PMD and Check to
pass build.
-
https://www.aleksandrhovhannisyan.com/blog/crlf-vs-lf-normalizing-line-endings-in-git/
slawekjaranowski closed issue #263: Unable to add module as it is not of
packaging 'pom'
URL: https://github.com/apache/maven-archetype/issues/263
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
slawekjaranowski merged PR #264:
URL: https://github.com/apache/maven-archetype/pull/264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
github-actions[bot] commented on issue #649:
URL: https://github.com/apache/maven-mvnd/issues/649#issuecomment-2870673894
This issue has been closed because no response was received within 90 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
github-actions[bot] closed issue #583: modified the settings.xml file in the
maven preset in the mvnd, but doesn't workout
URL: https://github.com/apache/maven-mvnd/issues/583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and u
github-actions[bot] closed issue #578: Exception in thread "main"
org.mvndaemon.mvnd.common.DaemonException$ConnectException: Timeout waiting to
connect to the Maven daemon.
URL: https://github.com/apache/maven-mvnd/issues/578
--
This is an automated message from the Apache Git Service.
To
github-actions[bot] closed issue #732: MacOS - CTRL + C Will Not Release Port
URL: https://github.com/apache/maven-mvnd/issues/732
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
github-actions[bot] commented on issue #732:
URL: https://github.com/apache/maven-mvnd/issues/732#issuecomment-2870673865
This issue has been closed because no response was received within 90 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
github-actions[bot] closed issue #649: Maven goal is sometimes skipped
URL: https://github.com/apache/maven-mvnd/issues/649
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To u
github-actions[bot] commented on issue #578:
URL: https://github.com/apache/maven-mvnd/issues/578#issuecomment-2870673978
This issue has been closed because no response was received within 90 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
github-actions[bot] closed issue #561: The same build fails on the second run
URL: https://github.com/apache/maven-mvnd/issues/561
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
github-actions[bot] commented on issue #561:
URL: https://github.com/apache/maven-mvnd/issues/561#issuecomment-2870674020
This issue has been closed because no response was received within 90 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
github-actions[bot] commented on issue #583:
URL: https://github.com/apache/maven-mvnd/issues/583#issuecomment-2870673942
This issue has been closed because no response was received within 90 days.
--
This is an automated message from the Apache Git Service.
To respond to the message, plea
gnodet merged PR #2236:
URL: https://github.com/apache/maven/pull/2236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o
[
https://issues.apache.org/jira/browse/MNG-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet updated MNG-8686:
-
Fix Version/s: 4.0.0-rc-4
> Common includes/excludes implementation
> -
[
https://issues.apache.org/jira/browse/MNG-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet reassigned MNG-8686:
Assignee: Martin Desruisseaux
> Common includes/excludes implementation
> --
[
https://issues.apache.org/jira/browse/MNG-8686?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Guillaume Nodet closed MNG-8686.
Resolution: Fixed
> Common includes/excludes implementation
> ---
Pankraz76 commented on PR #2315:
URL: https://github.com/apache/maven/pull/2315#issuecomment-2870062765
item:
Caused by: org.eclipse.aether.resolution.ArtifactResolutionException: The
following artifacts could not be resolved:
org.apache.maven.its.mng5639:a:pom:0.1 (absent): Could no
Pankraz76 commented on PR #2315:
URL: https://github.com/apache/maven/pull/2315#issuecomment-2870020140
its possible, having only small benefit yes, but idk why we should hide the
code.
its there, lets admin and embrace.
--
This is an automated message from the Apache Git Service.
Pankraz76 opened a new pull request, #2321:
URL: https://github.com/apache/maven/pull/2321
rival/addition to
- https://github.com/apache/maven/pull/2300
https://github.com/user-attachments/assets/9c43961c-0e1d-45a4-95c3-891ba5be8450";
/>
--
This is an automated message
slawekjaranowski merged PR #268:
URL: https://github.com/apache/maven-archetype/pull/268
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr
slawekjaranowski closed issue #128: [EXEC-124] maven-changes-plugin:3.0.0-M2
causes "Error in the JQL Query" #127
URL: https://github.com/apache/maven-changes-plugin/issues/128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
slawekjaranowski merged PR #127:
URL: https://github.com/apache/maven-changes-plugin/pull/127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
dependabot[bot] closed pull request #162: Bump
org.apache.maven.resolver:maven-resolver-api from 1.9.20 to 1.9.22
URL: https://github.com/apache/maven-wrapper/pull/162
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
dependabot[bot] opened a new pull request, #2324:
URL: https://github.com/apache/maven/pull/2324
Bumps `jlineVersion` from 3.29.0 to 3.30.0.
Updates `org.jline:jline-reader` from 3.29.0 to 3.30.0
Release notes
Sourced from https://github.com/jline/jline3/releases";>org.jline:jlin
dependabot[bot] opened a new pull request, #165:
URL: https://github.com/apache/maven-wrapper/pull/165
Bumps
[org.apache.maven.resolver:maven-resolver-api](https://github.com/apache/maven-resolver)
from 1.9.20 to 1.9.23.
Release notes
Sourced from https://github.com/apache/maven-r
dependabot[bot] commented on PR #162:
URL: https://github.com/apache/maven-wrapper/pull/162#issuecomment-2870487323
Superseded by #165.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
[
https://issues.apache.org/jira/browse/MNGSITE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Matthias Bünger closed MNGSITE-246.
---
Resolution: Fixed
> Documentation of mavenrc_pre / .mavenrc
> --
gnodet commented on PR #2315:
URL: https://github.com/apache/maven/pull/2315#issuecomment-2870025520
> > I actually don't like folder alignment proposal.
>
>
>
> Whats the matter?
>
>
>
> **Current Problems**:
>
> - Out of sync implementation and design mo
desruisseaux commented on code in PR #2236:
URL: https://github.com/apache/maven/pull/2236#discussion_r2083624119
##
impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java:
##
@@ -0,0 +1,622 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083621988
##
pom.xml:
##
@@ -1159,5 +1159,53 @@ under the License.
+
+ rewrite
+
+true
+
+
+
+
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083620544
##
pom.xml:
##
@@ -1159,5 +1159,53 @@ under the License.
+
+ rewrite
+
+true
+
+
+
+
+
Pankraz76 commented on code in PR #2322:
URL: https://github.com/apache/maven/pull/2322#discussion_r2083620544
##
pom.xml:
##
@@ -1159,5 +1159,53 @@ under the License.
+
+ rewrite
+
+true
+
+
+
+
+
Pankraz76 commented on code in PR #2236:
URL: https://github.com/apache/maven/pull/2236#discussion_r2083627857
##
impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java:
##
@@ -0,0 +1,622 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
VZEROALL opened a new issue, #842:
URL: https://github.com/apache/maven-surefire/issues/842
### New feature, improvement proposal
hello
we use testNG to run tests via suites, where each suite denotes the
functionality of each team, e.g. team1, team2, team3
The problem is
Pankraz76 commented on code in PR #2236:
URL: https://github.com/apache/maven/pull/2236#discussion_r2083627857
##
impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java:
##
@@ -0,0 +1,622 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or
slawekjaranowski opened a new pull request, #269:
URL: https://github.com/apache/maven-archetype/pull/269
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Your pull request should address just one issue, without pulling in
other changes.
slawekjaranowski opened a new pull request, #129:
URL: https://github.com/apache/maven-changes-plugin/pull/129
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MCHANGE
slawekjaranowski commented on code in PR #93:
URL: https://github.com/apache/maven-archiver/pull/93#discussion_r2083630399
##
.asf.yaml:
##
@@ -29,6 +29,9 @@ github:
rebase: true
autolink_jira:
- MSHARED
+ del_branch_on_merge: true
+ features:
+issues: true
R
gnodet commented on code in PR #2312:
URL: https://github.com/apache/maven/pull/2312#discussion_r2083427604
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultPluginXmlFactory.java:
##
@@ -45,58 +48,71 @@
@Named
@Singleton
public class DefaultPluginXmlFactory imple
gnodet commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083428413
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest request) throws
XmlWriterExc
gnodet commented on PR #2319:
URL: https://github.com/apache/maven/pull/2319#issuecomment-2869544230
The decision on switching to JDK 21 has not been settled yet.
And there's already another PR for it.
--
This is an automated message from the Apache Git Service.
To respond to the me
gnodet closed pull request #2319: [POC] Migrate to `Java 21` - infrastructure
URL: https://github.com/apache/maven/pull/2319
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
Pankraz76 commented on PR #2307:
URL: https://github.com/apache/maven/pull/2307#issuecomment-2869675626
> I think there's still room for improvements.
I would argue against this change now, realising and remembering that JUnit
5 looks almost 1o1 the same like AssertJ.
Both foll
Pankraz76 commented on code in PR #2236:
URL: https://github.com/apache/maven/pull/2236#discussion_r2083479257
##
impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Pankraz76 commented on PR #2307:
URL: https://github.com/apache/maven/pull/2307#issuecomment-2869679005
JUnit 5 is equal, therefore superior to AssertJ.
only need to apply: JUnit Jupiter best practices
- https://github.com/apache/maven/pull/2320
https://github.com/user-at
Pankraz76 commented on code in PR #2236:
URL: https://github.com/apache/maven/pull/2236#discussion_r2083479902
##
impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java:
##
@@ -0,0 +1,92 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ *
Pankraz76 opened a new pull request, #2320:
URL: https://github.com/apache/maven/pull/2320
-
https://docs.openrewrite.org/recipes/java/testing/junit5/junit5bestpractices
-
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub a
Pankraz76 commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083482049
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest request) throws
XmlWriter
Pankraz76 commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083482049
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest request) throws
XmlWriter
[
https://issues.apache.org/jira/browse/MRESOLVER-718?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17950763#comment-17950763
]
Per Nyfelt commented on MRESOLVER-718:
--
This could either look something like thi
Pankraz76 commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083482049
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest request) throws
XmlWriter
[
https://issues.apache.org/jira/browse/MRESOLVER-718?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Per Nyfelt updated MRESOLVER-718:
-
Description:
There does not seem to be a way to support BOM's when declaring the
dependencies
Pankraz76 commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083482049
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest request) throws
XmlWriter
Bukama commented on code in PR #268:
URL: https://github.com/apache/maven-archetype/pull/268#discussion_r2083486113
##
archetype-models/archetype-descriptor/pom.xml:
##
@@ -39,7 +39,9 @@
org.codehaus.modello
modello-maven-plugin
- 1.1.0
+
Pankraz76 commented on PR #2315:
URL: https://github.com/apache/maven/pull/2315#issuecomment-2869710500
> unless we can actually run ITs, as the assumption would be that we can.
Why Should Developers Run This High-Intensity Task? Its excluded in
dedicated profile, like expected for go
slawekjaranowski merged PR #71:
URL: https://github.com/apache/maven-shared-resources/pull/71
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-uns
slawekjaranowski commented on PR #72:
URL:
https://github.com/apache/maven-shared-resources/pull/72#issuecomment-2869618689
> Well, it will impact all maven projects, so it's really disruptive without
any idea how much work it will require.
>
> @slawekjaranowski ?
Exactly we u
dependabot[bot] commented on PR #120:
URL:
https://github.com/apache/maven-changes-plugin/pull/120#issuecomment-2869621961
Looks like org.apache.maven.plugins:maven-plugins is up-to-date now, so this
is no longer needed.
--
This is an automated message from the Apache Git Service.
To res
slawekjaranowski commented on PR #120:
URL:
https://github.com/apache/maven-changes-plugin/pull/120#issuecomment-2869621698
@dependabot rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
slawekjaranowski commented on PR #127:
URL:
https://github.com/apache/maven-changes-plugin/pull/127#issuecomment-2869622561
>
> Then please fix
https://maven.apache.org/plugins/maven-changes-plugin/issue-management.html
Was updated in #122, will be visible with next release.
dependabot[bot] closed pull request #120: Bump
org.apache.maven.plugins:maven-plugins from 43 to 44
URL: https://github.com/apache/maven-changes-plugin/pull/120
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abov
slawekjaranowski commented on PR #127:
URL:
https://github.com/apache/maven-changes-plugin/pull/127#issuecomment-2869625486
@garydgregory what do you think about to change title of PR and commit
subject to something like:
`Escape JIRA reserved words in JqlQueryBuilder`
to show what w
Pankraz76 commented on PR #2300:
URL: https://github.com/apache/maven/pull/2300#issuecomment-2869770114
> > > > > > Not sure I understand here. As we are using spotless already for
the code, what is this PR providing?
> > > > >
> > > > >
> > > > > We still use checkstyle for thing
Pankraz76 commented on PR #2300:
URL: https://github.com/apache/maven/pull/2300#issuecomment-2869773513
> already for the code
yes its very nice, but still not fully automated, kind of demanding
`.editorconfig`, to fix issues before they occur, should making the nice tool,
I want to
garydgregory commented on PR #127:
URL:
https://github.com/apache/maven-changes-plugin/pull/127#issuecomment-2869773510
@slawekjaranowski
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
gnodet commented on PR #2300:
URL: https://github.com/apache/maven/pull/2300#issuecomment-2869778268
> > already for the code
>
>
>
> yes its very nice, but still not fully automated, kind of demanding
`.editorconfig`, to fix issues before they occur, thus promote the nice too
gnodet commented on PR #2303:
URL: https://github.com/apache/maven/pull/2303#issuecomment-2869779440
You should not raise multiple PRs for the same thing, it becomes a mess and
we have no idea what to review. Keep a single PR for one fix and update it.
--
This is an automated message fro
gnodet commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083498672
##
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest request) throws
XmlWriterExc
gnodet commented on PR #2315:
URL: https://github.com/apache/maven/pull/2315#issuecomment-2869780226
I agree with consistency. That does not necessarily mean aligning directory
structure with artifact id.
--
This is an automated message from the Apache Git Service.
To respond to the mess
1 - 100 of 183 matches
Mail list logo
