gnodet commented on PR #2300: URL: https://github.com/apache/maven/pull/2300#issuecomment-2870041976
> > run > > > > <img width="976" alt="image" src="https://github.com/user-attachments/assets/8f70fc2a-3806-44a6-aa73-a3ded2b7bdc4"; /> > > > > Would be nice to have it in place running like rewrite, via github actions: > > > > https://github.com/openrewrite/rewrite-static-analysis/pull/497#discussion_r2032474233 > > > > Its nifty that we have outdated stuff gone in > > > > - https://github.com/apache/maven/pull/2310 > > > > , but its not banned and fixed on the long run; still causing friction, needed to be automated. > > > > As local run is optional, but the way to do. We would add all wanted styles and make like spotless. Then after clean install code would be fixed, but not forces to be pushed again. > > > > Checkstyle will ensure spotless violations, **but not rewrite recipes (e.g. unused methods)**. Would need to add rewrite checks and auto apply them, or kind of prevent merge, until resolved to solve this. feels wierd. > > > > Whats your advice, how to fix this on the long run? @timtebeek > > > > - https://pmd.github.io/pmd/pmd_rules_java_bestpractices.html#unusedprivatemethod > > - https://docs.openrewrite.org/recipes/staticanalysis/removeunusedprivatemethods > > > > <img width="1007" alt="image" src="https://github.com/user-attachments/assets/6f610d21-5c13-424e-8fe3-7dd0e6a21fe3"; /> > > > > > > I don't think changing the code in an action would be a good idea. I'd really favor the same behavior we use with spotless, i.e. a profile (activated by default) which fails the build if a rule cannot be validated (in the case of open rewrite, if a rule would actually apply and change the code) and a profile which would actually apply the rules. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
