Pankraz76 commented on code in PR #2316:
URL: https://github.com/apache/maven/pull/2316#discussion_r2083482049
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultModelXmlFactory.java:
##########
@@ -121,7 +121,7 @@ public void write(XmlWriterRequest<Model> request) throws
XmlWriterException {
Writer writer = request.getWriter();
Function<Object, String> inputLocationFormatter =
request.getInputLocationFormatter();
if (writer == null && outputStream == null && path == null) {
- throw new IllegalArgumentException("writer, outputStream or path
must be non null");
+ throw new IllegalArgumentException("writer, output stream, or path
must be non-null");
Review Comment:
yes true. Making it generic would take random impl. details away. What if
tomorrow foo resources is new input?
This is kind of fluff and takes away.
We need some valid input - thats all.
```suggestion
throw new IllegalArgumentException("No valid input source
given.");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
