Re: [PR] [MNG-7353] support CLI "mvn pluginPrefix:version:goal" [maven]

2025-01-08 Thread via GitHub
kelunik commented on code in PR #757: URL: https://github.com/apache/maven/pull/757#discussion_r1906887834 ## maven-core/src/main/java/org/apache/maven/lifecycle/internal/MojoDescriptorCreator.java: ## @@ -176,18 +176,31 @@ public MojoDescriptor getMojoDescriptor( String task,

[jira] [Commented] (MNG-8486) Maven System Properties does not contain Maven User Properties anymore

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911022#comment-17911022 ] Guillaume Nodet commented on MNG-8486: -- I agree the behavior looks correct to me and t

[jira] [Closed] (MNG-8486) Maven System Properties does not contain Maven User Properties anymore

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8486?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8486. Resolution: Not A Problem > Maven System Properties does not contain Maven User Properties anymore >

Re: [PR] [MNGSITE-393] Remove references to Maven 2.x [maven]

2025-01-08 Thread via GitHub
elharo commented on code in PR #2024: URL: https://github.com/apache/maven/pull/2024#discussion_r1907399068 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -542,9 +542,9 @@ String

Re: [PR] [MNG-8493] 'serialVersionUID' can be annotated with '@Serial' annotation [maven]

2025-01-08 Thread via GitHub
Stellar1999 commented on code in PR #2025: URL: https://github.com/apache/maven/pull/2025#discussion_r1907404189 ## impl/maven-logging/src/main/java/org/apache/maven/slf4j/MavenBaseLogger.java: ## @@ -146,6 +147,7 @@ */ public class MavenBaseLogger extends LegacyAbstractLogge

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911148#comment-17911148 ] ASF GitHub Bot commented on MSHARED-1454: - elharo commented on code in PR #50:

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
elharo commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907400797 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean origina

Re: [PR] Fix comparisons against null in PathSource.equals [maven]

2025-01-08 Thread via GitHub
elharo merged PR #2026: URL: https://github.com/apache/maven/pull/2026 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

Re: [I] Update Articles links [maven-site]

2025-01-08 Thread via GitHub
VISHVA1403 commented on issue #631: URL: https://github.com/apache/maven-site/issues/631#issuecomment-2578017425 > can be interesting: > > https://analytics.apache.org/index.php?module=Overlay&period=month&date=today&idSite=3#?l=https$3A$2F$2Fmaven.apache.org$2Farticles.html Ba

Re: [I] Update Articles links [maven-site]

2025-01-08 Thread via GitHub
VISHVA1403 commented on issue #631: URL: https://github.com/apache/maven-site/issues/631#issuecomment-2578020041 If anyone find any valuable new resources we can add those. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

Re: [PR] Bump org.codehaus.gmavenplus:gmavenplus-plugin from 4.0.1 to 4.1.1 [maven-mvnd]

2025-01-08 Thread via GitHub
cstamas merged PR #1239: URL: https://github.com/apache/maven-mvnd/pull/1239 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.ap

[jira] [Created] (MNG-8502) The "embeded" executor does not obey MAVEN_ARGS env variable

2025-01-08 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MNG-8502: Summary: The "embeded" executor does not obey MAVEN_ARGS env variable Key: MNG-8502 URL: https://issues.apache.org/jira/browse/MNG-8502 Project: Maven Issue

[jira] [Assigned] (MNG-8502) The "embeded" executor does not obey MAVEN_ARGS env variable

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8502: Assignee: Tamas Cservenak > The "embeded" executor does not obey MAVEN_ARGS env variable > -

[jira] [Closed] (MENFORCER-479) Version enforcer rules print single versions when a range is expected

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MENFORCER-479. --- > Version enforcer rules print single versions when a range is expected >

[jira] [Updated] (MENFORCER-506) Move EnforceBytecodeVersion rule from extra-rules

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MENFORCER-506: Issue Type: New Feature (was: Task) > Move EnforceBytecodeVersion rule

[jira] [Resolved] (MENFORCER-479) Version enforcer rules print single versions when a range is expected

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-479?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MENFORCER-479. - Resolution: Fixed > Version enforcer rules print single versions when

Re: [PR] [MNGSITE-393] Remove references to Maven 2.x [maven]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #2024: URL: https://github.com/apache/maven/pull/2024#discussion_r1907339251 ## api/maven-api-settings/src/main/mdo/settings.mdo: ## @@ -542,9 +542,9 @@ String

Re: [PR] Delete unused mode constants [maven]

2025-01-08 Thread via GitHub
gnodet commented on PR #2022: URL: https://github.com/apache/maven/pull/2022#issuecomment-2577911087 > Or throw an exception? Throwing an exception would indeed be easier. We'd need to assess that not too many POMs using invalid values... -- This is an automated message from the A

[PR] Executor improvements [maven]

2025-01-08 Thread via GitHub
cstamas opened a new pull request, #2032: URL: https://github.com/apache/maven/pull/2032 Salvaged from the "split repo for ITs" experiment. The experiment failed but this improvement is good to have, as makes the embedded executor behave more closely like forked executor. Embedded so

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
elharo commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907224644 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -16,7 +16,7 @@ * specific language governing permissions and limitations

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911092#comment-17911092 ] ASF GitHub Bot commented on MSHARED-1454: - elharo commented on code in PR #50:

[PR] [MENFORCER-511] Match start-tag to end-tag [maven-enforcer]

2025-01-08 Thread via GitHub
elharo opened a new pull request, #341: URL: https://github.com/apache/maven-enforcer/pull/341 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [PR] [MENFORCER-390] "requireFilesExist" no longer handles non-canonical paths [maven-enforcer]

2025-01-08 Thread via GitHub
elharo commented on code in PR #297: URL: https://github.com/apache/maven-enforcer/pull/297#discussion_r1907238846 ## enforcer-rules/src/test/java/org/apache/maven/enforcer/rules/files/TestRequireFilesDontExist.java: ## @@ -107,15 +106,58 @@ void testEmptyFileListAllowNull() {

Re: [PR] [MNG-8493] 'serialVersionUID' can be annotated with '@Serial' annotation [maven]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #2025: URL: https://github.com/apache/maven/pull/2025#discussion_r1907313699 ## impl/maven-logging/src/main/java/org/apache/maven/slf4j/MavenBaseLogger.java: ## @@ -146,6 +147,7 @@ */ public class MavenBaseLogger extends LegacyAbstractLogger {

[PR] Grammar nits [maven-enforcer]

2025-01-08 Thread via GitHub
elharo opened a new pull request, #342: URL: https://github.com/apache/maven-enforcer/pull/342 "Setup" is a noun. "Set up" is a verb -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [PR] APT to Markdown [maven-apache-parent]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #285: URL: https://github.com/apache/maven-apache-parent/pull/285#discussion_r1908267404 ## docs/src/site/markdown/index.md.vm: ## @@ -0,0 +1,134 @@ +--- Review Comment: I wonder if we should use two commits to somehow force the git history to

Re: [PR] APT to Markdown [maven-apache-parent]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #285: URL: https://github.com/apache/maven-apache-parent/pull/285#discussion_r1908266832 ## docs/src/site/markdown/index.md.vm: ## @@ -0,0 +1,134 @@ +--- +title: Apache Software Foundation Parent POM +author: + - Benson Margulies + - Hervé Bout

Re: [PR] APT to Markdown [maven-apache-parent]

2025-01-08 Thread via GitHub
kwin commented on code in PR #285: URL: https://github.com/apache/maven-apache-parent/pull/285#discussion_r1908278960 ## docs/src/site/markdown/index.md.vm: ## @@ -0,0 +1,134 @@ +--- +title: Apache Software Foundation Parent POM +author: + - Benson Margulies + - Hervé Boutem

Re: [PR] APT to Markdown [maven-apache-parent]

2025-01-08 Thread via GitHub
kwin commented on code in PR #285: URL: https://github.com/apache/maven-apache-parent/pull/285#discussion_r1908279481 ## docs/src/site/markdown/index.md.vm: ## @@ -0,0 +1,134 @@ +--- Review Comment: This PR has two commits for exactly that reason -- This is an automated

[jira] [Commented] (MARTIFACT-80) `ignore` doesn't work on the main module artifact

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911360#comment-17911360 ] ASF GitHub Bot commented on MARTIFACT-80: - facboy commented on code in PR #71:

Re: [PR] [MARTIFACT-80] Apply ignore configuration to main project artifact as well [maven-artifact-plugin]

2025-01-08 Thread via GitHub
facboy commented on code in PR #71: URL: https://github.com/apache/maven-artifact-plugin/pull/71#discussion_r1908308988 ## src/it/compare-ignore/modA/pom.xml: ## @@ -0,0 +1,61 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"

[jira] [Commented] (MARTIFACT-80) `ignore` doesn't work on the main module artifact

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911344#comment-17911344 ] ASF GitHub Bot commented on MARTIFACT-80: - hboutemy commented on code in PR #71

Re: [PR] [MARTIFACT-80] Apply ignore configuration to main project artifact as well [maven-artifact-plugin]

2025-01-08 Thread via GitHub
hboutemy commented on code in PR #71: URL: https://github.com/apache/maven-artifact-plugin/pull/71#discussion_r1908256555 ## src/it/compare-ignore/modA/pom.xml: ## @@ -0,0 +1,61 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instanc

Re: [PR] [MARTIFACT-80] Apply ignore configuration to main project artifact as well [maven-artifact-plugin]

2025-01-08 Thread via GitHub
hboutemy commented on code in PR #71: URL: https://github.com/apache/maven-artifact-plugin/pull/71#discussion_r1908258500 ## src/it/compare-ignore/modA/pom.xml: ## @@ -0,0 +1,61 @@ + + + + +http://maven.apache.org/POM/4.0.0"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instanc

[jira] [Commented] (MARTIFACT-80) `ignore` doesn't work on the main module artifact

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MARTIFACT-80?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911345#comment-17911345 ] ASF GitHub Bot commented on MARTIFACT-80: - hboutemy commented on code in PR #71

[jira] [Updated] (MNG-8502) The "embedded" executor does not obey MAVEN_ARGS env variable

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MNG-8502: - Summary: The "embedded" executor does not obey MAVEN_ARGS env variable (was: The "embeded" executo

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911163#comment-17911163 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907512869 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907523702 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911165#comment-17911165 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MNG-8475] In the loop scenario, StringBuilder is used instead of concatenation [maven]

2025-01-08 Thread via GitHub
cstamas merged PR #2014: URL: https://github.com/apache/maven/pull/2014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911169#comment-17911169 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

[jira] [Closed] (MNG-8475) In the loop scenario, StringBuilder is used instead of concatenation

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8475. Resolution: Fixed > In the loop scenario, StringBuilder is used instead of concatenation > --

[jira] [Assigned] (MNG-8475) In the loop scenario, StringBuilder is used instead of concatenation

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MNG-8475: Assignee: Zhongming Hua > In the loop scenario, StringBuilder is used instead of concatenati

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907535037 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907535037 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

Re: [PR] [MNG-8483] Prefer Objects.nonNull [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2019: URL: https://github.com/apache/maven/pull/2019#issuecomment-2578221517 perso i like it, one nit: i usually static import the method -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911170#comment-17911170 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MNG-8483] Prefer Objects.nonNull [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2019: URL: https://github.com/apache/maven/pull/2019#issuecomment-2578223876 Also title: "Prefer Objects.requireNonNull" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to t

Re: [PR] [MNG-8502] Embedded executor should obey MAVEN_ARGS env variable [maven]

2025-01-08 Thread via GitHub
cstamas merged PR #2032: URL: https://github.com/apache/maven/pull/2032 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.

Re: [PR] [MNG-8494] Restore Maven 3 compatibility [maven]

2025-01-08 Thread via GitHub
elharo commented on code in PR #2031: URL: https://github.com/apache/maven/pull/2031#discussion_r1907411612 ## api/maven-api-toolchain/src/main/mdo/toolchains.mdo: ## @@ -102,6 +102,18 @@ + + + 1.0.0/1.1.0 + +

[jira] [Closed] (MNG-8502) The "embeded" executor does not obey MAVEN_ARGS env variable

2025-01-08 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MNG-8502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak closed MNG-8502. Resolution: Fixed > The "embeded" executor does not obey MAVEN_ARGS env variable > --

Re: [PR] [MENFORCER-511] Match start-tag to end-tag [maven-enforcer]

2025-01-08 Thread via GitHub
elharo merged PR #341: URL: https://github.com/apache/maven-enforcer/pull/341 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.a

[jira] [Commented] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes typo in docs

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911152#comment-17911152 ] ASF GitHub Bot commented on MENFORCER-511: -- elharo merged PR #341: URL: https

[jira] [Closed] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes typo in docs

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold closed MENFORCER-511. --- > RequireUpperBoundDeps: ExcludedScopes typo in docs > ---

[jira] [Resolved] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes typo in docs

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MENFORCER-511. - Resolution: Fixed > RequireUpperBoundDeps: ExcludedScopes typo in docs

[PR] Updated the article resources links [maven-site]

2025-01-08 Thread via GitHub
VISHVA1403 opened a new pull request, #635: URL: https://github.com/apache/maven-site/pull/635 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe,

Re: [I] Update Articles links [maven-site]

2025-01-08 Thread via GitHub
VISHVA1403 commented on issue #631: URL: https://github.com/apache/maven-site/issues/631#issuecomment-2578082540 I have created pull request. Happy to receive feedback and changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Git

Re: [PR] Bump com.diffplug.spotless:spotless-maven-plugin from 2.44.0.BETA4 to 2.44.1 [maven-site]

2025-01-08 Thread via GitHub
elharo merged PR #634: URL: https://github.com/apache/maven-site/pull/634 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

Re: [I] Spotless application broke at least one page [maven-site]

2025-01-08 Thread via GitHub
elharo commented on issue #632: URL: https://github.com/apache/maven-site/issues/632#issuecomment-2578104530 Haven't seen that page before but there are some good things in it (and some bad ones). I suggest merging the good parts into the official FAQ and deleting what remains. -- This

Re: [PR] Bump net.sourceforge.plantuml:plantuml from 1.2024.8 to 1.2025.0 [maven-site]

2025-01-08 Thread via GitHub
elharo merged PR #633: URL: https://github.com/apache/maven-site/pull/633 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apach

Re: [PR] Bump org.apache.maven:maven-archiver from 3.6.1 to 3.6.3 [maven-artifact-plugin]

2025-01-08 Thread via GitHub
slachiewicz commented on PR #69: URL: https://github.com/apache/maven-artifact-plugin/pull/69#issuecomment-2578298651 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

Re: [PR] Just an IT run for PR 2018 [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2033: URL: https://github.com/apache/maven/pull/2033#issuecomment-2578304880 The ITs are NOT part of current reactor (the "maven build") and they are still building projects mostly with Java=8, so those classes and resources should not be modified. -- This is an

[jira] [Created] (MSKINS-264) dark mode?

2025-01-08 Thread Stephen Buergler (Jira)
Stephen Buergler created MSKINS-264: --- Summary: dark mode? Key: MSKINS-264 URL: https://issues.apache.org/jira/browse/MSKINS-264 Project: Maven Skins Issue Type: New Feature Compon

[jira] [Commented] (MCOMPILER-529) Improve the docs about usage 1.8 vs. 8 for source/target

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MCOMPILER-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911192#comment-17911192 ] ASF GitHub Bot commented on MCOMPILER-529: -- slachiewicz commented on PR #245:

Re: [PR] [MCOMPILER-529] information that it's possible to use "8" as source/target [maven-compiler-plugin]

2025-01-08 Thread via GitHub
slachiewicz commented on PR #245: URL: https://github.com/apache/maven-compiler-plugin/pull/245#issuecomment-2578317952 It's possible to set .release property not only for Java 9+ but also do or Java 8. Plugin will skip passing this parameter to compiler for Java 8 -- This is an automat

[jira] [Commented] (MNG-8485) Finish experiments and commit

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911068#comment-17911068 ] Elliotte Rusty Harold commented on MNG-8485: Former employees of a certain larg

[jira] [Assigned] (MENFORCER-473) Custom Rules are not processed with Java 17

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MENFORCER-473: --- Assignee: (was: Elliotte Rusty Harold) > Custom Rules are not

[jira] [Updated] (MENFORCER-473) Custom Rules are not processed with Java 17

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MENFORCER-473: Priority: Trivial (was: Major) > Custom Rules are not processed with Ja

[jira] [Updated] (MENFORCER-473) Custom Rules are not processed with Java 17

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MENFORCER-473: Priority: Major (was: Trivial) > Custom Rules are not processed with Ja

[jira] [Updated] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes does not work

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MENFORCER-511: Priority: Trivial (was: Major) > RequireUpperBoundDeps: ExcludedScopes

[jira] [Updated] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes typo in docs

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold updated MENFORCER-511: Summary: RequireUpperBoundDeps: ExcludedScopes typo in docs (was: Requi

[jira] [Assigned] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes does not work

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MENFORCER-511: --- Assignee: Elliotte Rusty Harold > RequireUpperBoundDeps: Excluded

[jira] [Assigned] (MENFORCER-473) Custom Rules are not processed with Java 17

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-473?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MENFORCER-473: --- Assignee: Elliotte Rusty Harold > Custom Rules are not processed

[jira] [Commented] (MENFORCER-506) Move EnforceBytecodeVersion rule from extra-rules

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911106#comment-17911106 ] Elliotte Rusty Harold commented on MENFORCER-506: - Who owns extra-enfo

[jira] [Comment Edited] (MENFORCER-506) Move EnforceBytecodeVersion rule from extra-rules

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911106#comment-17911106 ] Elliotte Rusty Harold edited comment on MENFORCER-506 at 1/8/25 2:22 PM: ---

[jira] [Commented] (MNGSITE-521) Define dependency type

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911108#comment-17911108 ] Elliotte Rusty Harold commented on MNGSITE-521: --- Thanks. I think I'm start

[jira] [Assigned] (MNGSITE-521) Define dependency type

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNGSITE-521?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold reassigned MNGSITE-521: - Assignee: Elliotte Rusty Harold > Define dependency type >

[jira] [Commented] (MNG-8485) Finish experiments and commit

2025-01-08 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1797#comment-1797 ] Guillaume Nodet commented on MNG-8485: -- {quote}There are two APIs: the deprecated one

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
elharo commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907220052 ## src/test/java/org/apache/maven/shared/dependency/graph/internal/DefaultDependencyNodeTest.java: ## @@ -42,4 +42,12 @@ public void nodeString_for_mandatory

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911091#comment-17911091 ] ASF GitHub Bot commented on MSHARED-1454: - elharo commented on code in PR #50:

[jira] [Commented] (MENFORCER-390) "requireFilesExist" no longer handles non-canonical paths

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911098#comment-17911098 ] ASF GitHub Bot commented on MENFORCER-390: -- elharo commented on code in PR #2

Re: [PR] [MHG-8471] Prefer Objects.nonNull [maven]

2025-01-08 Thread via GitHub
gnodet commented on PR #2019: URL: https://github.com/apache/maven/pull/2019#issuecomment-2577918295 `MHG-8471` ? [`MNG-8471](https://issues.apache.org/jira/browse/MNG-8471) looks unrelated to me -- This is an automated message from the Apache Git Service. To respond to the message, pl

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911166#comment-17911166 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907523702 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

[PR] Remove unused method [maven-install-plugin]

2025-01-08 Thread via GitHub
pzygielo opened a new pull request, #97: URL: https://github.com/apache/maven-install-plugin/pull/97 - left in #81 - [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2

Re: [PR] Remove unused method [maven-install-plugin]

2025-01-08 Thread via GitHub
pzygielo commented on PR #97: URL: https://github.com/apache/maven-install-plugin/pull/97#issuecomment-2578359390 It's even listed here: https://maven.apache.org/plugins/maven-install-plugin/pmd.html ![image](https://github.com/user-attachments/assets/1fd02526-5996-4cb7-b391-f0cf9b0

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#issuecomment-2577691847 Have you had time to look at the comments above? Is it still unclear? -- This is an automated message from the Apache Git Service. To respond to the message, please log on t

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911086#comment-17911086 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on PR #50: URL:

Re: [PR] [EXPERIMENT] Make CI use split repo [maven]

2025-01-08 Thread via GitHub
cstamas closed pull request #2030: [EXPERIMENT] Make CI use split repo URL: https://github.com/apache/maven/pull/2030 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubsc

[jira] [Commented] (MENFORCER-511) RequireUpperBoundDeps: ExcludedScopes typo in docs

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911096#comment-17911096 ] ASF GitHub Bot commented on MENFORCER-511: -- elharo opened a new pull request,

[jira] [Resolved] (MENFORCER-499) New Rule: Prohibit specific files to be checked in

2025-01-08 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MENFORCER-499?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Elliotte Rusty Harold resolved MENFORCER-499. - Resolution: Won't Do This doesn't seem to be common enough a need to j

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907320106 ## src/test/java/org/apache/maven/shared/dependency/graph/internal/DefaultDependencyNodeTest.java: ## @@ -42,4 +42,12 @@ public void nodeString_for_mandat

[jira] [Created] (MNG-8503) Configure logging using maven.logging.* properties rather than org.slf4j.simpleLogger.*

2025-01-08 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MNG-8503: Summary: Configure logging using maven.logging.* properties rather than org.slf4j.simpleLogger.* Key: MNG-8503 URL: https://issues.apache.org/jira/browse/MNG-8503 Pro

Re: [PR] [MNG-8483] Prefer Objects.nonNull [maven]

2025-01-08 Thread via GitHub
elharo commented on PR #2019: URL: https://github.com/apache/maven/pull/2019#issuecomment-2577992616 yep, should be MNG-8483 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

Re: [PR] [MNG-8494] Restore Maven 3 compatibility [maven]

2025-01-08 Thread via GitHub
gnodet commented on code in PR #2031: URL: https://github.com/apache/maven/pull/2031#discussion_r1907552641 ## compat/maven-embedder/src/main/java/org/apache/maven/cli/transfer/AbstractMavenTransferListener.java: ## @@ -33,31 +34,177 @@ */ @Deprecated public abstract class A

Re: [PR] [MNG-8494] Restore Maven 3 compatibility [maven]

2025-01-08 Thread via GitHub
gnodet commented on PR #2031: URL: https://github.com/apache/maven/pull/2031#issuecomment-2578233432 99% of the code here is copy/pasted from maven-3.9.x branch to restore compatibility... so I'm fine with any change you suggest, but I really don't expect you to closely review all the chang

Re: [PR] [MSHARED-1454] Expose ConflictData on DependencyNode [maven-dependency-tree]

2025-01-08 Thread via GitHub
LogFlames commented on code in PR #50: URL: https://github.com/apache/maven-dependency-tree/pull/50#discussion_r1907487620 ## src/main/java/org/apache/maven/shared/dependency/graph/ConflictData.java: ## @@ -32,31 +32,70 @@ public class ConflictData { private Boolean orig

[jira] [Commented] (MSHARED-1454) Conflict Data on VerboseDependencyNode is hidden

2025-01-08 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17911161#comment-17911161 ] ASF GitHub Bot commented on MSHARED-1454: - LogFlames commented on code in PR #5

Re: [PR] [MNG-8494] Restore Maven 3 compatibility [maven]

2025-01-08 Thread via GitHub
cstamas commented on PR #2031: URL: https://github.com/apache/maven/pull/2031#issuecomment-2578270193 These are literally copies of Maven 3 classes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

  1   2   >