Re: [PR] [MSHADE-467] Fix concurrency problem with dependency-reduced POM [maven-shade-plugin]

2024-01-22 Thread via GitHub
fmarot commented on PR #210: URL: https://github.com/apache/maven-shade-plugin/pull/210#issuecomment-1903451284 Big big thank you for your work @kriegaex 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MSHADE-467) Dependency-reduced POM with missing exclusions in concurrent build

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809287#comment-17809287 ] ASF GitHub Bot commented on MSHADE-467: --- fmarot commented on PR #210: URL: https:/

Re: [PR] [MSHADE-467] Fix concurrency problem with dependency-reduced POM [maven-shade-plugin]

2024-01-22 Thread via GitHub
kriegaex commented on PR #210: URL: https://github.com/apache/maven-shade-plugin/pull/210#issuecomment-1903549966 @rmannibucau, any idea why the build passed for the whole matrix on my fork, but here is failed due to locked files on Windows? -- This is an automated message from the Apach

[jira] [Commented] (MSHADE-467) Dependency-reduced POM with missing exclusions in concurrent build

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809315#comment-17809315 ] ASF GitHub Bot commented on MSHADE-467: --- kriegaex commented on PR #210: URL: https

Re: [PR] [MSHADE-467] Fix concurrency problem with dependency-reduced POM [maven-shade-plugin]

2024-01-22 Thread via GitHub
kriegaex commented on PR #210: URL: https://github.com/apache/maven-shade-plugin/pull/210#issuecomment-1903588421 I do not think it is pure chance that it happens in the new IT. Maybe, in some other part of Maven, at least in some versions, there are other concurrency issues we are hitting

[jira] [Commented] (MSHADE-467) Dependency-reduced POM with missing exclusions in concurrent build

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809323#comment-17809323 ] ASF GitHub Bot commented on MSHADE-467: --- kriegaex commented on PR #210: URL: https

[jira] [Commented] (MSHADE-466) Missing exclusions

2024-01-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809337#comment-17809337 ] Michael Osipov commented on MSHADE-466: --- Has this one been created by mistake? > M

[jira] [Commented] (MSHADE-466) Missing exclusions

2024-01-22 Thread Alexander Kriegisch (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809350#comment-17809350 ] Alexander Kriegisch commented on MSHADE-466: [~michael-o], yes. I did not eve

[jira] [Deleted] (MSHADE-466) Missing exclusions

2024-01-22 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov deleted MSHADE-466: -- > Missing exclusions > -- > > Key: MSHADE-466 > UR

Re: [PR] [MSHARED-1175] Copying x resources from rel/path to rel/path [maven-filtering]

2024-01-22 Thread via GitHub
atastrumf commented on PR #62: URL: https://github.com/apache/maven-filtering/pull/62#issuecomment-1903752243 Hi @hboutemy, I know it has been a while since this was integrated and maybe my setup is wrong, but this change doesn't really seem to fit all use cases. (It's still better tha

[jira] [Commented] (MSHARED-1175) describe from and to in "Copying x resources" info message

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809369#comment-17809369 ] ASF GitHub Bot commented on MSHARED-1175: - atastrumf commented on PR #62: URL:

Re: [PR] [MSHADE-467] Fix concurrency problem with dependency-reduced POM [maven-shade-plugin]

2024-01-22 Thread via GitHub
rmannibucau merged PR #210: URL: https://github.com/apache/maven-shade-plugin/pull/210 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr..

[jira] [Commented] (MSHADE-467) Dependency-reduced POM with missing exclusions in concurrent build

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809413#comment-17809413 ] ASF GitHub Bot commented on MSHADE-467: --- rmannibucau merged PR #210: URL: https://g

[jira] [Commented] (MSHADE-467) Dependency-reduced POM with missing exclusions in concurrent build

2024-01-22 Thread Romain Manni-Bucau (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809416#comment-17809416 ] Romain Manni-Bucau commented on MSHADE-467: --- Fixed for 3.5.2 but I don't have J

Re: [PR] [MSHARED-1175] Copying x resources from rel/path to rel/path [maven-filtering]

2024-01-22 Thread via GitHub
hboutemy commented on PR #62: URL: https://github.com/apache/maven-filtering/pull/62#issuecomment-1904229766 @atastrumf there is no configuration available please open a separate Jira issue and provide a sample project -- This is an automated message from the Apache Git Service. To resp

[jira] [Commented] (MSHARED-1175) describe from and to in "Copying x resources" info message

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHARED-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809503#comment-17809503 ] ASF GitHub Bot commented on MSHARED-1175: - hboutemy commented on PR #62: URL: h

Re: [PR] [MPOM-265] Remove no longer used ".maven-apache-parent.marker" file [maven-apache-parent]

2024-01-22 Thread via GitHub
kwin merged PR #189: URL: https://github.com/apache/maven-apache-parent/pull/189 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] Document how to build site [maven-apache-parent]

2024-01-22 Thread via GitHub
kwin merged PR #190: URL: https://github.com/apache/maven-apache-parent/pull/190 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave

Re: [PR] [MNG-8024] Make WrapperProperties and WrapperList serizalizable. [maven]

2024-01-22 Thread via GitHub
gnodet commented on PR #1388: URL: https://github.com/apache/maven/pull/1388#issuecomment-1904273419 We need to extend the unit test https://github.com/apache/maven/blob/master/maven-model/src/test/java/org/apache/maven/model/SerializationTest.java to exercise the actual problem.

[jira] [Commented] (MNG-8024) Maven4 models are not serializable, despite marked as such

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809518#comment-17809518 ] ASF GitHub Bot commented on MNG-8024: - gnodet commented on PR #1388: URL: https://githu

Re: [PR] [MNG-8024] Make WrapperProperties and WrapperList serizalizable. [maven]

2024-01-22 Thread via GitHub
gnodet commented on code in PR #1388: URL: https://github.com/apache/maven/pull/1388#discussion_r1462051148 ## src/mdo/java/WrapperList.java: ## @@ -27,16 +27,21 @@ import java.util.function.Supplier; class WrapperList extends AbstractList { Review Comment: What's the po

[jira] [Commented] (MNG-8024) Maven4 models are not serializable, despite marked as such

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809522#comment-17809522 ] ASF GitHub Bot commented on MNG-8024: - gnodet commented on code in PR #1388: URL: https

[jira] [Commented] (MRESOLVER-467) Pull out Remote Included checksum support

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809528#comment-17809528 ] ASF GitHub Bot commented on MRESOLVER-467: -- cstamas opened a new pull request

[jira] [Assigned] (MRESOLVER-467) Pull out Remote Included checksum support

2024-01-22 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-467: - Assignee: Tamas Cservenak > Pull out Remote Included checksum support > -

[jira] [Updated] (MRESOLVER-467) Pull out shared HTTP (Remote Included checksum) code

2024-01-22 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-467: -- Description: The logic for them is basically duplicated (triplicated) in all HTTP tr

[jira] [Updated] (MRESOLVER-467) Pull out shared HTTP (Remote Included checksum) code

2024-01-22 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-467?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-467: -- Summary: Pull out shared HTTP (Remote Included checksum) code (was: Pull out Remote

[jira] [Created] (MRESOLVER-468) Stabilize supplier binary and source compatibility

2024-01-22 Thread Tamas Cservenak (Jira)
Tamas Cservenak created MRESOLVER-468: - Summary: Stabilize supplier binary and source compatibility Key: MRESOLVER-468 URL: https://issues.apache.org/jira/browse/MRESOLVER-468 Project: Maven Resolv

Re: [PR] [MNG-8024] Make WrapperProperties and WrapperList serizalizable. [maven]

2024-01-22 Thread via GitHub
gnodet commented on PR #1388: URL: https://github.com/apache/maven/pull/1388#issuecomment-1904473390 > We need a clear unit test. Basic serialisation is already supported, so something's wrong... The `WrapperList` and `WrapperProperties` should not actually be used during serialisation, as

Re: [PR] [MNG-8014] Fix multithreaded builder [maven]

2024-01-22 Thread via GitHub
gnodet merged PR #1386: URL: https://github.com/apache/maven/pull/1386 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.o

[jira] [Commented] (MNG-8014) Maven concurrent model builder deadlocks

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809581#comment-17809581 ] ASF GitHub Bot commented on MNG-8014: - gnodet merged PR #1386: URL: https://github.com/

[jira] [Commented] (MNG-8024) Maven4 models are not serializable, despite marked as such

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-8024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809580#comment-17809580 ] ASF GitHub Bot commented on MNG-8024: - gnodet commented on PR #1388: URL: https://githu

[jira] [Closed] (MNG-8014) Maven concurrent model builder deadlocks

2024-01-22 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MNG-8014?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet closed MNG-8014. Fix Version/s: 4.0.0 4.0.0-alpha-13 Assignee: Guillaume Nodet Resol

[jira] [Assigned] (MRESOLVER-468) Stabilize supplier binary and source compatibility

2024-01-22 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak reassigned MRESOLVER-468: - Assignee: Tamas Cservenak > Stabilize supplier binary and source compatibilit

[jira] [Updated] (MRESOLVER-468) Stabilize supplier binary and source compatibility

2024-01-22 Thread Tamas Cservenak (Jira)
[ https://issues.apache.org/jira/browse/MRESOLVER-468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Cservenak updated MRESOLVER-468: -- Description: Currently (in 1.x of resolver) supplier has incompatible changes. This

Re: [PR] [MSHADE-420] create IT: 2 runs with different TZ give different jars [maven-shade-plugin]

2024-01-22 Thread via GitHub
michael-o commented on code in PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1462324017 ## src/it/projects/MSHADE-420/invoker.properties: ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor l

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809618#comment-17809618 ] ASF GitHub Bot commented on MSHADE-420: --- michael-o commented on code in PR #179: UR

[jira] [Created] (MPLUGIN-507) NPE during plugin run to generate mojo descriptor / worked in versions before 3.11.0

2024-01-22 Thread Philipp Ottlinger (Jira)
Philipp Ottlinger created MPLUGIN-507: - Summary: NPE during plugin run to generate mojo descriptor / worked in versions before 3.11.0 Key: MPLUGIN-507 URL: https://issues.apache.org/jira/browse/MPLUGIN-507

[jira] [Updated] (MPLUGIN-507) NPE during plugin run in Creadur RAT to generate mojo descriptor / worked in versions before 3.11.0

2024-01-22 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Philipp Ottlinger updated MPLUGIN-507: -- Summary: NPE during plugin run in Creadur RAT to generate mojo descriptor / worked in

[jira] [Commented] (MPLUGIN-507) NPE during plugin run to generate mojo descriptor / worked in versions before 3.11.0

2024-01-22 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809631#comment-17809631 ] Philipp Ottlinger commented on MPLUGIN-507: --- I pushed a branch that fails with

[jira] [Created] (MPLUGIN-508) Upgrade to Maven 4.0.0-alpha-12

2024-01-22 Thread Guillaume Nodet (Jira)
Guillaume Nodet created MPLUGIN-508: --- Summary: Upgrade to Maven 4.0.0-alpha-12 Key: MPLUGIN-508 URL: https://issues.apache.org/jira/browse/MPLUGIN-508 Project: Maven Plugin Tools Issue Type

[jira] [Updated] (MPLUGIN-508) Upgrade to Maven 4.0.0-alpha-12

2024-01-22 Thread Guillaume Nodet (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-508?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Guillaume Nodet updated MPLUGIN-508: Fix Version/s: 3.12.0 (was: 3.11.0) > Upgrade to Maven 4.0.0-alpha-

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

2024-01-22 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809653#comment-17809653 ] Benjamin Marwell commented on MJLINK-75: Sadly, I do not see an option for this in

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

2024-01-22 Thread Piotr Karwasz (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809656#comment-17809656 ] Piotr Karwasz commented on MJLINK-75: - [~bmarwell] , The {{lib/modules}} file generat

[jira] [Commented] (MPLUGIN-507) NPE during plugin run in Creadur RAT to generate mojo descriptor / worked in versions before 3.11.0

2024-01-22 Thread Philipp Ottlinger (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-507?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809685#comment-17809685 ] Philipp Ottlinger commented on MPLUGIN-507: --- I do not really know if the probl

Re: [PR] [MPOM-456] Bump surefire/failsafe from 3.2.2 to 3.2.5 [maven-apache-parent]

2024-01-22 Thread via GitHub
ctubbsii commented on PR #179: URL: https://github.com/apache/maven-apache-parent/pull/179#issuecomment-1905059071 Resolved conflicts. Somebody with write permission should really merge this so it doesn't keep drifting. -- This is an automated message from the Apache Git Service. To resp

Re: [PR] [MPLUGIN-506] Translation between V3 and V4 Mojo API [maven-plugin-tools]

2024-01-22 Thread via GitHub
cstamas closed pull request #257: [MPLUGIN-506] Translation between V3 and V4 Mojo API URL: https://github.com/apache/maven-plugin-tools/pull/257 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Commented] (MPLUGIN-506) Trasnlation required between V3 and V4 Mojo annotations

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MPLUGIN-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809687#comment-17809687 ] ASF GitHub Bot commented on MPLUGIN-506: cstamas closed pull request #257: [MPLU

Re: [PR] [MPOM-451] Remove repository elements from Apache Parent [maven-apache-parent]

2024-01-22 Thread via GitHub
ctubbsii commented on PR #183: URL: https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1905091600 > > Local builds are affected > > Not sure how. Usually local builds are either multi-module or 'installed' and do not use snapshot repository anyway. This isn't

Re: [PR] Bump version.maven-plugin-tools from 3.10.2 to 3.11.0 [maven-apache-parent]

2024-01-22 Thread via GitHub
ctubbsii commented on PR #187: URL: https://github.com/apache/maven-apache-parent/pull/187#issuecomment-1905097070 The bot keeps doing this. It did the same thing for the surefire/failsafe property. It seems to be capable of only going one level deep on the property interpolation. That's s

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809722#comment-17809722 ] ASF GitHub Bot commented on MJLINK-75: -- hboutemy opened a new pull request, #190: URL

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

2024-01-22 Thread Herve Boutemy (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809723#comment-17809723 ] Herve Boutemy commented on MJLINK-75: - PR created https://github.com/apache/maven-jlin

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809746#comment-17809746 ] ASF GitHub Bot commented on MSHADE-420: --- hboutemy commented on code in PR #179: URL

Re: [PR] [MSHADE-420] create IT: 2 runs with different TZ give different jars [maven-shade-plugin]

2024-01-22 Thread via GitHub
hboutemy commented on code in PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1462753156 ## src/it/projects/MSHADE-420/invoker.properties: ## @@ -0,0 +1,25 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor li

Re: [PR] [MSHADE-420] create IT: 2 runs with different TZ give different jars [maven-shade-plugin]

2024-01-22 Thread via GitHub
hboutemy commented on code in PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1462753899 ## src/it/projects/MSHADE-420/verify.groovy: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor l

Re: [PR] [MSHADE-420] create IT: 2 runs with different TZ give different jars [maven-shade-plugin]

2024-01-22 Thread via GitHub
hboutemy commented on code in PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1462754283 ## src/it/projects/MSHADE-420/verify.groovy: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor l

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809747#comment-17809747 ] ASF GitHub Bot commented on MSHADE-420: --- hboutemy commented on code in PR #179: URL

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809748#comment-17809748 ] ASF GitHub Bot commented on MSHADE-420: --- hboutemy commented on code in PR #179: URL

Re: [PR] [MSHADE-420] create IT: 2 runs with different TZ give different jars [maven-shade-plugin]

2024-01-22 Thread via GitHub
hboutemy commented on code in PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1462753899 ## src/it/projects/MSHADE-420/verify.groovy: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor l

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809749#comment-17809749 ] ASF GitHub Bot commented on MSHADE-420: --- hboutemy commented on code in PR #179: URL

[jira] [Commented] (MSHADE-420) Reproducible Builds timestamp issue in some cases

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809751#comment-17809751 ] ASF GitHub Bot commented on MSHADE-420: --- hboutemy commented on code in PR #179: URL

Re: [PR] [MSHADE-420] create IT: 2 runs with different TZ give different jars [maven-shade-plugin]

2024-01-22 Thread via GitHub
hboutemy commented on code in PR #179: URL: https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1462754573 ## src/it/projects/MSHADE-420/verify.groovy: ## @@ -0,0 +1,59 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor l

[jira] [Assigned] (MJLINK-75) Reproducibility of ZIP artifacts

2024-01-22 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Benjamin Marwell reassigned MJLINK-75: -- Assignee: Herve Boutemy > Reproducibility of ZIP artifacts > --

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

2024-01-22 Thread Benjamin Marwell (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809779#comment-17809779 ] Benjamin Marwell commented on MJLINK-75: Hi, thanks for the clarification. In my m

Re: [PR] [MJLINK-75] create reproducible zip archive [maven-jlink-plugin]

2024-01-22 Thread via GitHub
bmarwell commented on code in PR #190: URL: https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1462839170 ## src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java: ## @@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File outputDirectory, File ou

[jira] [Commented] (MJLINK-75) Reproducibility of ZIP artifacts

2024-01-22 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MJLINK-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809782#comment-17809782 ] ASF GitHub Bot commented on MJLINK-75: -- bmarwell commented on code in PR #190: URL: