[
https://issues.apache.org/jira/browse/MSHADE-420?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17809747#comment-17809747
]
ASF GitHub Bot commented on MSHADE-420:
---------------------------------------
hboutemy commented on code in PR #179:
URL:
https://github.com/apache/maven-shade-plugin/pull/179#discussion_r1462753899
##########
src/it/projects/MSHADE-420/verify.groovy:
##########
@@ -0,0 +1,59 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import java.security.MessageDigest
+import java.util.jar.JarFile
+
+String describeEntry(JarFile jar, String name, long time) {
+ def entry = jar.getEntry(name)
+ return String.format(" - %-47s: time = ", name) + entry.getTime() + ",
lastModified = " + entry.getLastModifiedTime()\
Review Comment:
tested with more recent JDK and the output was ok :)
going to a simple boolean, which is what really this display is about (not
really value details)
> Reproducible Builds timestamp issue in some cases
> -------------------------------------------------
>
> Key: MSHADE-420
> URL: https://issues.apache.org/jira/browse/MSHADE-420
> Project: Maven Shade Plugin
> Issue Type: Bug
> Affects Versions: 3.2.4
> Reporter: Herve Boutemy
> Priority: Major
>
> seen in Tika
> https://github.com/jvm-repo-rebuild/reproducible-central/blob/master/content/org/apache/tika/tika-2.4.0.diffoscope
> maven-shade-plugin 3.2.4 has an issue with timestamps in unexplained
> circumstances:
> why does 21-Nov-20 20:25 from reference become 21-Nov-21 01:25 in rebuild?
> why does 20-May-14 07:15 from reference become 20-May-14 11:15 in rebuild?
> could be related to the timezone of the rebuilder?
> {noformat}
> 21 / 44 target/reference/tika-parser-nlp-package-2.4.0.jar
> tika-parsers/tika-parsers-ml/tika-parser-nlp-package/target/tika-parser-nlp-package-2.4.0.jar
> --- target/reference/tika-parser-nlp-package-2.4.0.jar
> +++
> tika-parsers/tika-parsers-ml/tika-parser-nlp-package/target/tika-parser-nlp-package-2.4.0.jar
> ├── zipinfo {}
> │ @@ -9868,1231 +9868,1231 @@
> │ -rw---- 2.0 fat 932 bl defN 22-Apr-08 17:41 schemas/wsdl/xmime.xsd
> │ -rw---- 2.0 fat 5840 bl defN 22-Apr-08 17:41 schemas/wsdl/xml.xsd
> │ --rw---- 2.0 fat 0 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/
> │ --rw---- 2.0 fat 0 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/
> │ --rw---- 2.0 fat 70 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.properties
> │ --rw---- 2.0 fat 15917 bl defN 21-Nov-20 20:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.xml
> ...
> │ --rw---- 2.0 fat 722 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidationSchema.class
> │ --rw---- 2.0 fat 7795 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidationSchemaFactory.class
> │ --rw---- 2.0 fat 1801 bl defN 20-May-14 07:15
> org/codehaus/stax2/validation/XMLValidator.class
> │ +-rw---- 2.0 fat 0 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/
> │ +-rw---- 2.0 fat 0 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/
> │ +-rw---- 2.0 fat 70 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.properties
> │ +-rw---- 2.0 fat 15917 bl defN 21-Nov-21 01:25
> META-INF/maven/com.fasterxml.woodstox/woodstox-core/pom.xml
> ...
> │ +-rw---- 2.0 fat 722 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidationSchema.class
> │ +-rw---- 2.0 fat 7795 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidationSchemaFactory.class
> │ +-rw---- 2.0 fat 1801 bl defN 20-May-14 11:15
> org/codehaus/stax2/validation/XMLValidator.class
> │ -rw---- 2.0 fat 0 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/
> │ -rw---- 2.0 fat 0 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/
> │ -rw---- 2.0 fat 146 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/pom.properties
> │ -rw---- 2.0 fat 6857 bl defN 21-Sep-14 14:41
> META-INF/maven/org.apache.ws.xmlschema/xmlschema-core/pom.xml
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
