bmarwell commented on code in PR #190:
URL:
https://github.com/apache/maven-jlink-plugin/pull/190#discussion_r1462839170
##########
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##########
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File
outputDirectory, File outputDirector
throws MojoExecutionException {
zipArchiver.addDirectory(outputDirectoryImage);
+ // configure for Reproducible Builds based on outputTimestamp value
+ Date lastModified = new
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+ if (lastModified != null) {
+ zipArchiver.configureReproducible(lastModified);
+ }
Review Comment:
Why is the null check needed here, but not in
https://github.com/apache/maven-rar-plugin/commit/6ea9c738f089930b5f27b4e7796808412b1886b0/
?
##########
src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java:
##########
@@ -510,6 +522,12 @@ private File createZipArchiveFromImage(File
outputDirectory, File outputDirector
throws MojoExecutionException {
zipArchiver.addDirectory(outputDirectoryImage);
+ // configure for Reproducible Builds based on outputTimestamp value
+ Date lastModified = new
MavenArchiver().parseOutputTimestamp(outputTimestamp);
+ if (lastModified != null) {
Review Comment:
Do we also want to add a line similar to this one?
https://github.com/apache/maven-rar-plugin/commit/6ea9c738f089930b5f27b4e7796808412b1886b0/#diff-bb425c248269250f8709b3657272fc04a50a12d316ceb241c1fa64a2c19f9cadR382
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
