[GitHub] [maven-build-cache-extension] kbuntrock commented on a diff in pull request #98: Avoid hash calculation when is true

2023-08-31 Thread via GitHub
kbuntrock commented on code in PR #98: URL: https://github.com/apache/maven-build-cache-extension/pull/98#discussion_r1311199705 ## src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java: ## @@ -139,7 +139,7 @@ public void execute( }

[jira] [Created] (MSITE-977) Links to default-site.vm broken in "Creating skins"

2023-08-31 Thread Konrad Windszus (Jira)
Konrad Windszus created MSITE-977: - Summary: Links to default-site.vm broken in "Creating skins" Key: MSITE-977 URL: https://issues.apache.org/jira/browse/MSITE-977 Project: Maven Site Plugin

[jira] [Commented] (DOXIASITETOOLS-270) Remove internal (pseudo) skin and use Maven Fluido Skin by default

2023-08-31 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/DOXIASITETOOLS-270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760865#comment-17760865 ] Konrad Windszus commented on DOXIASITETOOLS-270: I think this som

[jira] [Commented] (MSITE-977) Links to default-site.vm broken in "Creating skins"

2023-08-31 Thread Konrad Windszus (Jira)
[ https://issues.apache.org/jira/browse/MSITE-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760867#comment-17760867 ] Konrad Windszus commented on MSITE-977: --- [~michaelo] Do we consider https://github.

[jira] [Commented] (MNG-7863) Don't spam rishi

2023-08-31 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760878#comment-17760878 ] Elliotte Rusty Harold commented on MNG-7863: Interesting. I had no idea anyone

[jira] [Comment Edited] (MNG-7863) Don't spam rishi

2023-08-31 Thread Elliotte Rusty Harold (Jira)
[ https://issues.apache.org/jira/browse/MNG-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760878#comment-17760878 ] Elliotte Rusty Harold edited comment on MNG-7863 at 8/31/23 11:36 AM: ---

[GitHub] [maven] elharo commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-31 Thread via GitHub
elharo commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1311520008 ## maven-core/src/main/java/org/apache/maven/utils/dag/DAG.java: ## @@ -0,0 +1,240 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contri

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760893#comment-17760893 ] ASF GitHub Bot commented on MNG-7820: - elharo commented on code in PR #1208: URL: https

[GitHub] [maven-build-cache-extension] eltsovalex commented on a diff in pull request #98: Avoid hash calculation when is true

2023-08-31 Thread via GitHub
eltsovalex commented on code in PR #98: URL: https://github.com/apache/maven-build-cache-extension/pull/98#discussion_r1311538108 ## src/main/java/org/apache/maven/buildcache/BuildCacheMojosExecutionStrategy.java: ## @@ -139,7 +139,7 @@ public void execute( }

[GitHub] [maven] kun-lu20 commented on pull request #1218: [MNG-7863] don't email on s390 failures. The regular results are enough.

2023-08-31 Thread via GitHub
kun-lu20 commented on PR #1218: URL: https://github.com/apache/maven/pull/1218#issuecomment-1701007745 Thanks @olamy ! Yes, we did this on purpose, so that our team (Linux on IBM Z Open Source Team) can get notified of the pipeline status in time. -- This is an automated message fr

[jira] [Commented] (MNG-7863) Don't spam rishi

2023-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760921#comment-17760921 ] ASF GitHub Bot commented on MNG-7863: - kun-lu20 commented on PR #1218: URL: https://git

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-31 Thread via GitHub
AlexanderAshitkin commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1311038794 ## src/main/java/org/apache/maven/buildcache/checksum/MavenProjectInput.java: ## @@ -165,45 +184,94 @@ public MavenProjectInput( thi

[jira] [Commented] (MBUILDCACHE-64) Apply global exclusions to folder names

2023-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760935#comment-17760935 ] ASF GitHub Bot commented on MBUILDCACHE-64: --- AlexanderAshitkin commented on

[GitHub] [maven-surefire] sabi0 opened a new pull request, #671: Fix TestNG web site URL

2023-08-31 Thread via GitHub
sabi0 opened a new pull request, #671: URL: https://github.com/apache/maven-surefire/pull/671 http://www.testng.org does not work anymore. Changed to https://testng.org To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-31 Thread via GitHub
AlexanderAshitkin commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1311669985 ## src/main/java/org/apache/maven/buildcache/checksum/TreeWalkerPathMatcher.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MBUILDCACHE-64) Apply global exclusions to folder names

2023-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760947#comment-17760947 ] ASF GitHub Bot commented on MBUILDCACHE-64: --- AlexanderAshitkin commented on

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-31 Thread via GitHub
AlexanderAshitkin commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1311669985 ## src/main/java/org/apache/maven/buildcache/checksum/TreeWalkerPathMatcher.java: ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software

[jira] [Commented] (MBUILDCACHE-64) Apply global exclusions to folder names

2023-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MBUILDCACHE-64?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760948#comment-17760948 ] ASF GitHub Bot commented on MBUILDCACHE-64: --- AlexanderAshitkin commented on

[jira] [Created] (MNG-7866) Improvements to the logging API usage (technical debt)

2023-08-31 Thread sebastien (Jira)
sebastien created MNG-7866: -- Summary: Improvements to the logging API usage (technical debt) Key: MNG-7866 URL: https://issues.apache.org/jira/browse/MNG-7866 Project: Maven Issue Type: Improvement

[jira] [Commented] (MNG-7866) Improvements to the logging API usage (technical debt)

2023-08-31 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760958#comment-17760958 ] Michael Osipov commented on MNG-7866: - This stretches across the entire code base... >

[jira] [Commented] (MNG-7866) Improvements to the logging API usage (technical debt)

2023-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760961#comment-17760961 ] ASF GitHub Bot commented on MNG-7866: - sebastien-doyon opened a new pull request, #1220

[jira] [Commented] (MNG-7866) Improvements to the logging API usage (technical debt)

2023-08-31 Thread sebastien (Jira)
[ https://issues.apache.org/jira/browse/MNG-7866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760965#comment-17760965 ] sebastien commented on MNG-7866: [~michael-o] I have made a pr to improve the situation >

[GitHub] [maven] gnodet commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-31 Thread via GitHub
gnodet commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1311737481 ## maven-core/src/main/java/org/apache/maven/utils/dag/Vertex.java: ## @@ -0,0 +1,151 @@ +/* Review Comment: We can keep the codehaus header below the package I think.

[jira] [Commented] (MNG-7820) Remove dependency on plexus-utils

2023-08-31 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/MNG-7820?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17760984#comment-17760984 ] ASF GitHub Bot commented on MNG-7820: - gnodet commented on code in PR #1208: URL: https

[jira] [Created] (MSCMPUB-60) publishing site to git on windows fails with command too long

2023-08-31 Thread Adrian Herscu (Jira)
Adrian Herscu created MSCMPUB-60: Summary: publishing site to git on windows fails with command too long Key: MSCMPUB-60 URL: https://issues.apache.org/jira/browse/MSCMPUB-60 Project: Maven SCM Publi

[GitHub] [maven-mvnd] khmarbaise commented on pull request #882: Removed superfluous public for tests

2023-08-31 Thread via GitHub
khmarbaise commented on PR #882: URL: https://github.com/apache/maven-mvnd/pull/882#issuecomment-1701497839 @gnodet ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (MSCMPUB-60) publishing site to git on windows fails with command too long

2023-08-31 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSCMPUB-60?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761067#comment-17761067 ] Michael Osipov commented on MSCMPUB-60: --- I had this one once as well. The actual is

[jira] [Commented] (MSITE-977) Links to default-site.vm broken in "Creating skins"

2023-08-31 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MSITE-977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17761068#comment-17761068 ] Michael Osipov commented on MSITE-977: -- I would say no because it is too complex for

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-31 Thread via GitHub
AlexanderAshitkin commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1312155125 ## src/test/projects/include-exclude/pom.xml: ## @@ -0,0 +1,51 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-31 Thread via GitHub
AlexanderAshitkin commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1312155125 ## src/test/projects/include-exclude/pom.xml: ## @@ -0,0 +1,51 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-31 Thread via GitHub
AlexanderAshitkin commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1312170655 ## src/test/projects/include-exclude/pom.xml: ## @@ -0,0 +1,51 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-31 Thread via GitHub
AlexanderAshitkin commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1312155125 ## src/test/projects/include-exclude/pom.xml: ## @@ -0,0 +1,51 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.

[GitHub] [maven-build-cache-extension] AlexanderAshitkin commented on a diff in pull request #91: [MBUILDCACHE-64] Exclusion mechanism bugfix

2023-08-31 Thread via GitHub
AlexanderAshitkin commented on code in PR #91: URL: https://github.com/apache/maven-build-cache-extension/pull/91#discussion_r1312155125 ## src/test/projects/include-exclude/pom.xml: ## @@ -0,0 +1,51 @@ + +http://www.w3.org/2001/XMLSchema-instance"; xmlns="http://maven.apache.

[GitHub] [maven] CrazyHZM commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-31 Thread via GitHub
CrazyHZM commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1312485220 ## maven-core/src/main/java/org/apache/maven/utils/dag/CycleDetectedException.java: ## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under on

[GitHub] [maven] CrazyHZM commented on a diff in pull request #1208: [MNG-7820] Remove dependency on plexus-utils

2023-08-31 Thread via GitHub
CrazyHZM commented on code in PR #1208: URL: https://github.com/apache/maven/pull/1208#discussion_r1312503644 ## maven-core/src/main/java/org/apache/maven/utils/dag/Vertex.java: ## @@ -0,0 +1,151 @@ +/* Review Comment: @gnodet Done. -- This is an automated message fr

[GitHub] [maven] olamy commented on pull request #1218: [MNG-7863] don't email on s390 failures. The regular results are enough.

2023-08-31 Thread via GitHub
olamy commented on PR #1218: URL: https://github.com/apache/maven/pull/1218#issuecomment-1702176417 @elharo ping -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr