[GitHub] [maven-enforcer] slawekjaranowski commented on pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass

slawekjaranowski commented on PR #183: URL: https://github.com/apache/maven-enforcer/pull/183#issuecomment-1237740485 @raupachz thanks for PR - looks ok. Please add corresponding documentation in this PR - we will have complete change. Files to edit are in https://github.com/apach

[GitHub] [maven-enforcer] slawekjaranowski commented on a diff in pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass

slawekjaranowski commented on code in PR #183: URL: https://github.com/apache/maven-enforcer/pull/183#discussion_r963331915 ## enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireFilesDontExist.java: ## @@ -136,6 +136,34 @@ public void testFileDoesNotExist(

[GitHub] [maven-verifier] slawekjaranowski commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1237753963 I will look at integration tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Assigned] (MSHARED-1125) Require Maven args to be provided one by one

[ https://issues.apache.org/jira/browse/MSHARED-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski reassigned MSHARED-1125: Assignee: Slawomir Jaranowski > Require Maven args to be provided one by

[jira] [Created] (SUREFIRE-2115) Unable to execute specific inner class test in Surefire

Baubak Gandomi created SUREFIRE-2115: Summary: Unable to execute specific inner class test in Surefire Key: SUREFIRE-2115 URL: https://issues.apache.org/jira/browse/SUREFIRE-2115 Project: Maven Sur

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963353890 ## src/test/java/org/apache/maven/shared/verifier/VerifierTest.java: ## @@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException asser

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963360482 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1237,20 +1237,9 @@ public void executeGoals( List goals, Map envVars ) File logF

[GitHub] [maven-verifier] michael-o commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1237775446 What about `invoker.properties`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963363365 ## src/test/java/org/apache/maven/shared/verifier/VerifierTest.java: ## @@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963364441 ## src/test/java/org/apache/maven/shared/verifier/VerifierTest.java: ## @@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException asser

[GitHub] [maven-verifier] michael-o commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-123803 > Looks good to me. Fwiw, I have found 32 references to such pattern in `maven-integration-testing` by looking for `\.addCliOption\( "[\S]+ .*"`. A PR should be raised asap to align

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963366392 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1237,20 +1237,9 @@ public void executeGoals( List goals, Map envVars ) Fi

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963367622 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1237,20 +1237,9 @@ public void executeGoals( List goals, Map envVars ) File logF

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963367622 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1237,20 +1237,9 @@ public void executeGoals( List goals, Map envVars ) File logF

[GitHub] [maven-verifier] slawekjaranowski commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1237793320 > What about `invoker.properties`? it is not used here ... it is for `maven-invoker-plugin` - I think. -- This is an automated message from the Apache Git Service. To

[GitHub] [maven-build-cache-extension] eltsovalex commented on a diff in pull request #24: [MBUILDCACHE-22] added possibility to skip cache lookup per project or globally

eltsovalex commented on code in PR #24: URL: https://github.com/apache/maven-build-cache-extension/pull/24#discussion_r963450942 ## src/main/java/org/apache/maven/buildcache/xml/CacheConfigImpl.java: ## @@ -87,6 +87,16 @@ public class CacheConfigImpl implements org.apache.mave

[jira] [Commented] (MBUILDCACHE-22) Add possibility to skip cache lookup

[ https://issues.apache.org/jira/browse/MBUILDCACHE-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600681#comment-17600681 ] ASF GitHub Bot commented on MBUILDCACHE-22: --- eltsovalex commented on code i

[GitHub] [maven-build-cache-extension] eltsovalex commented on pull request #24: [MBUILDCACHE-22] added possibility to skip cache lookup per project or globally

eltsovalex commented on PR #24: URL: https://github.com/apache/maven-build-cache-extension/pull/24#issuecomment-1237868527 Typos fixed in javadoc + new parameters described in documentation -- This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (MBUILDCACHE-22) Add possibility to skip cache lookup

[ https://issues.apache.org/jira/browse/MBUILDCACHE-22?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600683#comment-17600683 ] ASF GitHub Bot commented on MBUILDCACHE-22: --- eltsovalex commented on PR #24

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963626152 ## src/test/java/org/apache/maven/shared/verifier/VerifierTest.java: ## @@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException asser

[GitHub] [maven-verifier] michael-o commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1238064353 > > What about `invoker.properties`? > > it is not used here ... it is for `maven-invoker-plugin` - I think. Right, this is used by Invoker. -- This is an automated me

[jira] [Created] (MENFORCER-431) Skip specific rules

Delany created MENFORCER-431: Summary: Skip specific rules Key: MENFORCER-431 URL: https://issues.apache.org/jira/browse/MENFORCER-431 Project: Maven Enforcer Plugin Issue Type: New Feature

[jira] [Updated] (MENFORCER-431) Skip specific rules

[ https://issues.apache.org/jira/browse/MENFORCER-431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Delany updated MENFORCER-431: - Description: I can select rules like {code:java} mvn verify -Drules=alwaysPass,alwaysFail {code} or sk

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963652162 ## src/test/java/org/apache/maven/shared/verifier/VerifierTest.java: ## @@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException

[jira] [Commented] (MSHARED-966) Resources are not copied to ${project.build.outputDirectory}

[ https://issues.apache.org/jira/browse/MSHARED-966?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600782#comment-17600782 ] Antoine Tran commented on MSHARED-966: -- Hi, We have a very weird similar issue upg

[GitHub] [maven-enforcer] raupachz commented on a diff in pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass

raupachz commented on code in PR #183: URL: https://github.com/apache/maven-enforcer/pull/183#discussion_r963770596 ## enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireFilesDontExist.java: ## @@ -136,6 +136,34 @@ public void testFileDoesNotExist()

[GitHub] [maven-enforcer] raupachz commented on a diff in pull request #183: [MENFORCER-430] Allow one of many files in RequireFiles rules to pass

raupachz commented on code in PR #183: URL: https://github.com/apache/maven-enforcer/pull/183#discussion_r963771388 ## enforcer-rules/src/test/java/org/apache/maven/plugins/enforcer/TestRequireFilesDontExist.java: ## @@ -136,6 +136,34 @@ public void testFileDoesNotExist()

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964066549 ## src/test/java/org/apache/maven/shared/verifier/VerifierTest.java: ## @@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964087646 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1237,20 +1237,9 @@ public void executeGoals( List goals, Map envVars ) Fi

[GitHub] [maven-sources] Jesuis33 opened a new pull request, #3: Info

Jesuis33 opened a new pull request, #3: URL: https://github.com/apache/maven-sources/pull/3 C:\ProgramData\Microsoft\Diagnosis\FeedbackArchive -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [maven-sources] michael-o commented on pull request #3: Info

michael-o commented on PR #3: URL: https://github.com/apache/maven-sources/pull/3#issuecomment-1238569044 What is the purpose of this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[GitHub] [maven-sources] Jesuis33 commented on pull request #3: Info

Jesuis33 commented on PR #3: URL: https://github.com/apache/maven-sources/pull/3#issuecomment-1238569365 gh repo clone apache/maven-clean-plugin -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964096799 ## src/test/java/org/apache/maven/shared/verifier/VerifierTest.java: ## @@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException asser

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964098369 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1237,20 +1237,9 @@ public void executeGoals( List goals, Map envVars ) File logF

[jira] [Assigned] (MNG-7046) Revert MNG-5639 and make repo config static only (no ${param} interpolation)

[ https://issues.apache.org/jira/browse/MNG-7046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MNG-7046: --- Assignee: (was: Michael Osipov) > Revert MNG-5639 and make repo config static only (no ${p

[jira] [Assigned] (MDEPLOY-282) Revert MDEPLOY-231

[ https://issues.apache.org/jira/browse/MDEPLOY-282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov reassigned MDEPLOY-282: -- Assignee: (was: Michael Osipov) > Revert MDEPLOY-231 > -- > >

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964119844 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1237,20 +1237,9 @@ public void executeGoals( List goals, Map envVars ) File logF

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964121264 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1599,11 +1576,28 @@ public void setCliOptions( List cliOptions ) this.cliOptions =

[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964121301 ## src/main/java/org/apache/maven/shared/verifier/Verifier.java: ## @@ -1599,11 +1576,28 @@ public void setCliOptions( List cliOptions ) this.cliOptions =

[jira] [Created] (MSHARED-1128) Deprecate all executeGoal(s) methods

Slawomir Jaranowski created MSHARED-1128: Summary: Deprecate all executeGoal(s) methods Key: MSHARED-1128 URL: https://issues.apache.org/jira/browse/MSHARED-1128 Project: Maven Shared Component

[jira] [Updated] (MSHARED-1128) Deprecate all executeGoal(s) methods

[ https://issues.apache.org/jira/browse/MSHARED-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski updated MSHARED-1128: - Fix Version/s: maven-verifier-2.0.0 > Deprecate all executeGoal(s) methods > --

[GitHub] [maven-verifier] slawekjaranowski commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski commented on code in PR #41: URL: https://github.com/apache/maven-verifier/pull/41#discussion_r964138332 ## src/test/java/org/apache/maven/shared/verifier/VerifierTest.java: ## @@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException

[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

michael-o commented on code in PR #159: URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964140570 ## src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java: ## @@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine,

[jira] [Comment Edited] (MSHARED-1128) Deprecate all executeGoal(s) methods

[ https://issues.apache.org/jira/browse/MSHARED-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600971#comment-17600971 ] Michael Osipov edited comment on MSHARED-1128 at 9/6/22 8:33 PM:

[jira] [Commented] (MSHARED-1128) Deprecate all executeGoal(s) methods

[ https://issues.apache.org/jira/browse/MSHARED-1128?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600971#comment-17600971 ] Michael Osipov commented on MSHARED-1128: - Fantastic, but has one issue. The na

[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

alzimmermsft commented on code in PR #159: URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964153349 ## src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java: ## @@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLi

[GitHub] [maven-javadoc-plugin] michael-o commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

michael-o commented on code in PR #159: URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964160516 ## src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java: ## @@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLine,

[GitHub] [maven] michael-o commented on pull request #790: [MNG-7502] Upgrade to Guice 5.1.0

michael-o commented on PR #790: URL: https://github.com/apache/maven/pull/790#issuecomment-1238646659 Why to 3.9.x first? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0

[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600988#comment-17600988 ] ASF GitHub Bot commented on MNG-7502: - michael-o commented on PR #790: URL: https://git

[GitHub] [maven] slachiewicz commented on pull request #790: [MNG-7502] Upgrade to Guice 5.1.0

slachiewicz commented on PR #790: URL: https://github.com/apache/maven/pull/790#issuecomment-1238648290 what else do you suggest? 3.8? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0

[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600990#comment-17600990 ] ASF GitHub Bot commented on MNG-7502: - slachiewicz commented on PR #790: URL: https://g

[GitHub] [maven] michael-o commented on pull request #790: [MNG-7502] Upgrade to Guice 5.1.0

michael-o commented on PR #790: URL: https://github.com/apache/maven/pull/790#issuecomment-1238654609 I would expect master first and then go over to 3.9.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (MNG-7502) Upgrade Guice to 5.1.0

[ https://issues.apache.org/jira/browse/MNG-7502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17600999#comment-17600999 ] ASF GitHub Bot commented on MNG-7502: - michael-o commented on PR #790: URL: https://git

[GitHub] [maven-javadoc-plugin] alzimmermsft commented on a diff in pull request #159: [MJAVADOC-722] Log javadoc warnings and errors to file

alzimmermsft commented on code in PR #159: URL: https://github.com/apache/maven-javadoc-plugin/pull/159#discussion_r964177173 ## src/main/java/org/apache/maven/plugins/javadoc/AbstractJavadocMojo.java: ## @@ -6879,6 +6892,33 @@ private void writeDebugJavadocScript( String cmdLi

[jira] [Created] (MSHARED-1129) Replace CLI options with CLI args

Michael Osipov created MSHARED-1129: --- Summary: Replace CLI options with CLI args Key: MSHARED-1129 URL: https://issues.apache.org/jira/browse/MSHARED-1129 Project: Maven Shared Components I

[GitHub] [maven-verifier] michael-o commented on pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

michael-o commented on PR #41: URL: https://github.com/apache/maven-verifier/pull/41#issuecomment-1238926625 @slawekjaranowski FYI: https://issues.apache.org/jira/browse/MSHARED-1129 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

[jira] [Updated] (MSHARED-1129) Replace CLI options with CLI args

[ https://issues.apache.org/jira/browse/MSHARED-1129?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MSHARED-1129: Description: As it turns out now, any type of arguments are passed, not just options or g

[GitHub] [maven-verifier] slawekjaranowski merged pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

slawekjaranowski merged PR #41: URL: https://github.com/apache/maven-verifier/pull/41 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...

[jira] [Commented] (MSHARED-1125) Require Maven args to be provided one by one

[ https://issues.apache.org/jira/browse/MSHARED-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17601143#comment-17601143 ] Hudson commented on MSHARED-1125: - Build succeeded in Jenkins: Maven » Maven TLP » mave

[jira] [Closed] (MSHARED-1125) Require Maven args to be provided one by one

[ https://issues.apache.org/jira/browse/MSHARED-1125?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Slawomir Jaranowski closed MSHARED-1125. Resolution: Fixed > Require Maven args to be provided one by one > --