[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

[GitBox]

michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963367622


##########
src/main/java/org/apache/maven/shared/verifier/Verifier.java:
##########
@@ -1237,20 +1237,9 @@ public void executeGoals( List<String> goals, 
Map<String, String> envVars )
 
         File logFile = new File( getBasedir(), getLogFileName() );
 
-        for ( Object cliOption : cliOptions )
+        for ( String cliOption : cliOptions )
         {
-            String key = String.valueOf( cliOption );
-
-            String resolvedArg = resolveCommandLineArg( key );
-
-            try
-            {
-                args.addAll( Arrays.asList( 
CommandLineUtils.translateCommandline( resolvedArg ) ) );
-            }
-            catch ( Exception e )
-            {
-                e.printStackTrace();
-            }
+            args.add( resolveCommandLineArg( cliOption ) );

Review Comment:
   I know, but why is there so much fiddling afterwards. I if this truy for 
basedir, then the method needs to be renamed and handle basedir only.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org