[GitHub] [maven-verifier] michael-o commented on a diff in pull request #41: [MSHARED-1125] Require Maven args to be provided one by one

[GitBox]

michael-o commented on code in PR #41:
URL: https://github.com/apache/maven-verifier/pull/41#discussion_r963364441


##########
src/test/java/org/apache/maven/shared/verifier/VerifierTest.java:
##########
@@ -130,4 +139,74 @@ void testDefaultFilterMap() throws VerificationException
         assertTrue( filterMap.containsKey( "@basedir@" ) );
         assertTrue( filterMap.containsKey( "@baseurl@" ) );
     }
+
+    @Test
+    void testDefaultMavenArgument() throws VerificationException
+    {
+        TestVerifier verifier = new TestVerifier( "src/test/resources" );
+
+        verifier.executeGoal( "test" );

Review Comment:
   > I saw it ... I thinking to deprecate all `executeGoal` methods and replace 
it by one `execute()` without arguments, in fact it is next command line 
argument ... but in next change if we wish
   
   I absolutely support this position!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org