[GitHub] [maven-surefire] SammyVimes commented on pull request #493: [SUREFIRE-2039] Fix skipped test classes reporting

2022-03-21 Thread GitBox
SammyVimes commented on pull request #493: URL: https://github.com/apache/maven-surefire/pull/493#issuecomment-1073576107 @Tibor17 JIRA report has a reproducer attached to it, it's really small (https://github.com/SammyVimesFiledIssues/SUREFIRE-2039). I fully understand that this patch at

[GitHub] [maven-surefire] SammyVimes edited a comment on pull request #493: [SUREFIRE-2039] Fix skipped test classes reporting

2022-03-21 Thread GitBox
SammyVimes edited a comment on pull request #493: URL: https://github.com/apache/maven-surefire/pull/493#issuecomment-1073576107 @Tibor17 JIRA report has a reproducer attached to it, it's really small (https://github.com/SammyVimesFiledIssues/SUREFIRE-2039). I fully understand that this pa

[jira] [Updated] (SUREFIRE-2039) Skipped test classes are getting into the non-skipped test classes reports

2022-03-21 Thread Semyon Danilov (Jira)
[ https://issues.apache.org/jira/browse/SUREFIRE-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Semyon Danilov updated SUREFIRE-2039: - Description: The setup: maven-surefire-plugin 3.0.0-M5 and junit 5.8.2. Consider a si

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

2022-03-21 Thread GitBox
Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r830868641 ## File path: surefire-its/src/test/resources/junit5-suite/pom.xml ## @@ -0,0 +1,78 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi

[GitHub] [maven-surefire] Tibor17 commented on a change in pull request #494: [SUREFIRE-2040] No tests executed with junit-platform-suite and -Dtest=TestSuite

2022-03-21 Thread GitBox
Tibor17 commented on a change in pull request #494: URL: https://github.com/apache/maven-surefire/pull/494#discussion_r830868641 ## File path: surefire-its/src/test/resources/junit5-suite/pom.xml ## @@ -0,0 +1,78 @@ + + + +http://maven.apache.org/POM/4.0.0"; + xmlns:xsi

[GitHub] [maven] slawekjaranowski commented on a change in pull request #285: [MNG-5222] - Maven 3 no longer logs warnings about deprecated parameter in plugin

2022-03-21 Thread GitBox
slawekjaranowski commented on a change in pull request #285: URL: https://github.com/apache/maven/pull/285#discussion_r830902927 ## File path: maven-core/src/main/java/org/apache/maven/plugin/internal/ValidatingConfigurationListener.java ## @@ -94,4 +111,53 @@ private void not

[GitHub] [maven-apache-parent] slawekjaranowski commented on pull request #72: Stage site build and use site-pom.xml

2022-03-21 Thread GitBox
slawekjaranowski commented on pull request #72: URL: https://github.com/apache/maven-apache-parent/pull/72#issuecomment-1073682700 next build will fail without it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the U

[jira] [Commented] (MASSEMBLY-941) file permissions removed during assembly:single since 3.2.0

2022-03-21 Thread Piotr Zygielo (Jira)
[ https://issues.apache.org/jira/browse/MASSEMBLY-941?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509731#comment-17509731 ] Piotr Zygielo commented on MASSEMBLY-941: - This seems to be documented/caused

[GitHub] [maven-scm] pzygielo commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git

2022-03-21 Thread GitBox
pzygielo commented on pull request #134: URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1073727797 @michael-o @cstamas Could we have this change reviewed, please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

[jira] [Created] (SUREFIRE-2041) Order test classes according to -Dtest

2022-03-21 Thread Jira
Aslak Hellesøy created SUREFIRE-2041: Summary: Order test classes according to -Dtest Key: SUREFIRE-2041 URL: https://issues.apache.org/jira/browse/SUREFIRE-2041 Project: Maven Surefire I

[GitHub] [maven-surefire] aslakhellesoy commented on a change in pull request #492: Tests runorder

2022-03-21 Thread GitBox
aslakhellesoy commented on a change in pull request #492: URL: https://github.com/apache/maven-surefire/pull/492#discussion_r830998561 ## File path: surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java ## @@ -270,18 +276,57 @@ p

[GitHub] [maven-surefire] aslakhellesoy closed pull request #492: Tests runorder

2022-03-21 Thread GitBox
aslakhellesoy closed pull request #492: URL: https://github.com/apache/maven-surefire/pull/492 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: iss

[GitHub] [maven-surefire] aslakhellesoy opened a new pull request #495: [SUREFIRE-2041] Order test classes according to -Dtest property

2022-03-21 Thread GitBox
aslakhellesoy opened a new pull request #495: URL: https://github.com/apache/maven-surefire/pull/495 This is a fix for [SUREFIRE-2041](https://issues.apache.org/jira/browse/SUREFIRE-2041). It introduces a new "test" `TestOrder` which orders test classes according to the tests specif

[GitHub] [maven-surefire] aslakhellesoy commented on a change in pull request #492: Tests runorder

2022-03-21 Thread GitBox
aslakhellesoy commented on a change in pull request #492: URL: https://github.com/apache/maven-surefire/pull/492#discussion_r831018487 ## File path: surefire-providers/surefire-junit4/src/main/java/org/apache/maven/surefire/junit4/JUnit4Provider.java ## @@ -270,18 +276,57 @@ p

[GitHub] [maven-surefire] aslakhellesoy commented on pull request #348: Enabling Surefire to run test classes and test methods in any order specified by a new runOrder

2022-03-21 Thread GitBox
aslakhellesoy commented on pull request #348: URL: https://github.com/apache/maven-surefire/pull/348#issuecomment-1073805631 Hi @winglam - I have created a JIRA issue related to this: https://issues.apache.org/jira/browse/SUREFIRE-2041 In that JIRA issue I have outlined why I don't t

[GitHub] [maven-surefire] aslakhellesoy edited a comment on pull request #348: Enabling Surefire to run test classes and test methods in any order specified by a new runOrder

2022-03-21 Thread GitBox
aslakhellesoy edited a comment on pull request #348: URL: https://github.com/apache/maven-surefire/pull/348#issuecomment-1073805631 Hi @winglam - I have created a JIRA issue related to this: https://issues.apache.org/jira/browse/SUREFIRE-2041, with a related PR: https://github.com/apache/m

[GitHub] [maven-surefire] Tibor17 commented on pull request #348: Enabling Surefire to run test classes and test methods in any order specified by a new runOrder

2022-03-21 Thread GitBox
Tibor17 commented on pull request #348: URL: https://github.com/apache/maven-surefire/pull/348#issuecomment-1073870512 @winglam @aslakhellesoy See my comment https://github.com/apache/maven-surefire/pull/348#issuecomment-1022724116 and see whatever surefire provider implementatio

[jira] [Created] (MSHADE-413) Maven share plugin enters endless loop

2022-03-21 Thread Robert Stupp (Jira)
Robert Stupp created MSHADE-413: --- Summary: Maven share plugin enters endless loop Key: MSHADE-413 URL: https://issues.apache.org/jira/browse/MSHADE-413 Project: Maven Shade Plugin Issue Type:

[jira] [Commented] (MSHADE-413) Maven share plugin enters endless loop

2022-03-21 Thread Robert Stupp (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509907#comment-17509907 ] Robert Stupp commented on MSHADE-413: - Reproducer from projectnessie: # {{git clone h

[jira] [Commented] (MSHADE-413) Maven share plugin enters endless loop

2022-03-21 Thread Robert Stupp (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509913#comment-17509913 ] Robert Stupp commented on MSHADE-413: - But... even with {{promoteTransitiveDependenci

[GitHub] [maven] jglick commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-21 Thread GitBox
jglick commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1074003594 I suppose https://github.com/apache/maven/blob/af9c75e1ed6b1cc277823e8dcda181a86e2693db/maven-core/src/main/java/org/apache/maven/internal/aether/MavenChainedWorkspaceReader.java#L99

[GitHub] [maven-enforcer] dependabot[bot] opened a new pull request #143: Bump maven-jxr-plugin from 3.1.1 to 3.2.0

2022-03-21 Thread GitBox
dependabot[bot] opened a new pull request #143: URL: https://github.com/apache/maven-enforcer/pull/143 Bumps [maven-jxr-plugin](https://github.com/apache/maven-jxr) from 3.1.1 to 3.2.0. Commits https://github.com/apache/maven-jxr/commit/18fc9949eb030ef174dee47ee1cc11bc23a906d5

[GitHub] [maven-shade-plugin] snazy opened a new pull request #124: [MSHADE-413] Fix endless loop caused by manipulating shared objects

2022-03-21 Thread GitBox
snazy opened a new pull request #124: URL: https://github.com/apache/maven-shade-plugin/pull/124 Maven objects (like `Dependency` or `Model`) returned by Maven must not be modified. Doing so will result in endless loops or incorrect builds. Following this checklist to help us incor

[jira] [Commented] (MSHADE-413) Maven share plugin enters endless loop

2022-03-21 Thread Robert Stupp (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17509977#comment-17509977 ] Robert Stupp commented on MSHADE-413: - The reason for the latter is that the exclusio

[GitHub] [maven] laeubi commented on pull request #695: [MNG-7432] Dependencies from profile not picked up via -P

2022-03-21 Thread GitBox
laeubi commented on pull request #695: URL: https://github.com/apache/maven/pull/695#issuecomment-1074208880 > I suppose > > https://github.com/apache/maven/blob/af9c75e1ed6b1cc277823e8dcda181a86e2693db/maven-core/src/main/java/org/apache/maven/internal/aether/MavenChainedWorkspaceRe

[GitHub] [maven-apache-parent] hboutemy commented on pull request #72: Stage site build (that uses site-pom.xml)

2022-03-21 Thread GitBox
hboutemy commented on pull request #72: URL: https://github.com/apache/maven-apache-parent/pull/72#issuecomment-1074226243 I don't know what `ff-site-goal:` means, but `site site:stage -f site-pom.xml` seams reasonable personally, building locally will be much easier that downloading fo

[GitHub] [maven-surefire] winglam commented on pull request #348: Enabling Surefire to run test classes and test methods in any order specified by a new runOrder

2022-03-21 Thread GitBox
winglam commented on pull request #348: URL: https://github.com/apache/maven-surefire/pull/348#issuecomment-1074266300 @aslakhellesoy as the very first message in this PR explains already, the capability for Surefire to order test methods is already implemented -- albeit implemented in a w

[GitHub] [maven-surefire] winglam edited a comment on pull request #348: Enabling Surefire to run test classes and test methods in any order specified by a new runOrder

2022-03-21 Thread GitBox
winglam edited a comment on pull request #348: URL: https://github.com/apache/maven-surefire/pull/348#issuecomment-1074266300 @aslakhellesoy as the very first message in this PR explains already, the capability for Surefire to order test methods is already implemented -- albeit implemented

[jira] [Updated] (MSHADE-413) Maven share plugin enters endless loop

2022-03-21 Thread Robert Stupp (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Stupp updated MSHADE-413: Description: Two issues at play here: * {{ShadeMojo.createDependencyReducedPom()}} pulls in {{origD

[jira] [Updated] (MSHADE-413) Maven share plugin enters endless loop

2022-03-21 Thread Robert Stupp (Jira)
[ https://issues.apache.org/jira/browse/MSHADE-413?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Stupp updated MSHADE-413: Description: Two issues at play here: * {{ShadeMojo.createDependencyReducedPom()}} pulls in {{origD

[GitHub] [maven-scm] michael-o commented on pull request #134: [SCM-976] GitExe Changelog supports current versions of git

2022-03-21 Thread GitBox
michael-o commented on pull request #134: URL: https://github.com/apache/maven-scm/pull/134#issuecomment-1074329223 Please ping me on Friday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (MNG-7437) Optional profile informs user twice

2022-03-21 Thread Giovanni van der Schelde (Jira)
Giovanni van der Schelde created MNG-7437: - Summary: Optional profile informs user twice Key: MNG-7437 URL: https://issues.apache.org/jira/browse/MNG-7437 Project: Maven Issue Type: B

[jira] [Commented] (MNG-7437) Optional profile informs user twice

2022-03-21 Thread Giovanni van der Schelde (Jira)
[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510106#comment-17510106 ] Giovanni van der Schelde commented on MNG-7437: --- If we want to remove this ex

[jira] [Updated] (MNG-7437) Optional profile that are not found logs warning twice

2022-03-21 Thread Giovanni van der Schelde (Jira)
[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giovanni van der Schelde updated MNG-7437: -- Summary: Optional profile that are not found logs warning twice (was: Optional p

[jira] [Updated] (MNG-7437) Optional profiles that are not found logs warning twice

2022-03-21 Thread Giovanni van der Schelde (Jira)
[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Giovanni van der Schelde updated MNG-7437: -- Summary: Optional profiles that are not found logs warning twice (was: Optional

[jira] [Comment Edited] (MNG-7437) Optional profiles that are not found logs warning twice

2022-03-21 Thread Giovanni van der Schelde (Jira)
[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510106#comment-17510106 ] Giovanni van der Schelde edited comment on MNG-7437 at 3/21/22, 9:32 PM:

[GitHub] [maven-jlink-plugin] dependabot[bot] opened a new pull request #102: Bump actions/cache from 2 to 3

2022-03-21 Thread GitBox
dependabot[bot] opened a new pull request #102: URL: https://github.com/apache/maven-jlink-plugin/pull/102 Bumps [actions/cache](https://github.com/actions/cache) from 2 to 3. Release notes Sourced from https://github.com/actions/cache/releases";>actions/cache's releases. v

[GitHub] [maven] sun-qiwei opened a new pull request #699: Refactoring

2022-03-21 Thread GitBox
sun-qiwei opened a new pull request #699: URL: https://github.com/apache/maven/pull/699 some refactoring on maven-core components to increase the readability and reduce coupling as well as increase cohesion. -- This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [maven-surefire] Tibor17 opened a new pull request #496: [SUREFIRE-1426] Fork crash doesn't fail build with -Dmaven.test.failure.ignore=true

2022-03-21 Thread GitBox
Tibor17 opened a new pull request #496: URL: https://github.com/apache/maven-surefire/pull/496 I am focusing on the only class SurefireHelper and unit tests. The integration test can be taken from #478 . Following this checklist to help us incorporate your contribution quickly

[jira] [Commented] (MNG-7437) Optional profiles that are not found logs warning twice

2022-03-21 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17510256#comment-17510256 ] Michael Osipov commented on MNG-7437: - Not a bug, it has been introduced intentionally.

[jira] [Updated] (MNG-7437) Optional profiles that are not found logs warning twice

2022-03-21 Thread Michael Osipov (Jira)
[ https://issues.apache.org/jira/browse/MNG-7437?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7437: Fix Version/s: wontfix-candidate > Optional profiles that are not found logs warning twice >