Robert Stupp created MSHADE-413:
-----------------------------------

             Summary: Maven share plugin enters endless loop 
                 Key: MSHADE-413
                 URL: https://issues.apache.org/jira/browse/MSHADE-413
             Project: Maven Shade Plugin
          Issue Type: Bug
    Affects Versions: 3.2.4
            Reporter: Robert Stupp


{{ShadeMojo.createDependencyReducedPom()}} pulls in {{origDeps = 
project.getDependencies()}} and later modifies these {{Dependency}} objects.

This leads to a 
[reproducible|https://github.com/projectnessie/nessie/issues/3678] endless loop 
(see below).

If the Shade plugin's not using the {{Dependency}} objects "owned by Maven 
itself" (by setting {{promoteTransitiveDependencies}} to {{true}}), the build 
passes fine.

I think, _modifying_ the {{Dependency}} objects "owned by Maven itself" is bad 
for two reasons (which IMO justify the increased priority of this ticket): 
# the reproducible endless loop
# it breaks the correctness of the project build - at least plugins running 
after the {{shade}} goal that use those dependencies.




--
This message was sent by Atlassian Jira
(v8.20.1#820001)

Reply via email to