bmarwell commented on a change in pull request #21:
URL: https://github.com/apache/maven-jlink-plugin/pull/21#discussion_r537306217
##
File path: src/main/java/org/apache/maven/plugins/jlink/JLinkMojo.java
##
@@ -428,11 +437,12 @@ private JLinkExecutor getExecutor()
re
sparsick commented on a change in pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537309765
##
File path: pom.xml
##
@@ -109,6 +109,11 @@
commons-lang3
3.6
+
Review comment:
@bmarwell What do you mean with
michael-o commented on a change in pull request #4:
URL: https://github.com/apache/maven-filtering/pull/4#discussion_r537310677
##
File path:
src/test/java/org/apache/maven/shared/filtering/DefaultMavenResourcesFilteringTest.java
##
@@ -489,6 +489,88 @@ public void testInclude
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245047#comment-17245047
]
Michael Osipov commented on WAGON-575:
--
I am not really happy with the PR:
* It ist
K-J-Henken commented on a change in pull request #62:
URL: https://github.com/apache/maven-release/pull/62#discussion_r537334647
##
File path:
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
##
@@ -387,4 +403,27 @@ protected void pre
michael-o commented on a change in pull request #62:
URL: https://github.com/apache/maven-release/pull/62#discussion_r537335786
##
File path:
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
##
@@ -387,4 +403,27 @@ protected void prep
pzygielo opened a new pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/MEJB) filedfor the change
(usually before you start working on it). Trivial changes like typos do not
Piotr Zygielo created MEJB-130:
--
Summary: Plugin does not accept ejbVersion 4.0
Key: MEJB-130
URL: https://issues.apache.org/jira/browse/MEJB-130
Project: Maven EJB Plugin
Issue Type: Bug
pzygielo commented on pull request #11:
URL: https://github.com/apache/maven-ejb-plugin/pull/11#issuecomment-739791557
May I ask for review, please?
This is an automated message from the Apache Git Service.
To respond to the
[
https://issues.apache.org/jira/browse/MEJB-130?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Piotr Zygielo updated MEJB-130:
---
Description:
EJB being now with Jakarta is released with new spec under the version 4.0
([https://repo
bmarwell commented on a change in pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537365831
##
File path: pom.xml
##
@@ -109,6 +109,11 @@
commons-lang3
3.6
+
Review comment:
On slack there was a discussion
slachiewicz commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-739809104
To be on safe side, we may also bump min Maven to 3.1.1 (as another ticket)
This is an automated mess
sparsick commented on a change in pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537373774
##
File path: pom.xml
##
@@ -109,6 +109,11 @@
commons-lang3
3.6
+
Review comment:
Oh, I see. Thank you for explana
cquoss opened a new pull request #109:
URL: https://github.com/apache/maven-scm/pull/109
Pull request for SCM-947.
Make all parameter of changelog request available in changelog mojo.
This is an automated message from the
Tibor17 commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-739907654
@gianm
Pls add your test `ChecksumCalculatorTest` to the
[JUnit4SuiteTest](https://github.com/apache/maven-surefire/blob/c76ae87d3234bc27daea1cd7a175cdc4fa6608a4/maven-s
sparsick commented on pull request #23:
URL: https://github.com/apache/maven-jlink-plugin/pull/23#issuecomment-739917323
@slachiewicz Maven 3.0 as minimum came from this
[discussion](https://github.com/apache/maven-jlink-plugin/pull/9/files/fe528b2c2e3b003c146e4e322e3bcd8bcba05b77#r51375122
elharo merged pull request #34:
URL: https://github.com/apache/maven-assembly-plugin/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
elharo commented on pull request #38:
URL:
https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-739920167
have you measured the improvements? if so, what are the numbers?
This is an automated message from th
bmarwell commented on pull request #38:
URL:
https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-739924424
> have you measured the improvements? if so, what are the numbers?
Null-length arrays are known to be faster since at least 2013 iirc.
* https://shipilev
[
https://issues.apache.org/jira/browse/MINSTALL-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245225#comment-17245225
]
Ben Tatham edited comment on MINSTALL-169 at 12/7/20, 2:01 PM:
--
[
https://issues.apache.org/jira/browse/MINSTALL-169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245225#comment-17245225
]
Ben Tatham commented on MINSTALL-169:
-
I took a stab at fixing this, but it is very
bmarwell commented on pull request #28:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/28#issuecomment-739969289
CI succeeded after rebase:
https://ci-builds.apache.org/job/Maven/job/maven-box/job/maven-checkstyle-plugin/job/MCHECKSTYLE-387/
--
bmarwell closed pull request #28:
URL: https://github.com/apache/maven-checkstyle-plugin/pull/28
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL ab
bmarwell commented on pull request #28:
URL:
https://github.com/apache/maven-checkstyle-plugin/pull/28#issuecomment-739970299
Merged via
https://github.com/apache/maven-checkstyle-plugin/commit/7688eb9a621ff4932710339988fcd29e9c00d767
-
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-387?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Marwell resolved MCHECKSTYLE-387.
--
Fix Version/s: 3.1.2
Assignee: Benjamin Marwell
Resolution:
[
https://issues.apache.org/jira/browse/MCHECKSTYLE-387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245262#comment-17245262
]
Hudson commented on MCHECKSTYLE-387:
Build succeeded in Jenkins: Maven » Maven T
elharo commented on pull request #38:
URL:
https://github.com/apache/maven-assembly-plugin/pull/38#issuecomment-740008378
Far more often than not, microoptimizations like this result in no
measurable impact. All claims of performance improvements need numbers.
--
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245321#comment-17245321
]
Igor Dvorzhak commented on WAGON-575:
-
I can add configuration if retry mechanism is a
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245321#comment-17245321
]
Igor Dvorzhak edited comment on WAGON-575 at 12/7/20, 4:19 PM:
-
cquoss commented on pull request #109:
URL: https://github.com/apache/maven-scm/pull/109#issuecomment-740069340
Something in Travis CI seems broken, unrelated to my changes. For builds
with Java 6 and 7 the config does not seem to fit any more.
cquoss opened a new pull request #110:
URL: https://github.com/apache/maven-scm/pull/110
These changes would be sufficient for me to make parameter limit work with
goal changelog for providers git and svn exe.
This might seem to be an egoistic point of view and i am open to discussion
cquoss edited a comment on pull request #109:
URL: https://github.com/apache/maven-scm/pull/109#issuecomment-740069340
Something in Travis CI seems broken, unrelated to my changes. For builds
with Java 6 and 7 the config does not seem to fit any more.
install-jdk script is the culprit he
cquoss commented on pull request #109:
URL: https://github.com/apache/maven-scm/pull/109#issuecomment-740074752
Another point: Where lies the documentation for the changelog goal of the
maven-scm-plugin? An update here should be part of / done in parallel by me /
for this pull request.
gianm commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-740083248
> @gianm
> Pls add your test `ChecksumCalculatorTest` to the
[JUnit4SuiteTest](https://github.com/apache/maven-surefire/blob/c76ae87d3234bc27daea1cd7a175cdc4fa6608a4/maven-
[
https://issues.apache.org/jira/browse/WAGON-575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245396#comment-17245396
]
Michael Osipov commented on WAGON-575:
--
Some assumptions do not apply which I have ma
Tibor17 commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-740154064
@gianm
thx, now it looks fine as a complete change.
This is an automated message from the Apache Git Se
gianm commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-740157615
Hmm, now there is an error with one of the Windows builds
https://github.com/apache/maven-surefire/pull/327/checks?check_run_id=1512498690.
Any idea what is going on there? I
Tibor17 commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-740165186
I am investigating this error but i think it has nothing to do with your
changes. Anyway the `EventConsumerThread` which sits in the particular unit
test will be changed so
[
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245534#comment-17245534
]
Konrad Windszus commented on MPOM-244:
--
That sounds good. Is it possible to update to
[
https://issues.apache.org/jira/browse/MPOM-244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245543#comment-17245543
]
Michael Osipov commented on MPOM-244:
-
No, you need to replace Resolver completely, bu
[
https://issues.apache.org/jira/browse/SUREFIRE-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana reassigned SUREFIRE-1865:
--
Assignee: Tibor Digana
> ChecksumCalculator getSha1 does not compute checksums corr
[
https://issues.apache.org/jira/browse/SUREFIRE-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana updated SUREFIRE-1865:
---
Fix Version/s: 3.0.0-M6
> ChecksumCalculator getSha1 does not compute checksums correctly
Tibor17 merged pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
Tibor17 commented on pull request #327:
URL: https://github.com/apache/maven-surefire/pull/327#issuecomment-740211317
@gianm
Thx for contributing!
This is an automated message from the Apache Git Service.
To respond to th
[
https://issues.apache.org/jira/browse/SUREFIRE-1865?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tibor Digana closed SUREFIRE-1865.
--
Resolution: Fixed
https://gitbox.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=1da346
[
https://issues.apache.org/jira/browse/MNG-7035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17245712#comment-17245712
]
Guillaume Nodet commented on MNG-7035:
--
The pull request is quite big, but none of the
gnodet commented on pull request #399:
URL: https://github.com/apache/maven/pull/399#issuecomment-740437944
@pzygielo thx for reviewing. What's the next steps to get this merged ?
This is an automated message from the Apache
47 matches
Mail list logo
