bmarwell commented on a change in pull request #19:
URL: https://github.com/apache/maven-jlink-plugin/pull/19#discussion_r537365831
##########
File path: pom.xml
##########
@@ -109,6 +109,11 @@
<artifactId>commons-lang3</artifactId>
<version>3.6</version>
</dependency>
+ <dependency>
Review comment:
On slack there was a discussion that commons could either be shaded or
removed altogether for some methods. Currently it is just being used for a few
`StringUtils.isNotEmpty( output )` checks. If feasible, the whole dependencies
could be replaced by other means.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
