K-J-Henken commented on a change in pull request #62:
URL: https://github.com/apache/maven-release/pull/62#discussion_r537334647



##########
File path: 
maven-release-plugin/src/main/java/org/apache/maven/plugins/release/PrepareReleaseMojo.java
##########
@@ -387,4 +403,27 @@ protected void prepareRelease( boolean generateReleasePoms 
)
         }
     }
 
+    private String resolveLineSeparator()
+    {
+        if ( lineSeparator  == null )
+        {
+            return System.getProperty( "line.separator" );
+        }
+
+        switch ( lineSeparator )

Review comment:
       Hey, i think the "same as source" option is a good idea in general but 
not as the default option because it would change the current behavior.
   Maybe I will implement it soon, but not in this request.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to