Re: [PR] By default target Java 8 [maven-apache-parent]

2024-08-18 Thread via GitHub
kwin commented on PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251#issuecomment-2295320368 You are talking about edge cases, I am talking about a reasonable default. And the most reasonable thing for now is having the minimum version by default(!) being the target versi

Re: [PR] By default target Java 8 [maven-apache-parent]

2024-08-18 Thread via GitHub
ctubbsii commented on PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251#issuecomment-2295319659 > For me > > > I don't think it's very important to make the minimal Java version match the target version, except in JDK versions earlier than 9, > > sounds diff

Re: [PR] By default target Java 8 [maven-apache-parent]

2024-08-18 Thread via GitHub
kwin commented on PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251#issuecomment-2295316923 For me > I don't think it's very important to make the minimal Java version match the target version, except in JDK versions earlier than 9, sounds different. For me

Re: [PR] By default target Java 8 [maven-apache-parent]

2024-08-18 Thread via GitHub
ctubbsii commented on PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251#issuecomment-2295316496 > > I don't think it's very important to make the minimal Java version match the target version, except in JDK versions earlier than 9, > > I disagree as the target byte

Re: [PR] By default target Java 8 [maven-apache-parent]

2024-08-18 Thread via GitHub
kwin commented on PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251#issuecomment-2295298685 > I don't think it's very important to make the minimal Java version match the target version, except in JDK versions earlier than 9, I disagree as the target bytecode versi

Re: [PR] By default target Java 8 [maven-apache-parent]

2024-08-16 Thread via GitHub
ctubbsii commented on PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251#issuecomment-2294242469 I don't think it's very important to make the minimal Java version match the target version, except in JDK versions earlier than 9, where you also have to set the bootstrap cl

Re: [PR] By default target Java 8 [maven-apache-parent]

2024-08-16 Thread via GitHub
kwin merged PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@mave