ctubbsii commented on PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251#issuecomment-2294242469
I don't think it's very important to make the minimal Java version match the target version, except in JDK versions earlier than 9, where you also have to set the bootstrap class path to avoid incorrect cross-compilation. So, this change makes sense, so long as the minimalJavaBuildVersion is less than 11 (the first LTS version of JDK after 9 when the release flag was introduced that strictly enforces cross-compilation compatibility with the target version). Since this POM is still dealing with versions earlier than 9, this change makes sense. However, I'm wondering if it might also make sense to bump the minimalJavaBuildVersion to 11, and move the `maven.compiler.release` property out of the JDK9 profile and into the main props in the POM. That would make it difficult to use this POM with JDK versions earlier than 11, but would greatly improve cross-compilation issues for projects that still want to target Java versions earlier than 9. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
