ctubbsii commented on PR #251: URL: https://github.com/apache/maven-apache-parent/pull/251#issuecomment-2295316496
> > I don't think it's very important to make the minimal Java version match the target version, except in JDK versions earlier than 9, > > I disagree as the target bytecode version is always (except when using toolchains) the lower bound for the build java version. Cross-compilation only works for lower major versions, but not for targeting higher major versions. I don't understand what you're disagreeing with. I already know that it's the lower bound and never questioned that. The only thing I was discussing was when it's important to be an exact match. 1. `targetVersion < buildVersion && buildVersion < 9 && bootstrapClasspathIsSet`: SAFE 2. `targetVersion < buildVersion && buildVersion < 9 && !bootstrapClasspathIsSet` (before this PR): UNSAFE 3. `targetVersion == buildVersion` (after this PR): SAFE 4. `targetVersion <= buildVersion && buildVersion >= 9 && releaseFlagIsUsed`: SAFE (`==` is "not very important"; `<` is sufficient) > > The `maven-compiler-release` property is already correctly set in the parent POM (in a [dedicated Java9 profile](https://github.com/apache/maven-apache-parent/blob/ded34a863110021191af2db5b772b665a2789394/pom.xml#L530-L540)), so in case something does not work as expected here please raise a new issue @ctubbsii. Yes, I know. I directly referenced that profile in what I wrote above. It works fine. I think I'm being misunderstood. All I'm suggesting (for discussion) is whether we should go even further than this PR does, and make the minimalJavaBuildVersion default to 11 (item 4 above). I can propose that in a new PR, but I thought I'd get feedback in a comment here first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
