Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-12 Thread via GitHub
desruisseaux commented on PR #2236: URL: https://github.com/apache/maven/pull/2236#issuecomment-2799043234 JIRA issue created: https://issues.apache.org/jira/browse/MNG-8686 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-12 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2040740984 ## impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java: ## @@ -0,0 +1,475 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029909621 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +46,39 @@ default Path directory() { } /** - * {@return the li

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029900609 ## impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java: ## @@ -0,0 +1,95 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029897684 ## impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java: ## @@ -0,0 +1,475 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029896335 ## impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java: ## @@ -0,0 +1,475 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029895425 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +46,39 @@ default Path directory() { } /** - * {@return the li

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029894650 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +46,39 @@ default Path directory() { } /** - * {@return the li

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029894267 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java: ## @@ -144,13 +143,15 @@ public DefaultSourceRoot(final ProjectScope scope, final Lan

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029893641 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +46,39 @@ default Path directory() { } /** - * {@return the li

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
elharo commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029890513 ## api/maven-api-core/src/main/java/org/apache/maven/api/SourceRoot.java: ## @@ -46,23 +46,39 @@ default Path directory() { } /** - * {@return the list of

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r202943 ## impl/maven-impl/src/test/java/org/apache/maven/impl/PathSelectorTest.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r202908 ## impl/maven-impl/src/main/java/org/apache/maven/impl/PathSelector.java: ## @@ -0,0 +1,475 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + *

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029888117 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java: ## @@ -217,23 +186,45 @@ public Path directory() { } /** - * {@return

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029888013 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java: ## @@ -144,13 +143,15 @@ public DefaultSourceRoot(final ProjectScope scope, final Lan

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029887457 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java: ## @@ -144,13 +143,15 @@ public DefaultSourceRoot(final ProjectScope scope, final Lan

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
desruisseaux commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029887032 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java: ## @@ -39,9 +38,11 @@ public final class DefaultSourceRoot implements SourceRoot {

Re: [PR] Add `SourceRoot.matcher(boolean)` method [maven]

2025-04-05 Thread via GitHub
elharo commented on code in PR #2236: URL: https://github.com/apache/maven/pull/2236#discussion_r2029870918 ## impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java: ## @@ -144,13 +143,15 @@ public DefaultSourceRoot(final ProjectScope scope, final Language