desruisseaux commented on code in PR #2236:
URL: https://github.com/apache/maven/pull/2236#discussion_r2029887032
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##########
@@ -39,9 +38,11 @@
public final class DefaultSourceRoot implements SourceRoot {
private final Path directory;
- private final List<PathMatcher> includes;
+ private final List<String> includes;
- private final List<PathMatcher> excludes;
+ private final List<String> excludes;
+
+ private transient PathMatcher matcher, matcherWithDefaults;
Review Comment:
Separated the declarations and added a comment. The field is non-final
because it is a cache computed when first requested (some fields may be never
requested).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
