desruisseaux commented on code in PR #2236:
URL: https://github.com/apache/maven/pull/2236#discussion_r2029888117
##########
impl/maven-impl/src/main/java/org/apache/maven/impl/DefaultSourceRoot.java:
##########
@@ -217,23 +186,45 @@ public Path directory() {
}
/**
- * {@return the list of pattern matchers for the files to include}.
+ * {@return the list of patterns for the files to include}.
*/
@Override
@SuppressWarnings("ReturnOfCollectionOrArrayField") // Safe because
unmodifiable
- public List<PathMatcher> includes() {
+ public List<String> includes() {
return includes;
}
/**
- * {@return the list of pattern matchers for the files to exclude}.
+ * {@return the list of patterns for the files to exclude}.
*/
@Override
@SuppressWarnings("ReturnOfCollectionOrArrayField") // Safe because
unmodifiable
- public List<PathMatcher> excludes() {
+ public List<String> excludes() {
return excludes;
}
+ /**
+ * {@return a matcher combining the include and exclude patterns}.
+ *
+ * @param useDefaultExcludes whether to add <abbr>SCM</abbr> files to set
of exclude patterns
Review Comment:
Done (Source Code Management).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
