rmannibucau commented on PR #374:
URL: https://github.com/apache/maven-resolver/pull/374#issuecomment-1829239333
@cstamas assuming MJAR works and is transparently handled by the *JRE* is
wrong as I already mentionned. You are just lucky in your tests it was (side
note: as war classloader wa
cstamas commented on PR #374:
URL: https://github.com/apache/maven-resolver/pull/374#issuecomment-1828652443
I disagree with you, as MJAR in _this case_ is transparently handled by JDK
classloader, as "Maven as resolver using code" in this case is completely
oblivious (and should be oblivio
rmannibucau commented on PR #374:
URL: https://github.com/apache/maven-resolver/pull/374#issuecomment-1828410981
Strictly speaking:
* IDE was unusable before (was lost between java version) so guess it is
kind of a limitation of such setups
* I did it when working on the PR so I as
cstamas commented on PR #374:
URL: https://github.com/apache/maven-resolver/pull/374#issuecomment-1828151656
It was a wrong decision of mine to merge the PR, this PR is merely a "smart
hack" and as we know, every hack sooner or later will require more hacks down
the road. Problems with this
cstamas merged PR #374:
URL: https://github.com/apache/maven-resolver/pull/374
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.
cstamas commented on code in PR #374:
URL: https://github.com/apache/maven-resolver/pull/374#discussion_r1399481775
##
maven-resolver-transport-jdk/src/main/java/org/eclipse/aether/transport/jdk/JdkHttpTransporter.java:
##
@@ -393,12 +420,16 @@ private static HttpClient
getOrCr
cstamas commented on code in PR #374:
URL: https://github.com/apache/maven-resolver/pull/374#discussion_r1399481775
##
maven-resolver-transport-jdk/src/main/java/org/eclipse/aether/transport/jdk/JdkHttpTransporter.java:
##
@@ -393,12 +420,16 @@ private static HttpClient
getOrCr
rmannibucau opened a new pull request, #374:
URL: https://github.com/apache/maven-resolver/pull/374
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
