cstamas commented on PR #374: URL: https://github.com/apache/maven-resolver/pull/374#issuecomment-1828151656
It was a wrong decision of mine to merge the PR, this PR is merely a "smart hack" and as we know, every hack sooner or later will require more hacks down the road. Problems with this approach: * IDE is unusable * running UTs from IDE is imposible (due that above) * reusing the library is impossible in any downstream project that uses enforcer to enforce byte-code level * it produces "broken artifact", a JAR that mixes byte-code levels in non standard way (those classes are not in their "proper place" like META-INF/version but in root) -- this also have implications when enumerating classes on classpath with this jar on classpath... Am undoing this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
