cstamas commented on code in PR #374:
URL: https://github.com/apache/maven-resolver/pull/374#discussion_r1399481775
##########
maven-resolver-transport-jdk/src/main/java/org/eclipse/aether/transport/jdk/JdkHttpTransporter.java:
##########
@@ -393,12 +420,16 @@ private static HttpClient
getOrCreateClient(RepositorySystemSession session, Rem
ConfigurationProperties.CONNECT_TIMEOUT);
HttpClient.Builder builder = HttpClient.newBuilder()
- .version(HttpClient.Version.HTTP_2)
+
.version(HttpClient.Version.valueOf(ConfigUtils.getString(
+ session,
+ "HTTP_1_1", // v2 is not safe yet in the
wild
Review Comment:
I disagree, am using "jdk" transport for quite some, and also the _point_ of
this transport is to support HTTP/2 by default. Also, Maven Central supports
http/2 quite some time as well... and my testing shows that even with HTTP/2
set, client nicely downgrades to HTTP/1.1 whenever needed, ie. when using local
MRM.
I would rather revert this logic: default to http/2 but allow users to
"force" http/1.1 if needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
